From: Al Viro <viro@zeniv.linux.org.uk>
To: NeilBrown <neilb@suse.de>
Cc: Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Kent Overstreet <kent.overstreet@linux.dev>,
Trond Myklebust <trondmy@kernel.org>,
Anna Schumaker <anna@kernel.org>,
Namjae Jeon <linkinjeon@kernel.org>,
Steve French <sfrench@samba.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Tom Talpey <tom@talpey.com>, Paul Moore <paul@paul-moore.com>,
Eric Paris <eparis@redhat.com>,
linux-kernel@vger.kernel.org, linux-bcachefs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-cifs@vger.kernel.org, audit@vger.kernel.org
Subject: Re: [PATCH 2/2] VFS: add common error checks to lookup_one_qstr_excl()
Date: Wed, 12 Feb 2025 04:06:04 +0000 [thread overview]
Message-ID: <20250212040604.GN1977892@ZenIV> (raw)
In-Reply-To: <173933190416.22054.5881139463496565922@noble.neil.brown.name>
On Wed, Feb 12, 2025 at 02:45:04PM +1100, NeilBrown wrote:
> On Wed, 12 Feb 2025, Al Viro wrote:
> I do see some value in the simplicity of this approach, though maybe not
> as much value as you see. But the above uses inode_lock_share(), rather
> than the nested version, so lockdep will complain.
IDGI... It doesn't grab any ->i_rwsem inside that one, so what's there to
complain about? And in that case it returns with no locks held, so...
next prev parent reply other threads:[~2025-02-12 4:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-07 3:36 [PATCH 0/2] VFS: minor improvements to a couple of interfaces NeilBrown
2025-02-07 3:36 ` [PATCH 1/2] VFS: change kern_path_locked() and user_path_locked_at() to never return negative dentry NeilBrown
2025-02-07 3:46 ` Kent Overstreet
2025-02-07 4:53 ` NeilBrown
2025-02-07 6:13 ` Kent Overstreet
2025-02-07 6:34 ` NeilBrown
2025-02-07 6:51 ` Kent Overstreet
2025-02-07 7:30 ` NeilBrown
2025-02-07 13:35 ` Kent Overstreet
2025-02-10 1:20 ` NeilBrown
2025-02-10 16:33 ` Kent Overstreet
2025-02-12 3:24 ` NeilBrown
2025-02-07 6:51 ` [PATCH 1/2 v2] " NeilBrown
2025-02-07 6:53 ` [PATCH 1/2] " NeilBrown
2025-02-07 19:09 ` Paul Moore
2025-02-07 3:36 ` [PATCH 2/2] VFS: add common error checks to lookup_one_qstr_excl() NeilBrown
2025-02-12 2:50 ` kernel test robot
2025-02-12 3:16 ` Al Viro
2025-02-12 3:25 ` Al Viro
2025-02-12 3:45 ` NeilBrown
2025-02-12 4:06 ` Al Viro [this message]
2025-02-12 4:40 ` NeilBrown
2025-02-10 8:25 ` [PATCH 0/2] VFS: minor improvements to a couple of interfaces Christian Brauner
2025-02-10 8:42 ` Al Viro
2025-02-10 9:41 ` Christian Brauner
-- strict thread matches above, loose matches on Subject: below --
2025-02-17 0:27 [PATCH 0/2 v2] " NeilBrown
2025-02-17 0:27 ` [PATCH 2/2] VFS: add common error checks to lookup_one_qstr_excl() NeilBrown
2025-02-17 13:46 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250212040604.GN1977892@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=anna@kernel.org \
--cc=audit@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=dakr@kernel.org \
--cc=eparis@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=kent.overstreet@linux.dev \
--cc=linkinjeon@kernel.org \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=paul@paul-moore.com \
--cc=rafael@kernel.org \
--cc=senozhatsky@chromium.org \
--cc=sfrench@samba.org \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.