From: Jakub Kicinski <kuba@kernel.org>
To: Jason Xing <kerneljasonxing@gmail.com>
Cc: Mina Almasry <almasrymina@google.com>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
hawk@kernel.org, ilias.apalodimas@linaro.org, horms@kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v1] page_pool: avoid infinite loop to schedule delayed worker
Date: Wed, 12 Feb 2025 10:53:07 -0800 [thread overview]
Message-ID: <20250212105307.400ea229@kernel.org> (raw)
In-Reply-To: <CAL+tcoATHuHxpZ+4ofEkg7cba=OZxnHJSbqNHxMC5s+ZMQNR9A@mail.gmail.com>
On Wed, 12 Feb 2025 12:38:28 +0800 Jason Xing wrote:
> > Initializing a work isn't much cost, is it?
>
> Not that much, but it's pointless to start a kworker under this
> circumstance, right? And it will flood the dmesg.
There's a seriously buggy driver potentially corrupting memory,
who cares if we start a kworker. Please don't complicate the
code for extremely rare scenarios.
> > Just to state the obvious the current patch will not catch the
> > situation when there is traffic outstanding (inflight is positive)
> > at the time of detach from the driver. But then the inflight goes
> > negative before the work / time kicks in.
>
> Right, only mitigating the side effect. I will add this statement as
> well while keeping the code itself as-is.
What do you mean by that?! We're telling you your code is wrong.
next prev parent reply other threads:[~2025-02-12 18:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 13:09 [PATCH net-next v1] page_pool: avoid infinite loop to schedule delayed worker Jason Xing
2025-02-12 2:37 ` Mina Almasry
2025-02-12 2:46 ` Jakub Kicinski
2025-02-12 3:20 ` Jason Xing
2025-02-12 3:43 ` Jakub Kicinski
2025-02-12 4:38 ` Jason Xing
2025-02-12 18:53 ` Jakub Kicinski [this message]
2025-02-12 23:37 ` Jason Xing
2025-02-12 3:14 ` Jason Xing
2025-02-12 19:24 ` Mina Almasry
2025-02-12 23:38 ` Jason Xing
2025-02-13 0:38 ` Mina Almasry
2025-02-13 0:43 ` Jason Xing
2025-02-13 0:51 ` Mina Almasry
2025-02-13 1:01 ` Jason Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250212105307.400ea229@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=kerneljasonxing@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.