From: Al Viro <viro@zeniv.linux.org.uk>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: Christian Brauner <brauner@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Jeff Layton <jlayton@kernel.org>,
Adrian Ratiu <adrian.ratiu@collabora.com>,
xu xin <xu.xin16@zte.com.cn>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Felix Moessbauer <felix.moessbauer@siemens.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] proc: Use str_yes_no() helper in proc_pid_ksm_stat()
Date: Wed, 12 Feb 2025 12:04:51 +0000 [thread overview]
Message-ID: <20250212120451.GO1977892@ZenIV> (raw)
In-Reply-To: <20250212115954.111652-2-thorsten.blum@linux.dev>
On Wed, Feb 12, 2025 at 12:59:52PM +0100, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_yes_no() helper function.
> seq_printf(m, "ksm_merge_any: %s\n",
> - test_bit(MMF_VM_MERGE_ANY, &mm->flags) ? "yes" : "no");
> + str_yes_no(test_bit(MMF_VM_MERGE_ANY, &mm->flags)));
> ret = mmap_read_lock_killable(mm);
> if (ret) {
> mmput(mm);
> return ret;
> }
> seq_printf(m, "ksm_mergeable: %s\n",
> - ksm_process_mergeable(mm) ? "yes" : "no");
> + str_yes_no(ksm_process_mergeable(mm)));
Is that any more readable? If anything, that might be better off with something
like a printf modifier...
next prev parent reply other threads:[~2025-02-12 12:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 11:59 [PATCH] proc: Use str_yes_no() helper in proc_pid_ksm_stat() Thorsten Blum
2025-02-12 12:04 ` Al Viro [this message]
2025-02-12 12:11 ` Thorsten Blum
2025-02-12 12:36 ` Al Viro
2025-02-12 16:04 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250212120451.GO1977892@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=adrian.ratiu@collabora.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=felix.moessbauer@siemens.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=tglx@linutronix.de \
--cc=thorsten.blum@linux.dev \
--cc=xu.xin16@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.