From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Zaid Alali <zaidal@os.amperecomputing.com>
Cc: <rafael@kernel.org>, <lenb@kernel.org>, <james.morse@arm.com>,
<tony.luck@intel.com>, <bp@alien8.de>, <robert.moore@intel.com>,
<dan.j.williams@intel.com>, <Benjamin.Cheatham@amd.com>,
<Avadhut.Naik@amd.com>, <viro@zeniv.linux.org.uk>,
<arnd@arndb.de>, <ira.weiny@intel.com>, <dave.jiang@intel.com>,
<sthanneeru.opensrc@micron.com>, <linux-acpi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <acpica-devel@lists.linux.dev>
Subject: Re: [PATCH v3 4/9] ACPI: APEI: EINJ: Remove redundant calls to einj_get_available_error_type
Date: Wed, 12 Feb 2025 16:37:14 +0000 [thread overview]
Message-ID: <20250212163714.00002433@huawei.com> (raw)
In-Reply-To: <20250210183705.1114624-5-zaidal@os.amperecomputing.com>
On Mon, 10 Feb 2025 10:37:00 -0800
Zaid Alali <zaidal@os.amperecomputing.com> wrote:
> A single call to einj_get_available_error_type in init function is
> sufficient to save the return value in a global variable to be used
> later in various places in the code. This commit does not introduce
> any functional changes, but only removing unnecessary redundant
> function calls.
>
> Signed-off-by: Zaid Alali <zaidal@os.amperecomputing.com>
Seems reasonable to me.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
next prev parent reply other threads:[~2025-02-12 16:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 18:36 [PATCH v3 0/9] Enable EINJv2 Support Zaid Alali
2025-02-10 18:36 ` [PATCH v3 1/9] ACPICA: Update values to hex to follow ACPI specs Zaid Alali
2025-02-10 18:36 ` [PATCH v3 2/9] ACPICA: Add EINJv2 get error type action Zaid Alali
2025-02-10 18:36 ` [PATCH v3 3/9] ACPI: APEI: EINJ: Fix kernel test robot sparse warning Zaid Alali
2025-02-12 16:35 ` Jonathan Cameron
2025-02-10 18:37 ` [PATCH v3 4/9] ACPI: APEI: EINJ: Remove redundant calls to einj_get_available_error_type Zaid Alali
2025-02-12 16:37 ` Jonathan Cameron [this message]
2025-02-10 18:37 ` [PATCH v3 5/9] ACPI: APEI: EINJ: Enable the discovery of EINJv2 capabilities Zaid Alali
2025-02-12 16:47 ` Jonathan Cameron
2025-02-10 18:37 ` [PATCH v3 6/9] ACPI: APEI: EINJ: Add einjv2 extension struct Zaid Alali
2025-02-12 16:49 ` Jonathan Cameron
2025-02-10 18:37 ` [PATCH v3 7/9] ACPI: APEI: EINJ: Add debugfs files for EINJv2 support Zaid Alali
2025-02-12 16:54 ` Jonathan Cameron
2025-02-10 18:37 ` [PATCH v3 8/9] ACPI: APEI: EINJ: Enable EINJv2 error injections Zaid Alali
2025-02-12 17:04 ` Jonathan Cameron
2025-02-10 18:37 ` [PATCH v3 9/9] ACPI: APEI: EINJ: Update the documentation for EINJv2 support Zaid Alali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250212163714.00002433@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=Avadhut.Naik@amd.com \
--cc=Benjamin.Cheatham@amd.com \
--cc=acpica-devel@lists.linux.dev \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ira.weiny@intel.com \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robert.moore@intel.com \
--cc=sthanneeru.opensrc@micron.com \
--cc=tony.luck@intel.com \
--cc=viro@zeniv.linux.org.uk \
--cc=zaidal@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.