All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <frederic@kernel.org>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Frederic Weisbecker <frederic@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
	Boqun Feng <boqun.feng@gmail.com>,
	Waiman Long <longman@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	Hayes Wang <hayeswang@realtek.com>,
	linux-usb@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH 0/2] net: Fix/prevent napi_schedule() call from bare task context
Date: Wed, 12 Feb 2025 18:43:27 +0100	[thread overview]
Message-ID: <20250212174329.53793-1-frederic@kernel.org> (raw)

Hi,

Here is a fix to a bad context calling napi_schedule() and a lockdep
assertion to prevent from that in the future. I've tried to produce
a relevant Fixes tag but I'm not confident enough with this codebase.
This call is there for many years and yet the issue got reported only
recently, so I may be missing something in the history of this driver
or in net/usb infrastructure...

Thanks.

Frederic Weisbecker (2):
  net: Assert proper context while calling napi_schedule()
  r8152: Call napi_schedule() from proper context

 drivers/net/usb/r8152.c |  5 ++++-
 include/linux/lockdep.h | 12 ++++++++++++
 net/core/dev.c          |  1 +
 3 files changed, 17 insertions(+), 1 deletion(-)

-- 
2.46.0


             reply	other threads:[~2025-02-12 17:43 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-12 17:43 Frederic Weisbecker [this message]
2025-02-12 17:43 ` [PATCH 1/2] net: Assert proper context while calling napi_schedule() Frederic Weisbecker
2025-02-13  3:48   ` Jakub Kicinski
2025-02-13  9:58     ` Breno Leitao
2025-02-13 15:14       ` Jakub Kicinski
2025-02-13 18:14         ` Breno Leitao
2025-02-13 19:04           ` Jakub Kicinski
2025-02-13 20:38             ` Frederic Weisbecker
2025-02-14 22:00               ` Jakub Kicinski
2025-02-15 21:16                 ` Frederic Weisbecker
2025-02-14 13:05             ` Breno Leitao
2025-02-14 16:43         ` Breno Leitao
2025-02-14 22:10           ` Jakub Kicinski
2025-02-17 16:46             ` Breno Leitao
2025-02-17 17:37               ` Jakub Kicinski
2025-02-13 20:39     ` Frederic Weisbecker
2025-02-14 22:03       ` Jakub Kicinski
2025-02-12 17:43 ` [PATCH 2/2] r8152: Call napi_schedule() from proper context Frederic Weisbecker
2025-02-12 20:49   ` Francois Romieu
2025-02-12 20:58     ` Frederic Weisbecker
2025-02-18 20:12       ` Paul Menzel
2025-04-27 20:50         ` Tobias Jakobi
2025-04-28 17:49           ` Jakub Kicinski
2025-04-28 20:26             ` Tobias Jakobi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250212174329.53793-1-frederic@kernel.org \
    --to=frederic@kernel.org \
    --cc=boqun.feng@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hayeswang@realtek.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.