From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <shaw.leon@gmail.com>
Cc: <alex.aring@gmail.com>, <andrew+netdev@lunn.ch>,
<b.a.t.m.a.n@lists.open-mesh.org>, <bpf@vger.kernel.org>,
<bridge@lists.linux.dev>, <davem@davemloft.net>,
<donald.hunter@gmail.com>, <dsahern@kernel.org>,
<edumazet@google.com>, <herbert@gondor.apana.org.au>,
<horms@kernel.org>, <kuba@kernel.org>, <kuniyu@amazon.com>,
<linux-can@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-kselftest@vger.kernel.org>, <linux-ppp@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, <linux-wireless@vger.kernel.org>,
<linux-wpan@vger.kernel.org>, <miquel.raynal@bootlin.com>,
<netdev@vger.kernel.org>, <osmocom-net-gprs@lists.osmocom.org>,
<pabeni@redhat.com>, <shuah@kernel.org>,
<stefan@datenfreihafen.org>, <steffen.klassert@secunet.com>,
<wireguard@lists.zx2c4.com>
Subject: Re: [PATCH net-next v9 04/11] ieee802154: 6lowpan: Validate link netns in newlink() of rtnl_link_ops
Date: Thu, 13 Feb 2025 14:48:53 +0900 [thread overview]
Message-ID: <20250213054853.285-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20250210133002.883422-5-shaw.leon@gmail.com>
From: Xiao Liang <shaw.leon@gmail.com>
Date: Mon, 10 Feb 2025 21:29:55 +0800
> Device denoted by IFLA_LINK is in link_net (IFLA_LINK_NETNSID) or
> source netns by design, but 6lowpan uses dev_net.
>
> Note dev->netns_local is set to true and currently link_net is
> implemented via a netns change. These together effectively reject
> IFLA_LINK_NETNSID.
>
> This patch adds a validation to ensure link_net is either NULL or
> identical to dev_net. Thus it would be fine to continue using dev_net
> when rtnetlink core begins to create devices directly in target netns.
>
> Signed-off-by: Xiao Liang <shaw.leon@gmail.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
next prev parent reply other threads:[~2025-02-13 5:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 13:29 [PATCH net-next v9 00/11] net: Improve netns handling in rtnetlink Xiao Liang
2025-02-10 13:29 ` [PATCH net-next v9 01/11] rtnetlink: Lookup device in target netns when creating link Xiao Liang
2025-02-10 13:29 ` [PATCH net-next v9 02/11] rtnetlink: Pack newlink() params into struct Xiao Liang
2025-02-13 6:53 ` Kuniyuki Iwashima
2025-02-13 8:36 ` Xiao Liang
2025-02-13 9:17 ` Paolo Abeni
2025-02-13 10:01 ` Xiao Liang
2025-02-10 13:29 ` [PATCH net-next v9 03/11] net: Use link netns in newlink() of rtnl_link_ops Xiao Liang
2025-02-13 6:55 ` Kuniyuki Iwashima
2025-02-10 13:29 ` [PATCH net-next v9 04/11] ieee802154: 6lowpan: Validate " Xiao Liang
2025-02-13 5:48 ` Kuniyuki Iwashima [this message]
2025-02-10 13:29 ` [PATCH net-next v9 05/11] net: ip_tunnel: Use " Xiao Liang
2025-02-13 6:20 ` Kuniyuki Iwashima
2025-02-13 8:27 ` Xiao Liang
2025-02-10 13:29 ` [PATCH net-next v9 06/11] net: ipv6: " Xiao Liang
2025-02-13 7:05 ` Kuniyuki Iwashima
2025-02-13 8:37 ` Xiao Liang
2025-02-13 9:55 ` Xiao Liang
2025-02-13 11:00 ` Kuniyuki Iwashima
2025-02-14 9:22 ` Xiao Liang
2025-02-14 10:51 ` Kuniyuki Iwashima
2025-02-10 13:29 ` [PATCH net-next v9 07/11] net: xfrm: " Xiao Liang
2025-02-10 13:29 ` [PATCH net-next v9 08/11] rtnetlink: Remove "net" from newlink params Xiao Liang
2025-02-10 13:30 ` [PATCH net-next v9 09/11] rtnetlink: Create link directly in target net namespace Xiao Liang
2025-02-10 13:30 ` [PATCH net-next v9 10/11] selftests: net: Add python context manager for netns entering Xiao Liang
2025-02-10 13:30 ` [PATCH net-next v9 11/11] selftests: net: Add test cases for link and peer netns Xiao Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213054853.285-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=alex.aring@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=bpf@vger.kernel.org \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=osmocom-net-gprs@lists.osmocom.org \
--cc=pabeni@redhat.com \
--cc=shaw.leon@gmail.com \
--cc=shuah@kernel.org \
--cc=stefan@datenfreihafen.org \
--cc=steffen.klassert@secunet.com \
--cc=wireguard@lists.zx2c4.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.