From: Jakub Kicinski <kuba@kernel.org>
To: Michal Luczaj <mhal@rbox.co>
Cc: Stefano Garzarella <sgarzare@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org,
syzbot+9d55b199192a4be7d02c@syzkaller.appspotmail.com,
Luigi Leonardi <leonardi@redhat.com>
Subject: Re: [PATCH net v3 0/2] vsock: null-ptr-deref when SO_LINGER enabled
Date: Thu, 13 Feb 2025 07:24:37 -0800 [thread overview]
Message-ID: <20250213072437.111da6fc@kernel.org> (raw)
In-Reply-To: <04190424-8d8f-48c4-9d07-ce5c2f09d5a1@rbox.co>
On Thu, 13 Feb 2025 11:15:43 +0100 Michal Luczaj wrote:
> On 2/13/25 05:02, Jakub Kicinski wrote:
> > On Mon, 10 Feb 2025 13:14:59 +0100 Michal Luczaj wrote:
> >> Fixes fcdd2242c023 ("vsock: Keep the binding until socket destruction").
> >
> > I don't think it's a good idea to put Fixes tags into the cover letters.
> > Not sure what purpose it'd serve.
>
> I was trying to say it's a "follow up" to a very recent (at least in the
> vsock context) patch-gone-wrong. But I did not intend to make this a tag;
> it's not a "Fixes:" with a colon :)
>
> Anyway, if that puts too much detail into the cover letter, I'll refrain
> from doing so.
Never too much detail :) But if it's informative and for humans I'd
recommend weaving it into the explanation or adding some words around.
Sorry for the nit picking.
next prev parent reply other threads:[~2025-02-13 15:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 12:14 [PATCH net v3 0/2] vsock: null-ptr-deref when SO_LINGER enabled Michal Luczaj
2025-02-10 12:15 ` [PATCH net v3 1/2] vsock: Orphan socket after transport release Michal Luczaj
2025-02-10 12:40 ` Stefano Garzarella
2025-02-10 12:15 ` [PATCH net v3 2/2] vsock/test: Add test for SO_LINGER null ptr deref Michal Luczaj
2025-02-13 4:02 ` [PATCH net v3 0/2] vsock: null-ptr-deref when SO_LINGER enabled Jakub Kicinski
2025-02-13 10:15 ` Michal Luczaj
2025-02-13 15:24 ` Jakub Kicinski [this message]
2025-02-14 13:15 ` Michal Luczaj
2025-02-13 4:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213072437.111da6fc@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=leonardi@redhat.com \
--cc=mhal@rbox.co \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=syzbot+9d55b199192a4be7d02c@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.