From: Al Viro <viro@zeniv.linux.org.uk>
To: Jinliang Zheng <alexjlzheng@gmail.com>
Cc: brauner@kernel.org, jack@suse.cz, alexjlzheng@tencent.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: remove useless d_unhashed() retry in d_alloc_parallel()
Date: Thu, 13 Feb 2025 13:20:06 +0000 [thread overview]
Message-ID: <20250213132006.GV1977892@ZenIV> (raw)
In-Reply-To: <20250213122137.11830-1-alexjlzheng@tencent.com>
On Thu, Feb 13, 2025 at 08:21:37PM +0800, Jinliang Zheng wrote:
> After commit 45f78b0a2743 ("fs/dcache: Move the wakeup from
> __d_lookup_done() to the caller."), we will only wake up
> d_wait_lookup() after adding dentry to dentry_hashtable.
Not true. d_lookup_done() might be called without having
*ever* hashed the sucker.
Just think for a moment - what, for example, should happen
if ->lookup() fails? Would you have d_alloc_parallel()
coming during that ->lookup() (while dentry is in in-lookup
hash) hang forever?
NAK.
next prev parent reply other threads:[~2025-02-13 13:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 12:21 [PATCH] fs: remove useless d_unhashed() retry in d_alloc_parallel() Jinliang Zheng
2025-02-13 13:20 ` Al Viro [this message]
2025-02-14 1:43 ` Jinliang Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213132006.GV1977892@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=alexjlzheng@gmail.com \
--cc=alexjlzheng@tencent.com \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.