Re: [RFC 2/3] fs: modify writeback infra to work with wb_ctx

[kernel test robot <lkp@intel.com>]

Hi Kundan,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on 57d357a7663c4025c68ae07974b679d84e2d5d1a]

url:    https://github.com/intel-lab-lkp/linux/commits/Kundan-Kumar/writeback-add-parallel-writeback-infrastructure/20250212-211021
base:   57d357a7663c4025c68ae07974b679d84e2d5d1a
patch link:    https://lore.kernel.org/r/20250212103634.448437-3-kundan.kumar%40samsung.com
patch subject: [RFC 2/3] fs: modify writeback infra to work with wb_ctx
config: arc-randconfig-002-20250213 (https://download.01.org/0day-ci/archive/20250213/202502131351.uG7U2prq-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250213/202502131351.uG7U2prq-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502131351.uG7U2prq-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/fs-writeback.c:130: warning: Function parameter or struct member 'p_wb_ctx' not described in 'inode_io_list_move_locked_ctx'
>> fs/fs-writeback.c:334: warning: Function parameter or struct member 'p_wb_ctx' not described in 'inode_cgwb_move_to_attached_ctx'
>> fs/fs-writeback.c:334: warning: expecting prototype for inode_cgwb_move_to_attached(). Prototype was for inode_cgwb_move_to_attached_ctx() instead


vim +130 fs/fs-writeback.c

d6c10f1fc8626d Tejun Heo    2015-05-22  115  
d6c10f1fc8626d Tejun Heo    2015-05-22  116  /**
4f84ead3d4293c Kundan Kumar 2025-02-12  117   * inode_io_list_move_locked_ctx - move an inode onto a wb_ctx IO list
d6c10f1fc8626d Tejun Heo    2015-05-22  118   * @inode: inode to be moved
d6c10f1fc8626d Tejun Heo    2015-05-22  119   * @wb: target bdi_writeback
bbbc3c1cfaf690 Wang Long    2017-12-05  120   * @head: one of @wb->b_{dirty|io|more_io|dirty_time}
d6c10f1fc8626d Tejun Heo    2015-05-22  121   *
c7f5408493aeb0 Dave Chinner 2015-03-04  122   * Move @inode->i_io_list to @list of @wb and set %WB_has_dirty_io.
d6c10f1fc8626d Tejun Heo    2015-05-22  123   * Returns %true if @inode is the first occupant of the !dirty_time IO
d6c10f1fc8626d Tejun Heo    2015-05-22  124   * lists; otherwise, %false.
d6c10f1fc8626d Tejun Heo    2015-05-22  125   */
4f84ead3d4293c Kundan Kumar 2025-02-12  126  static bool inode_io_list_move_locked_ctx(struct inode *inode,
d6c10f1fc8626d Tejun Heo    2015-05-22  127  					  struct bdi_writeback *wb,
4f84ead3d4293c Kundan Kumar 2025-02-12  128  					  struct list_head *head,
4f84ead3d4293c Kundan Kumar 2025-02-12  129  					  struct wb_ctx *p_wb_ctx)
d6c10f1fc8626d Tejun Heo    2015-05-22 @130  {
4f84ead3d4293c Kundan Kumar 2025-02-12  131  	struct list_head *pctx_b_dirty_time = &p_wb_ctx->pctx_b_dirty_time;
4f84ead3d4293c Kundan Kumar 2025-02-12  132  
4f84ead3d4293c Kundan Kumar 2025-02-12  133  
d6c10f1fc8626d Tejun Heo    2015-05-22  134  	assert_spin_locked(&wb->list_lock);
10e14073107dd0 Jchao Sun    2022-05-24  135  	assert_spin_locked(&inode->i_lock);
a9438b44bc7015 Jan Kara     2022-12-12  136  	WARN_ON_ONCE(inode->i_state & I_FREEING);
d6c10f1fc8626d Tejun Heo    2015-05-22  137  
c7f5408493aeb0 Dave Chinner 2015-03-04  138  	list_move(&inode->i_io_list, head);
d6c10f1fc8626d Tejun Heo    2015-05-22  139  
d6c10f1fc8626d Tejun Heo    2015-05-22  140  	/* dirty_time doesn't count as dirty_io until expiration */
4f84ead3d4293c Kundan Kumar 2025-02-12  141  	if (head != pctx_b_dirty_time)
4f84ead3d4293c Kundan Kumar 2025-02-12  142  		return wb_ctx_io_lists_populated(wb, p_wb_ctx);
d6c10f1fc8626d Tejun Heo    2015-05-22  143  
4f84ead3d4293c Kundan Kumar 2025-02-12  144  	wb_ctx_io_lists_depopulated(wb, p_wb_ctx);
d6c10f1fc8626d Tejun Heo    2015-05-22  145  	return false;
d6c10f1fc8626d Tejun Heo    2015-05-22  146  }
d6c10f1fc8626d Tejun Heo    2015-05-22  147  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki