From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30C3926B083; Thu, 13 Feb 2025 14:54:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739458451; cv=none; b=khyhA3jDTUp6Zy5KMcc1+DDQB7DoxSsUvrar2i1cPd1JI81cyz6wX0hhqnnlX9MJJzjK3zreoB5zkNGrI1TdnBw86SCnPBHz00jB9QYC1SefmbPEV30zZ0tKaj/uVw+uCp/NkP5NWFndfpD9vpk9RcE5PXq73eMkB1q5RMqDDqw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739458451; c=relaxed/simple; bh=OXUuh0AU5xgTpU05OG1b8iBPD+cXNCu6OwTTxF45DSc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Rfu9OBtlCANCaDiNH9CX3gozCDTCz/rzqLdW/yy2fSZ1+Ix3OL/dho0aaoH51TTC/fSapv+98w2rKgijl3ERmA3Wr7Qy2nYwck8ttqEw6QhzWF9LqVkk3y2X/1uIzjj8qFn2dhb7Q1p8n1CiMArqlYAZRjxPqzHeh2/Y0ZJBXG4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=nk5+T6Yh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="nk5+T6Yh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 415E0C4CED1; Thu, 13 Feb 2025 14:54:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1739458450; bh=OXUuh0AU5xgTpU05OG1b8iBPD+cXNCu6OwTTxF45DSc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nk5+T6Yh/rEQt1C+lwm1kLkN7tATPv+JRziOg4n7SyhmLnG5lDxpKBt3PWn0fiiQf KBAIx8ZIL2Lv7EnNr3wr8QqER7ZdpwGkmgVXdpoD6OWOyeHL53B+KpfCQ2BrundAnT aKJVfQIk+45bwPXxO/GKCagdBsgHdp/RfJuGyJOc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Frank Li , Wolfram Sang , Mukesh Kumar Savaliya , Miquel Raynal , Alexandre Belloni Subject: [PATCH 6.12 371/422] i3c: master: Fix missing ret assignment in set_speed() Date: Thu, 13 Feb 2025 15:28:40 +0100 Message-ID: <20250213142450.864871200@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250213142436.408121546@linuxfoundation.org> References: <20250213142436.408121546@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Frank Li commit b266e0d4dac00eecdfaf50ec3f708fd0c3b39637 upstream. Fix a probe failure in the i3c master driver that occurs when no i3c devices are connected to the bus. The issue arises in `i3c_master_bus_init()` where the `ret` value is not updated after calling `master->ops->set_speed()`. If no devices are present, `ret` remains set to `I3C_ERROR_M2`, causing the code to incorrectly proceed to `err_bus_cleanup`. Cc: stable@vger.kernel.org Fixes: aef79e189ba2 ("i3c: master: support to adjust first broadcast address speed") Signed-off-by: Frank Li Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang Acked-by: Mukesh Kumar Savaliya Reviewed-by: Miquel Raynal Link: https://lore.kernel.org/r/20250108225533.915334-1-Frank.Li@nxp.com Signed-off-by: Alexandre Belloni Signed-off-by: Greg Kroah-Hartman --- drivers/i3c/master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -1919,7 +1919,7 @@ static int i3c_master_bus_init(struct i3 goto err_bus_cleanup; if (master->ops->set_speed) { - master->ops->set_speed(master, I3C_OPEN_DRAIN_NORMAL_SPEED); + ret = master->ops->set_speed(master, I3C_OPEN_DRAIN_NORMAL_SPEED); if (ret) goto err_bus_cleanup; }