From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CCBE26B091; Thu, 13 Feb 2025 15:15:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739459743; cv=none; b=L4e+d39VxOeH3pLss5cGVJbpsZD0y5RPAQlyzd2DUek5AdBJV/ISchweYIN1gH/drkKmL9XpaVIs8rCb95hYqVNctSqv/2Fj10MicSAvdZPtFcgdEtXj6Cc5/7Ujdmice9wiDjiC9AZFc3PGaitXD7D/xZleW6KbTT00IT5LIZQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739459743; c=relaxed/simple; bh=13taCr/vGDYemdj4RRMSPEibCtiSALsCR1jB9BF2LRE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C9e2pMKgV5XZWMQakj+DEbh4Nx1E2GCQ/EIzOHOD8k609AXwMxjyCti7zU8QtLkkidZ4xSAEfJzm5d2XqE5AvIrnRbkjYdVfKwGImtj4Z65MuSB6xoywIDOiObv4cmHtye+Gv7TS9j5p7EnaFc3FtJgR2rMxETdu1tiC+5N+36g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=pkh/mxfv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="pkh/mxfv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13A8AC4CED1; Thu, 13 Feb 2025 15:15:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1739459743; bh=13taCr/vGDYemdj4RRMSPEibCtiSALsCR1jB9BF2LRE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pkh/mxfv9WC35Y0O2hFiJIrVRKDdB/CbnmGJr5mwR25x2rPFOi3nR8BxX2+G2BVlm PzWG1wkx9NZbLbvAh0klIJbGJJ0jVC7ziUU1K+XG0qU8sZSe+hmV72SjsMYyzHO4Vq 7CFLa7cJkZVO379ThwVsmNQRzLDY+hh8a14Ogc2k= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Krzysztof Kozlowski , AngeloGioacchino Del Regno Subject: [PATCH 6.13 352/443] soc: mediatek: mtk-devapc: Fix leaking IO map on error paths Date: Thu, 13 Feb 2025 15:28:37 +0100 Message-ID: <20250213142454.200762598@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250213142440.609878115@linuxfoundation.org> References: <20250213142440.609878115@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.13-stable review patch. If anyone has any objections, please let me know. ------------------ From: Krzysztof Kozlowski commit c0eb059a4575ed57f265d9883a5203799c19982c upstream. Error paths of mtk_devapc_probe() should unmap the memory. Reported by Smatch: drivers/soc/mediatek/mtk-devapc.c:292 mtk_devapc_probe() warn: 'ctx->infra_base' from of_iomap() not released on lines: 277,281,286. Fixes: 0890beb22618 ("soc: mediatek: add mt6779 devapc driver") Cc: stable@vger.kernel.org Signed-off-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20250104142012.115974-1-krzysztof.kozlowski@linaro.org Signed-off-by: AngeloGioacchino Del Regno Signed-off-by: Greg Kroah-Hartman --- drivers/soc/mediatek/mtk-devapc.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) --- a/drivers/soc/mediatek/mtk-devapc.c +++ b/drivers/soc/mediatek/mtk-devapc.c @@ -273,23 +273,31 @@ static int mtk_devapc_probe(struct platf return -EINVAL; devapc_irq = irq_of_parse_and_map(node, 0); - if (!devapc_irq) - return -EINVAL; + if (!devapc_irq) { + ret = -EINVAL; + goto err; + } ctx->infra_clk = devm_clk_get_enabled(&pdev->dev, "devapc-infra-clock"); - if (IS_ERR(ctx->infra_clk)) - return -EINVAL; + if (IS_ERR(ctx->infra_clk)) { + ret = -EINVAL; + goto err; + } ret = devm_request_irq(&pdev->dev, devapc_irq, devapc_violation_irq, IRQF_TRIGGER_NONE, "devapc", ctx); if (ret) - return ret; + goto err; platform_set_drvdata(pdev, ctx); start_devapc(ctx); return 0; + +err: + iounmap(ctx->infra_base); + return ret; } static void mtk_devapc_remove(struct platform_device *pdev)