From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 408D626B0BF; Thu, 13 Feb 2025 15:18:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739459939; cv=none; b=uGqszIDlDISv3obP3XVIKutGGIjIaoMd+dpE2xLnWQVEiPX4N3IGPe9ti8DF2HDfsAZtB2LFkjVnS7RpCDTTYotL6Qr6MFG+qBafvsN/eJXFSKJOoed6EnhJLKpgZ3MC7ZtnCoFm/3nWS9ntqd/tGPSMXp/M6op6LlKlEbEaTOo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739459939; c=relaxed/simple; bh=dnBy3BN16SXNozrhNda77XO8qEtQAb9BzcgBqawbL/8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MaFOiZ+fonaz9ck8t3Eh4NGWgj0wAZpfeuoVpFk7QEYoWXzI5CtAEdkq1oghek9v/Pq2BBm9HmViX7W2AhXRJHoYmkOGvOqHINf3pePKQZ97DQBGU3++qAduUsiagO1FG+MFXYxO1WSL7noCTPMzWhkW9O5ClSiud8IbPJkSBMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=z1INcwYW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="z1INcwYW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5722DC4CED1; Thu, 13 Feb 2025 15:18:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1739459938; bh=dnBy3BN16SXNozrhNda77XO8qEtQAb9BzcgBqawbL/8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=z1INcwYWHbYhtbJd7qNBgTa4Q5Lx67Wdw9WP36VTcxMTD2KGTqH/1rjDzTCF7tg6e LB02En9VNltlucqi+zydyXhG1trejKxt8Evs3RqfrcQS8+ehYmYt/CQ+GCnvXX1B0Z wZEAsDqDagJQ7u5JAg543LLfJzU4iKq0n0mTHzt8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Frank Li , Wolfram Sang , Mukesh Kumar Savaliya , Miquel Raynal , Alexandre Belloni Subject: [PATCH 6.13 408/443] i3c: master: Fix missing ret assignment in set_speed() Date: Thu, 13 Feb 2025 15:29:33 +0100 Message-ID: <20250213142456.352980463@linuxfoundation.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250213142440.609878115@linuxfoundation.org> References: <20250213142440.609878115@linuxfoundation.org> User-Agent: quilt/0.68 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.13-stable review patch. If anyone has any objections, please let me know. ------------------ From: Frank Li commit b266e0d4dac00eecdfaf50ec3f708fd0c3b39637 upstream. Fix a probe failure in the i3c master driver that occurs when no i3c devices are connected to the bus. The issue arises in `i3c_master_bus_init()` where the `ret` value is not updated after calling `master->ops->set_speed()`. If no devices are present, `ret` remains set to `I3C_ERROR_M2`, causing the code to incorrectly proceed to `err_bus_cleanup`. Cc: stable@vger.kernel.org Fixes: aef79e189ba2 ("i3c: master: support to adjust first broadcast address speed") Signed-off-by: Frank Li Reviewed-by: Wolfram Sang Tested-by: Wolfram Sang Acked-by: Mukesh Kumar Savaliya Reviewed-by: Miquel Raynal Link: https://lore.kernel.org/r/20250108225533.915334-1-Frank.Li@nxp.com Signed-off-by: Alexandre Belloni Signed-off-by: Greg Kroah-Hartman --- drivers/i3c/master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -1919,7 +1919,7 @@ static int i3c_master_bus_init(struct i3 goto err_bus_cleanup; if (master->ops->set_speed) { - master->ops->set_speed(master, I3C_OPEN_DRAIN_NORMAL_SPEED); + ret = master->ops->set_speed(master, I3C_OPEN_DRAIN_NORMAL_SPEED); if (ret) goto err_bus_cleanup; }