From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1ECEE25A623; Fri, 14 Feb 2025 11:54:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.211.166.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739534064; cv=none; b=PADrSmCsaeSfDs4WmrJFg6GWE5PVfY8QMjYioiKOLUd838KoY7MXNH4+uIo76HFLd4hejeRzEsooP8vdbqfEXczSBp6kVAX2pTMNMbYqOczkU5VCAienrSgXKFWu1Iy0k9DDx0jue2mPNpYn05c5zGNvKEEiSmFH86fXJ3ARYt4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739534064; c=relaxed/simple; bh=WqM6pCi7iPCKYwn6UXNd4FgAcsKn5Chxq/5jqmqGaTw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DuyYjz1QS0yJ+Mo4hd6xDB435wn+ts8e0Z+svXvUZpLuuL5SfIkWPRWG+P1I8sC46ZB2/8XUt+BIdyQPd0M+Rve7q1D1RU8Oo6GhPSRN8C3gonab06/ObluZPJzPhq3QhZtWfScGO0vbA2M7jj4RoRckgCrYaXhdM0pHYLM5bvo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org; spf=pass smtp.mailfrom=gentoo.org; arc=none smtp.client-ip=140.211.166.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gentoo.org Received: from localhost (unknown [180.172.76.141]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dlan) by smtp.gentoo.org (Postfix) with ESMTPSA id 3263A3430DA; Fri, 14 Feb 2025 11:54:20 +0000 (UTC) Date: Fri, 14 Feb 2025 11:54:10 +0000 From: Yixun Lan To: Linus Walleij Cc: Rob Herring , Olof Johansson , Bartosz Golaszewski , Krzysztof Kozlowski , Conor Dooley , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Yangyu Chen , Jisheng Zhang , Jesse Taube , Inochi Amaoto , Icenowy Zheng , Meng Zhang , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v4 1/4] dt-bindings: gpio: spacemit: add support for K1 SoC Message-ID: <20250214115410-GYA21743@gentoo> References: <20250121-03-k1-gpio-v4-1-4641c95c0194@gentoo.org> <20250123113042-GYA38135@gentoo> <20250127181726.GA538260-robh@kernel.org> <20250128031712-GYB47737@gentoo> <20250206133156-GYA5687@gentoo> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi Linus: On 14:07 Thu 13 Feb , Linus Walleij wrote: > On Thu, Feb 6, 2025 at 2:32 PM Yixun Lan wrote: > > > > > foo-gpios <&gpio 2 7 GPIO_ACTIVE_LOW>; > > > > if we model the dts as above, then "&gpio" will register itself as one sole "struct gpio_chip", > > which mean one gpio chip combine three banks.. > > Not really: the fact that there is just one gpio node in the device > tree does not > mean that it needs to correspond to one single gpio_chip instance inside the > Linux kernel. > > It's just what the current existing bindings and the code in the GPIO subsystem > assumes. It does not have to assume that: we can change it. > > I'm sorry if this is not entirely intuitive :( > > One node can very well spawn three gpio_chip instances, but it requires > some core changes. But I think it's the most elegant. > > > if taking "one gpio chip support multi banks" direction, then it will be reverted back as patch V1, > > then, even the three gpio-cells model is unnecessary needed, as we can map gpio number > > to the array in the underlying gpio driver > > > > the v4 patch is very similar to drivers/gpio/gpio-dwapb.c > > > > If had to choose the direction between v1 and v4, I personally would favor the latter, > > as from hw perspective, each gpio bank is quite indepedent - has its own io/irq registers, > > merely has interleaved io memory space, one shared IRQ line.. also the patch v4 leverage > > lots underlying generic gpio APIs, result in much simplified/clean code base.. > > So what I would suggest is a combination of the two. > > One gpio node in the device tree, like the DT maintainers want it. > > Three struct gpio_chip instances inside the driver, all three spawn from > that single gpio device, and from that single platform_device. > > What we are suggesting is a three-cell phandle in the device tree: > > foo-gpios = <&gpio 0 7 GPIO_ACTIVE_HIGH>; > bar-gpios = <&gpio 2 31 GPIO_ACTIVE_HIGH>; > > Notice the new first cell which is 0 or 2. > > The first one is what was previously called gpio 7. > The second one is what was 2*32+31 = gpio 95. > > So internally in the driver it is easy to use the first cell (0 or 2) to map to > the right struct gpio_chip if you have it in your driver something like this: > > struct spacemit_gpio { > struct gpio_chip gcs[3]; > ... > }; > > struct spacemit_gpio *sg; > struct gpio_chip *gc; > int ret; > > for (i = 0; i++; i < 3) { > ret = devm_gpiochip_add_data(dev, &sg->gcs[i], sg); > if (ret) > return ret; > gc = sg->gcs[i]; > .... do stuff with this instance .... > } > > Callbacks etc should work as before. > > Then these phandles needs to be properly translated, which is done with the > struct gpio_chip .of_xlate() callback. (If you look inside gpiolib-of.c > you will see that chip->of_xlate() is called to map the phandle cells > to a certain GPIO line). > > In most cases, drivers do not assign the chip->of_xlate callback > (one exception is gpio-pxa.c) and then it is default-assigned to > of_gpio_simple_xlate() which you can find in gpiolib-of.c as well. > > You need to copy this callback to your driver and augment it > properly. > > The xlate callback is used to locate the struct gpio_chip and > struct gpio_device as well, by just calling the xlate callback, so if > you code up the right xlate callback, everything should just > work by itself. > > this is a guess on what it would look like (just dry coding, > but hopefully the idea works!): > > static int spacemit_gpio_xlate(struct gpio_chip *gc, > const struct of_phandle_args *gpiospec, > u32 *flags) > { > struct spacemit_gpio *sg = gpiochip_get_data(gc); > int i; > > if (gc->of_gpio_n_cells != 3) > return -EINVAL; > > if (gpiospec->args_count < gc->of_gpio_n_cells) > return -EINVAL; > > /* We support maximum 3 gpio_chip instances */ > i = gpiospec->args[0]; > if (i >= 3) > return -EINVAL; > > /* OK is this the right gpio_chip out of the three ? */ > if (gc != sg->gcs[i]) > return -EINVAL; > > /* Are we in range for this GPIO chip */ > if (gpiospec->args[1] >= gc->ngpio) > return -EINVAL; > > if (flags) > *flags = gpiospec->args[2]; > > /* Return the hw index */ > return gpiospec->args[1]; > } > thanks for this very detail prototype! it works mostly, with one problem: how to map gpio correctly to the pin from pinctrl subsystem? for example, I specify gpio-ranges in dts, then gpio0: gpio@d4019000 { compatible = "spacemit,k1-gpio"; reg = <0x0 0xd4019000 0x0 0x100>; ... gpio-ranges = <&pinctrl 0 0 96>; }; foo-gpios = <&gpio0 2 28 GPIO_ACTIVE_LOW>; It should get GPIO_92 ( 92 = 2 * 32 + 28), but turns out GPIO_28 Probably there is something I missed... > ... > gc->of_gpio_n_cells = 3; > gc->of_xlate = spacemit_gpio_xlate; > > If it works as I hope, this will make the code in gpiolib-of.c in > of_find_gpio_device_by_xlate() calling gpio_device_find() > (which will iterate over all registered gpio_chips and then > of_gpiochip_match_node_and_xlate() will call this custom function > to see if it's the right one and return > 0 when we have the right > chip. > > This should work for gpios *only*. When we then come to irqs, > these assume (see gpiolib.c) that we are using > irq_domain_xlate_twocell() when using GPIOLIB_IRQCHIP, so > you either need to roll your own irqchip code or we should fix Sounds I should implement something like irq_domain_xlate_threecell()? > the core (I can help with this if the above works). > > Several gpio chips use their own domain translation outside > of the gpiolib so you can use this as an intermediate step: > git grep irq_domain_ops drivers/gpio/ .. > ... but if you get here, let's patch the core to deal with custom > irqdomain xlate functions in the same manner as above. > I like this direction, but how we should proceed? > I hope this isn't terribly unclear or complicated? > Otherwise tell me and I will try to ... explain more or give > up and say you can use a single 96-pin gpio_chip. > Let's try first, sounds it's a feasible way. Many thanks! > Yours, > Linus Walleij -- Yixun Lan (dlan) Gentoo Linux Developer GPG Key ID AABEFD55 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18843C02198 for ; Fri, 14 Feb 2025 11:54:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YE/RJswHyvhprlni3UVX9wVdlkjQsrWARr37qUKMtN8=; b=EkZy3tTWLUG0kF u6VzcEHcU+ntuO1nM2SIQSCy41Uy+XrLbn+Lv2qXb9ZSKUf71dpBmJB7ObC5SsyS/H7NO3fINyRBs 5E/lN/muGrtc3SH7PUptBSJPNPGiE/IL0pTCAPSPQzLRy30tRqf3SFHPkD0qlXRnJGzUhHnQZfAUh uvPt4Dq2K86EFCWqUeNzefDdprB4pNysmu+Yt35aLvylOERMG42SzLrJLGmkHlx3WrYbQ+VXKuNJX GzOeSxiGE1IFJ4MuKvIKe1XyUJaW8e3dF0o6dHMCPu24I5v8V+V1q/sRrSd5IfZqWKRQ+IDQx2DO6 ceMy/bC/q1E9ED8D9gNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tiuH6-0000000ElHm-0b80; Fri, 14 Feb 2025 11:54:28 +0000 Received: from dev.gentoo.org ([2001:470:ea4a:1:5054:ff:fec7:86e4] helo=smtp.gentoo.org) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tiuH3-0000000ElGF-0T33 for linux-riscv@lists.infradead.org; Fri, 14 Feb 2025 11:54:26 +0000 Received: from localhost (unknown [180.172.76.141]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dlan) by smtp.gentoo.org (Postfix) with ESMTPSA id 3263A3430DA; Fri, 14 Feb 2025 11:54:20 +0000 (UTC) Date: Fri, 14 Feb 2025 11:54:10 +0000 From: Yixun Lan To: Linus Walleij Subject: Re: [PATCH v4 1/4] dt-bindings: gpio: spacemit: add support for K1 SoC Message-ID: <20250214115410-GYA21743@gentoo> References: <20250121-03-k1-gpio-v4-1-4641c95c0194@gentoo.org> <20250123113042-GYA38135@gentoo> <20250127181726.GA538260-robh@kernel.org> <20250128031712-GYB47737@gentoo> <20250206133156-GYA5687@gentoo> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250214_035425_183381_D0048145 X-CRM114-Status: GOOD ( 52.21 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Conor Dooley , Meng Zhang , linux-gpio@vger.kernel.org, Bartosz Golaszewski , linux-kernel@vger.kernel.org, Conor Dooley , Yangyu Chen , devicetree@vger.kernel.org, Palmer Dabbelt , Jesse Taube , Jisheng Zhang , Paul Walmsley , Olof Johansson , Inochi Amaoto , Krzysztof Kozlowski , linux-riscv@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org SGkgTGludXM6CgpPbiAxNDowNyBUaHUgMTMgRmViICAgICAsIExpbnVzIFdhbGxlaWogd3JvdGU6 Cj4gT24gVGh1LCBGZWIgNiwgMjAyNSBhdCAyOjMy4oCvUE0gWWl4dW4gTGFuIDxkbGFuQGdlbnRv by5vcmc+IHdyb3RlOgo+IAo+ID4gPiA+IGZvby1ncGlvcyA8JmdwaW8gMiA3IEdQSU9fQUNUSVZF X0xPVz47Cj4gPgo+ID4gaWYgd2UgbW9kZWwgdGhlIGR0cyBhcyBhYm92ZSwgdGhlbiAiJmdwaW8i IHdpbGwgcmVnaXN0ZXIgaXRzZWxmIGFzIG9uZSBzb2xlICJzdHJ1Y3QgZ3Bpb19jaGlwIiwKPiA+ ICB3aGljaCBtZWFuIG9uZSBncGlvIGNoaXAgY29tYmluZSB0aHJlZSBiYW5rcy4uCj4gCj4gTm90 IHJlYWxseTogdGhlIGZhY3QgdGhhdCB0aGVyZSBpcyBqdXN0IG9uZSBncGlvIG5vZGUgaW4gdGhl IGRldmljZQo+IHRyZWUgZG9lcyBub3QKPiBtZWFuIHRoYXQgaXQgbmVlZHMgdG8gY29ycmVzcG9u ZCB0byBvbmUgc2luZ2xlIGdwaW9fY2hpcCBpbnN0YW5jZSBpbnNpZGUgdGhlCj4gTGludXgga2Vy bmVsLgo+IAo+IEl0J3MganVzdCB3aGF0IHRoZSBjdXJyZW50IGV4aXN0aW5nIGJpbmRpbmdzIGFu ZCB0aGUgY29kZSBpbiB0aGUgR1BJTyBzdWJzeXN0ZW0KPiBhc3N1bWVzLiBJdCBkb2VzIG5vdCBo YXZlIHRvIGFzc3VtZSB0aGF0OiB3ZSBjYW4gY2hhbmdlIGl0Lgo+IAo+IEknbSBzb3JyeSBpZiB0 aGlzIGlzIG5vdCBlbnRpcmVseSBpbnR1aXRpdmUgOigKPiAKPiBPbmUgbm9kZSBjYW4gdmVyeSB3 ZWxsIHNwYXduIHRocmVlIGdwaW9fY2hpcCBpbnN0YW5jZXMsIGJ1dCBpdCByZXF1aXJlcwo+IHNv bWUgY29yZSBjaGFuZ2VzLiBCdXQgSSB0aGluayBpdCdzIHRoZSBtb3N0IGVsZWdhbnQuCj4gCj4g PiBpZiB0YWtpbmcgIm9uZSBncGlvIGNoaXAgc3VwcG9ydCBtdWx0aSBiYW5rcyIgZGlyZWN0aW9u LCB0aGVuIGl0IHdpbGwgYmUgcmV2ZXJ0ZWQgYmFjayBhcyBwYXRjaCBWMSwKPiA+IHRoZW4sIGV2 ZW4gdGhlIHRocmVlIGdwaW8tY2VsbHMgbW9kZWwgaXMgdW5uZWNlc3NhcnkgbmVlZGVkLCBhcyB3 ZSBjYW4gbWFwIGdwaW8gbnVtYmVyCj4gPiAgdG8gdGhlIDxiYW5rLCBvZmZzZXQ+IGFycmF5IGlu IHRoZSB1bmRlcmx5aW5nIGdwaW8gZHJpdmVyCj4gPgo+ID4gdGhlIHY0IHBhdGNoIGlzIHZlcnkg c2ltaWxhciB0byBkcml2ZXJzL2dwaW8vZ3Bpby1kd2FwYi5jCj4gPgo+ID4gSWYgaGFkIHRvIGNo b29zZSB0aGUgZGlyZWN0aW9uIGJldHdlZW4gdjEgYW5kIHY0LCBJIHBlcnNvbmFsbHkgd291bGQg ZmF2b3IgdGhlIGxhdHRlciwKPiA+ICBhcyBmcm9tIGh3IHBlcnNwZWN0aXZlLCBlYWNoIGdwaW8g YmFuayBpcyBxdWl0ZSBpbmRlcGVkZW50IC0gaGFzIGl0cyBvd24gaW8vaXJxIHJlZ2lzdGVycywK PiA+ICBtZXJlbHkgaGFzIGludGVybGVhdmVkIGlvIG1lbW9yeSBzcGFjZSwgb25lIHNoYXJlZCBJ UlEgbGluZS4uIGFsc28gdGhlIHBhdGNoIHY0IGxldmVyYWdlCj4gPiAgbG90cyB1bmRlcmx5aW5n IGdlbmVyaWMgZ3BpbyBBUElzLCByZXN1bHQgaW4gbXVjaCBzaW1wbGlmaWVkL2NsZWFuIGNvZGUg YmFzZS4uCj4gCj4gU28gd2hhdCBJIHdvdWxkIHN1Z2dlc3QgaXMgYSBjb21iaW5hdGlvbiBvZiB0 aGUgdHdvLgo+IAo+IE9uZSBncGlvIG5vZGUgaW4gdGhlIGRldmljZSB0cmVlLCBsaWtlIHRoZSBE VCBtYWludGFpbmVycyB3YW50IGl0Lgo+IAo+IFRocmVlIHN0cnVjdCBncGlvX2NoaXAgaW5zdGFu Y2VzIGluc2lkZSB0aGUgZHJpdmVyLCBhbGwgdGhyZWUgc3Bhd24gZnJvbQo+IHRoYXQgc2luZ2xl IGdwaW8gZGV2aWNlLCBhbmQgZnJvbSB0aGF0IHNpbmdsZSBwbGF0Zm9ybV9kZXZpY2UuCj4gCj4g V2hhdCB3ZSBhcmUgc3VnZ2VzdGluZyBpcyBhIHRocmVlLWNlbGwgcGhhbmRsZSBpbiB0aGUgZGV2 aWNlIHRyZWU6Cj4gCj4gZm9vLWdwaW9zID0gPCZncGlvIDAgNyBHUElPX0FDVElWRV9ISUdIPjsK PiBiYXItZ3Bpb3MgPSA8JmdwaW8gMiAzMSBHUElPX0FDVElWRV9ISUdIPjsKPiAKPiBOb3RpY2Ug dGhlIG5ldyBmaXJzdCBjZWxsIHdoaWNoIGlzIDAgb3IgMi4KPiAKPiBUaGUgZmlyc3Qgb25lIGlz IHdoYXQgd2FzIHByZXZpb3VzbHkgY2FsbGVkIGdwaW8gNy4KPiBUaGUgc2Vjb25kIG9uZSBpcyB3 aGF0IHdhcyAyKjMyKzMxID0gZ3BpbyA5NS4KPiAKPiBTbyBpbnRlcm5hbGx5IGluIHRoZSBkcml2 ZXIgaXQgaXMgZWFzeSB0byB1c2UgdGhlIGZpcnN0IGNlbGwgKDAgb3IgMikgdG8gbWFwIHRvCj4g dGhlIHJpZ2h0IHN0cnVjdCBncGlvX2NoaXAgaWYgeW91IGhhdmUgaXQgaW4geW91ciBkcml2ZXIg c29tZXRoaW5nIGxpa2UgdGhpczoKPiAKPiBzdHJ1Y3Qgc3BhY2VtaXRfZ3BpbyB7Cj4gICAgIHN0 cnVjdCBncGlvX2NoaXAgZ2NzWzNdOwo+IC4uLgo+IH07Cj4gCj4gc3RydWN0IHNwYWNlbWl0X2dw aW8gKnNnOwo+IHN0cnVjdCBncGlvX2NoaXAgKmdjOwo+IGludCByZXQ7Cj4gCj4gZm9yIChpID0g MDsgaSsrOyBpIDwgMykgewo+ICAgICAgcmV0ID0gZGV2bV9ncGlvY2hpcF9hZGRfZGF0YShkZXYs ICZzZy0+Z2NzW2ldLCBzZyk7Cj4gICAgICBpZiAocmV0KQo+ICAgICAgICAgcmV0dXJuIHJldDsK PiAgICAgIGdjID0gc2ctPmdjc1tpXTsKPiAgICAgIC4uLi4gZG8gc3R1ZmYgd2l0aCB0aGlzIGlu c3RhbmNlIC4uLi4KPiB9Cj4gCj4gQ2FsbGJhY2tzIGV0YyBzaG91bGQgd29yayBhcyBiZWZvcmUu Cj4gCj4gVGhlbiB0aGVzZSBwaGFuZGxlcyBuZWVkcyB0byBiZSBwcm9wZXJseSB0cmFuc2xhdGVk LCB3aGljaCBpcyBkb25lIHdpdGggdGhlCj4gc3RydWN0IGdwaW9fY2hpcCAub2ZfeGxhdGUoKSBj YWxsYmFjay4gKElmIHlvdSBsb29rIGluc2lkZSBncGlvbGliLW9mLmMKPiB5b3Ugd2lsbCBzZWUg dGhhdCBjaGlwLT5vZl94bGF0ZSgpIGlzIGNhbGxlZCB0byBtYXAgdGhlIHBoYW5kbGUgY2VsbHMK PiB0byBhIGNlcnRhaW4gR1BJTyBsaW5lKS4KPiAKPiBJbiBtb3N0IGNhc2VzLCBkcml2ZXJzIGRv IG5vdCBhc3NpZ24gdGhlIGNoaXAtPm9mX3hsYXRlIGNhbGxiYWNrCj4gKG9uZSBleGNlcHRpb24g aXMgZ3Bpby1weGEuYykgYW5kIHRoZW4gaXQgaXMgZGVmYXVsdC1hc3NpZ25lZCB0bwo+IG9mX2dw aW9fc2ltcGxlX3hsYXRlKCkgd2hpY2ggeW91IGNhbiBmaW5kIGluIGdwaW9saWItb2YuYyBhcyB3 ZWxsLgo+IAo+IFlvdSBuZWVkIHRvIGNvcHkgdGhpcyBjYWxsYmFjayB0byB5b3VyIGRyaXZlciBh bmQgYXVnbWVudCBpdAo+IHByb3Blcmx5Lgo+IAo+IFRoZSB4bGF0ZSBjYWxsYmFjayBpcyB1c2Vk IHRvIGxvY2F0ZSB0aGUgc3RydWN0IGdwaW9fY2hpcCBhbmQKPiBzdHJ1Y3QgZ3Bpb19kZXZpY2Ug YXMgd2VsbCwgYnkganVzdCBjYWxsaW5nIHRoZSB4bGF0ZSBjYWxsYmFjaywgc28gaWYKPiB5b3Ug Y29kZSB1cCB0aGUgcmlnaHQgeGxhdGUgY2FsbGJhY2ssIGV2ZXJ5dGhpbmcgc2hvdWxkIGp1c3QK PiB3b3JrIGJ5IGl0c2VsZi4KPiAKPiB0aGlzIGlzIGEgZ3Vlc3Mgb24gd2hhdCBpdCB3b3VsZCBs b29rIGxpa2UgKGp1c3QgZHJ5IGNvZGluZywKPiBidXQgaG9wZWZ1bGx5IHRoZSBpZGVhIHdvcmtz ISk6Cj4gCj4gc3RhdGljIGludCBzcGFjZW1pdF9ncGlvX3hsYXRlKHN0cnVjdCBncGlvX2NoaXAg KmdjLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3Qgc3RydWN0IG9mX3Bo YW5kbGVfYXJncyAqZ3Bpb3NwZWMsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1 MzIgKmZsYWdzKQo+IHsKPiAgICAgICAgIHN0cnVjdCBzcGFjZW1pdF9ncGlvICpzZyA9IGdwaW9j aGlwX2dldF9kYXRhKGdjKTsKPiAgICAgICAgIGludCBpOwo+IAo+ICAgICAgICAgaWYgKGdjLT5v Zl9ncGlvX25fY2VsbHMgIT0gMykKPiAgICAgICAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4g Cj4gICAgICAgICBpZiAoZ3Bpb3NwZWMtPmFyZ3NfY291bnQgPCBnYy0+b2ZfZ3Bpb19uX2NlbGxz KQo+ICAgICAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPiAKPiAgICAgICAgIC8qIFdlIHN1 cHBvcnQgbWF4aW11bSAzIGdwaW9fY2hpcCBpbnN0YW5jZXMgKi8KPiAgICAgICAgIGkgPSBncGlv c3BlYy0+YXJnc1swXTsKPiAgICAgICAgIGlmIChpID49IDMpCj4gICAgICAgICAgICAgICAgIHJl dHVybiAtRUlOVkFMOwo+IAo+ICAgICAgICAgLyogT0sgaXMgdGhpcyB0aGUgcmlnaHQgZ3Bpb19j aGlwIG91dCBvZiB0aGUgdGhyZWUgPyAqLwo+ICAgICAgICAgaWYgKGdjICE9IHNnLT5nY3NbaV0p Cj4gICAgICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+IAo+ICAgICAgICAgLyogQXJlIHdl IGluIHJhbmdlIGZvciB0aGlzIEdQSU8gY2hpcCAqLwo+ICAgICAgICAgaWYgKGdwaW9zcGVjLT5h cmdzWzFdID49IGdjLT5uZ3BpbykKPiAgICAgICAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4g Cj4gICAgICAgICBpZiAoZmxhZ3MpCj4gICAgICAgICAgICAgICAgICpmbGFncyA9IGdwaW9zcGVj LT5hcmdzWzJdOwo+IAo+ICAgICAgICAgLyogUmV0dXJuIHRoZSBodyBpbmRleCAqLwo+ICAgICAg ICAgcmV0dXJuIGdwaW9zcGVjLT5hcmdzWzFdOwo+IH0KPiAKdGhhbmtzIGZvciB0aGlzIHZlcnkg ZGV0YWlsIHByb3RvdHlwZSEgaXQgd29ya3MgbW9zdGx5LCB3aXRoIG9uZSBwcm9ibGVtOgoKaG93 IHRvIG1hcCBncGlvIGNvcnJlY3RseSB0byB0aGUgcGluIGZyb20gcGluY3RybCBzdWJzeXN0ZW0/ Cgpmb3IgZXhhbXBsZSwgSSBzcGVjaWZ5IGdwaW8tcmFuZ2VzIGluIGR0cywgdGhlbiAKICAgICAg ICAgICAgICAgIGdwaW8wOiBncGlvQGQ0MDE5MDAwIHsKICAgICAgICAgICAgICAgICAgICAgICAg Y29tcGF0aWJsZSA9ICJzcGFjZW1pdCxrMS1ncGlvIjsKICAgICAgICAgICAgICAgICAgICAgICAg cmVnID0gPDB4MCAweGQ0MDE5MDAwIDB4MCAweDEwMD47CgkJCS4uLgogICAgICAgICAgICAgICAg ICAgICAgICBncGlvLXJhbmdlcyA9IDwmcGluY3RybCAwIDAgOTY+OwogICAgICAgICAgICAgICAg fTsKCgkJZm9vLWdwaW9zID0gPCZncGlvMCAyIDI4IEdQSU9fQUNUSVZFX0xPVz47CgpJdCBzaG91 bGQgZ2V0IEdQSU9fOTIgKCA5MiA9IDIgKiAzMiArIDI4KSwgYnV0IHR1cm5zIG91dCBHUElPXzI4 CgpQcm9iYWJseSB0aGVyZSBpcyBzb21ldGhpbmcgSSBtaXNzZWQuLi4KPiAuLi4KPiBnYy0+b2Zf Z3Bpb19uX2NlbGxzID0gMzsKPiBnYy0+b2ZfeGxhdGUgPSBzcGFjZW1pdF9ncGlvX3hsYXRlOwo+ IAo+IElmIGl0IHdvcmtzIGFzIEkgaG9wZSwgdGhpcyB3aWxsIG1ha2UgdGhlIGNvZGUgaW4gZ3Bp b2xpYi1vZi5jIGluCj4gb2ZfZmluZF9ncGlvX2RldmljZV9ieV94bGF0ZSgpIGNhbGxpbmcgZ3Bp b19kZXZpY2VfZmluZCgpCj4gKHdoaWNoIHdpbGwgaXRlcmF0ZSBvdmVyIGFsbCByZWdpc3RlcmVk IGdwaW9fY2hpcHMgYW5kIHRoZW4KPiBvZl9ncGlvY2hpcF9tYXRjaF9ub2RlX2FuZF94bGF0ZSgp IHdpbGwgY2FsbCB0aGlzIGN1c3RvbSBmdW5jdGlvbgo+IHRvIHNlZSBpZiBpdCdzIHRoZSByaWdo dCBvbmUgYW5kIHJldHVybiA+IDAgd2hlbiB3ZSBoYXZlIHRoZSByaWdodAo+IGNoaXAuCj4gCj4g VGhpcyBzaG91bGQgd29yayBmb3IgZ3Bpb3MgKm9ubHkqLiBXaGVuIHdlIHRoZW4gY29tZSB0byBp cnFzLAo+IHRoZXNlIGFzc3VtZSAoc2VlIGdwaW9saWIuYykgdGhhdCB3ZSBhcmUgdXNpbmcKPiBp cnFfZG9tYWluX3hsYXRlX3R3b2NlbGwoKSB3aGVuIHVzaW5nIEdQSU9MSUJfSVJRQ0hJUCwgc28K PiB5b3UgZWl0aGVyIG5lZWQgdG8gcm9sbCB5b3VyIG93biBpcnFjaGlwIGNvZGUgb3Igd2Ugc2hv dWxkIGZpeApTb3VuZHMgSSBzaG91bGQgaW1wbGVtZW50IHNvbWV0aGluZyBsaWtlIGlycV9kb21h aW5feGxhdGVfdGhyZWVjZWxsKCk/Cgo+IHRoZSBjb3JlIChJIGNhbiBoZWxwIHdpdGggdGhpcyBp ZiB0aGUgYWJvdmUgd29ya3MpLgo+IAo+IFNldmVyYWwgZ3BpbyBjaGlwcyB1c2UgdGhlaXIgb3du IGRvbWFpbiB0cmFuc2xhdGlvbiBvdXRzaWRlCj4gb2YgdGhlIGdwaW9saWIgc28geW91IGNhbiB1 c2UgdGhpcyBhcyBhbiBpbnRlcm1lZGlhdGUgc3RlcDoKPiBnaXQgZ3JlcCBpcnFfZG9tYWluX29w cyBkcml2ZXJzL2dwaW8vCi4uCj4gLi4uIGJ1dCBpZiB5b3UgZ2V0IGhlcmUsIGxldCdzIHBhdGNo IHRoZSBjb3JlIHRvIGRlYWwgd2l0aCBjdXN0b20KPiBpcnFkb21haW4geGxhdGUgZnVuY3Rpb25z IGluIHRoZSBzYW1lIG1hbm5lciBhcyBhYm92ZS4KPiAKSSBsaWtlIHRoaXMgZGlyZWN0aW9uLCBi dXQgaG93IHdlIHNob3VsZCBwcm9jZWVkPwoKPiBJIGhvcGUgdGhpcyBpc24ndCB0ZXJyaWJseSB1 bmNsZWFyIG9yIGNvbXBsaWNhdGVkPwo+IE90aGVyd2lzZSB0ZWxsIG1lIGFuZCBJIHdpbGwgdHJ5 IHRvIC4uLiBleHBsYWluIG1vcmUgb3IgZ2l2ZQo+IHVwIGFuZCBzYXkgeW91IGNhbiB1c2UgYSBz aW5nbGUgOTYtcGluIGdwaW9fY2hpcC4KPiAKTGV0J3MgdHJ5IGZpcnN0LCBzb3VuZHMgaXQncyBh IGZlYXNpYmxlIHdheS4KCk1hbnkgdGhhbmtzIQoKPiBZb3VycywKPiBMaW51cyBXYWxsZWlqCgot LSAKWWl4dW4gTGFuIChkbGFuKQpHZW50b28gTGludXggRGV2ZWxvcGVyCkdQRyBLZXkgSUQgQUFC RUZENTUKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK