From: aman1cifs@gmail.com
To: linux-cifs@vger.kernel.org, sfrench@samba.org, pc@manguebit.com,
sprasad@microsoft.com, tom@talpey.com, ronniesahlberg@gmail.com,
bharathsm@microsoft.com
Cc: Aman <aman1@microsoft.com>
Subject: [PATCH 2/2] CIFS: adds min_offload and other params to cifs_debug
Date: Fri, 14 Feb 2025 12:43:06 +0000 [thread overview]
Message-ID: <20250214124306.498808-2-aman1cifs@gmail.com> (raw)
In-Reply-To: <20250214124306.498808-1-aman1cifs@gmail.com>
From: Aman <aman1@microsoft.com>
This change adds more parameters for debugging into the status of all
channels. It adds the following TCP server parameters to cifs_debug.c
- min_offload
- compression.requested
- dfs_conn
- ignore_signature
- leaf_fullpath
- retrans
- noblockcnt
- noblocksnd
- sign
- max_credits
This is a logical follow up to a previous patch titled:
"[PATCH] CIFS: Propagate min offload along with other parameters from
primary to secondary channels",
however this has been tested and applies independently.
Signed-off-by: Aman <aman1@microsoft.com>
---
fs/smb/client/cifs_debug.c | 47 +++++++++++++++++++++++++++++++++++---
1 file changed, 44 insertions(+), 3 deletions(-)
diff --git a/fs/smb/client/cifs_debug.c b/fs/smb/client/cifs_debug.c
index e03c890de..64a565c46 100644
--- a/fs/smb/client/cifs_debug.c
+++ b/fs/smb/client/cifs_debug.c
@@ -147,8 +147,16 @@ cifs_dump_channel(struct seq_file *m, int i, struct cifs_chan *chan)
"\n\t\tNumber of credits: %d,%d,%d Dialect 0x%x"
"\n\t\tTCP status: %d Instance: %d"
"\n\t\tLocal Users To Server: %d SecMode: 0x%x Req On Wire: %d"
- "\n\t\tIn Send: %d In MaxReq Wait: %d",
- i+1, server->conn_id,
+ "\n\t\tIn Send: %d In MaxReq Wait: %d"
+ "\n\t\tCompression Requested: %s"
+ "\n\t\tdfs_conn: %s"
+ "\n\t\tIgnore Signature: %s"
+ "\n\t\tretrans: %d"
+ "\n\t\tUse non-blocking connect: %s"
+ "\n\t\tUse non-blocking sendmsg: %s"
+ "\n\t\tSigning Enabled: %s"
+ "\n\t\tMin Offload: %d Max Credits: %d",
+ i, server->conn_id,
server->credits,
server->echo_credits,
server->oplock_credits,
@@ -159,7 +167,22 @@ cifs_dump_channel(struct seq_file *m, int i, struct cifs_chan *chan)
server->sec_mode,
in_flight(server),
atomic_read(&server->in_send),
- atomic_read(&server->num_waiters));
+ atomic_read(&server->num_waiters),
+ str_yes_no(server->compression.requested),
+ str_yes_no(server->dfs_conn),
+ str_yes_no(server->ignore_signature),
+ server->retrans,
+ str_yes_no(server->noblockcnt),
+ str_yes_no(server->noblocksnd),
+ str_yes_no(server->sign),
+ server->min_offload,
+ server->max_credits);
+
+ if (server->leaf_fullpath) {
+ seq_printf(m, "\n\t\tDFS leaf full path: %s",
+ server->leaf_fullpath);
+ }
+
#ifdef CONFIG_NET_NS
if (server->net)
seq_printf(m, " Net namespace: %u ", server->net->ns.inum);
@@ -487,6 +510,24 @@ static int cifs_debug_data_proc_show(struct seq_file *m, void *v)
else
seq_puts(m, "disabled (not supported by this server)");
+ seq_printf(m, "\nCompression Requested: %s"
+ "\ndfs_conn: %s"
+ "\nIgnore Signature: %s"
+ "\nretrans: %d"
+ "\nUse non-blocking connect: %s"
+ "\nUse non-blocking sendmsg: %s"
+ "\nSigning Enabled: %s"
+ "\nMin Offload: %d Max Credits: %d",
+ str_yes_no(server->compression.requested),
+ str_yes_no(server->dfs_conn),
+ str_yes_no(server->ignore_signature),
+ server->retrans,
+ str_yes_no(server->noblockcnt),
+ str_yes_no(server->noblocksnd),
+ str_yes_no(server->sign),
+ server->min_offload,
+ server->max_credits);
+
seq_printf(m, "\n\n\tSessions: ");
i = 0;
list_for_each_entry(ses, &server->smb_ses_list, smb_ses_list) {
--
2.43.0
next prev parent reply other threads:[~2025-02-14 12:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 12:43 [PATCH 1/2] CIFS: Propagate min offload along with other parameters from primary to secondary channels aman1cifs
2025-02-14 12:43 ` aman1cifs [this message]
2025-02-14 17:55 ` [PATCH 2/2] CIFS: adds min_offload and other params to cifs_debug Steve French
2025-02-27 16:33 ` [PATCH 1/2] CIFS: Propagate min offload along with other parameters from primary to secondary channels Paulo Alcantara
2025-03-06 17:46 ` aman1cifs
2025-03-11 3:25 ` Steve French
2025-03-11 11:21 ` aman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250214124306.498808-2-aman1cifs@gmail.com \
--to=aman1cifs@gmail.com \
--cc=aman1@microsoft.com \
--cc=bharathsm@microsoft.com \
--cc=linux-cifs@vger.kernel.org \
--cc=pc@manguebit.com \
--cc=ronniesahlberg@gmail.com \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.