From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 149F623A992; Fri, 14 Feb 2025 13:08:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=140.211.166.183 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739538539; cv=none; b=oziEBgBV1cGyxHZRky4cfj31Yxce7mP6+TK7mMlmGfkarw8t+HppZtKcgVirw2hTXhgi1vDzZC/p9AzTUi7u1f/mPSf5sWzPE/2CY2QBFo/nIEXWRKJ78lpqCRS/vbBRxopCIy2bAcj9LeO+qRf9gbKFFbX40Ac2ra/uKCLmuQQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739538539; c=relaxed/simple; bh=DdXgOfaajmPxNUJs0g3YB5p0a0TafhxkMlOBYUWYlL4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kTxumxmXc91KjsmkNWJjko28ERRMT/UjFweWCCRudnzCJ7Wx8H0eJ49GR3WWlceOJQZFB8A3EdO04qIgIxWnNnryAwkiZXafGG0rwYoK5LSnDHPBudp72tHFzWtrcSRqxqMzJh3ybVEWCYx/55gMWqtKrhhZkPrC4c65dRY5Um0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org; spf=pass smtp.mailfrom=gentoo.org; arc=none smtp.client-ip=140.211.166.183 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gentoo.org Received: from localhost (unknown [180.172.76.141]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dlan) by smtp.gentoo.org (Postfix) with ESMTPSA id E83C23433F1; Fri, 14 Feb 2025 13:08:56 +0000 (UTC) Date: Fri, 14 Feb 2025 13:08:49 +0000 From: Yixun Lan To: Linus Walleij Cc: Rob Herring , Olof Johansson , Bartosz Golaszewski , Krzysztof Kozlowski , Conor Dooley , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Yangyu Chen , Jisheng Zhang , Jesse Taube , Inochi Amaoto , Icenowy Zheng , Meng Zhang , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v4 1/4] dt-bindings: gpio: spacemit: add support for K1 SoC Message-ID: <20250214130849-GYA21864@gentoo> References: <20250123113042-GYA38135@gentoo> <20250127181726.GA538260-robh@kernel.org> <20250128031712-GYB47737@gentoo> <20250206133156-GYA5687@gentoo> <20250214115410-GYA21743@gentoo> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250214115410-GYA21743@gentoo> Hi Linus: On 11:54 Fri 14 Feb , Yixun Lan wrote: > Hi Linus: > > On 14:07 Thu 13 Feb , Linus Walleij wrote: > > On Thu, Feb 6, 2025 at 2:32 PM Yixun Lan wrote: > > > > > > > foo-gpios <&gpio 2 7 GPIO_ACTIVE_LOW>; > > > > > > if we model the dts as above, then "&gpio" will register itself as one sole "struct gpio_chip", > > > which mean one gpio chip combine three banks.. > > > > Not really: the fact that there is just one gpio node in the device > > tree does not > > mean that it needs to correspond to one single gpio_chip instance inside the > > Linux kernel. > > > > It's just what the current existing bindings and the code in the GPIO subsystem > > assumes. It does not have to assume that: we can change it. > > > > I'm sorry if this is not entirely intuitive :( > > > > One node can very well spawn three gpio_chip instances, but it requires > > some core changes. But I think it's the most elegant. > > > > > if taking "one gpio chip support multi banks" direction, then it will be reverted back as patch V1, > > > then, even the three gpio-cells model is unnecessary needed, as we can map gpio number > > > to the array in the underlying gpio driver > > > > > > the v4 patch is very similar to drivers/gpio/gpio-dwapb.c > > > > > > If had to choose the direction between v1 and v4, I personally would favor the latter, > > > as from hw perspective, each gpio bank is quite indepedent - has its own io/irq registers, > > > merely has interleaved io memory space, one shared IRQ line.. also the patch v4 leverage > > > lots underlying generic gpio APIs, result in much simplified/clean code base.. > > > > So what I would suggest is a combination of the two. > > > > One gpio node in the device tree, like the DT maintainers want it. > > > > Three struct gpio_chip instances inside the driver, all three spawn from > > that single gpio device, and from that single platform_device. > > > > What we are suggesting is a three-cell phandle in the device tree: > > > > foo-gpios = <&gpio 0 7 GPIO_ACTIVE_HIGH>; > > bar-gpios = <&gpio 2 31 GPIO_ACTIVE_HIGH>; > > > > Notice the new first cell which is 0 or 2. > > > > The first one is what was previously called gpio 7. > > The second one is what was 2*32+31 = gpio 95. > > > > So internally in the driver it is easy to use the first cell (0 or 2) to map to > > the right struct gpio_chip if you have it in your driver something like this: > > > > struct spacemit_gpio { > > struct gpio_chip gcs[3]; > > ... > > }; > > > > struct spacemit_gpio *sg; > > struct gpio_chip *gc; > > int ret; > > > > for (i = 0; i++; i < 3) { > > ret = devm_gpiochip_add_data(dev, &sg->gcs[i], sg); > > if (ret) > > return ret; > > gc = sg->gcs[i]; > > .... do stuff with this instance .... > > } > > > > Callbacks etc should work as before. > > > > Then these phandles needs to be properly translated, which is done with the > > struct gpio_chip .of_xlate() callback. (If you look inside gpiolib-of.c > > you will see that chip->of_xlate() is called to map the phandle cells > > to a certain GPIO line). > > > > In most cases, drivers do not assign the chip->of_xlate callback > > (one exception is gpio-pxa.c) and then it is default-assigned to > > of_gpio_simple_xlate() which you can find in gpiolib-of.c as well. > > > > You need to copy this callback to your driver and augment it > > properly. > > > > The xlate callback is used to locate the struct gpio_chip and > > struct gpio_device as well, by just calling the xlate callback, so if > > you code up the right xlate callback, everything should just > > work by itself. > > > > this is a guess on what it would look like (just dry coding, > > but hopefully the idea works!): > > > > static int spacemit_gpio_xlate(struct gpio_chip *gc, > > const struct of_phandle_args *gpiospec, > > u32 *flags) > > { > > struct spacemit_gpio *sg = gpiochip_get_data(gc); > > int i; > > > > if (gc->of_gpio_n_cells != 3) > > return -EINVAL; > > > > if (gpiospec->args_count < gc->of_gpio_n_cells) > > return -EINVAL; > > > > /* We support maximum 3 gpio_chip instances */ > > i = gpiospec->args[0]; > > if (i >= 3) > > return -EINVAL; > > > > /* OK is this the right gpio_chip out of the three ? */ > > if (gc != sg->gcs[i]) > > return -EINVAL; > > > > /* Are we in range for this GPIO chip */ > > if (gpiospec->args[1] >= gc->ngpio) > > return -EINVAL; > > > > if (flags) > > *flags = gpiospec->args[2]; > > > > /* Return the hw index */ > > return gpiospec->args[1]; > > } > > > thanks for this very detail prototype! it works mostly, with one problem: > > how to map gpio correctly to the pin from pinctrl subsystem? > > for example, I specify gpio-ranges in dts, then > gpio0: gpio@d4019000 { > compatible = "spacemit,k1-gpio"; > reg = <0x0 0xd4019000 0x0 0x100>; > ... > gpio-ranges = <&pinctrl 0 0 96>; > }; > > foo-gpios = <&gpio0 2 28 GPIO_ACTIVE_LOW>; > > It should get GPIO_92 ( 92 = 2 * 32 + 28), but turns out GPIO_28 > > Probably there is something I missed... to make the gpio part work, we need additional custom gpio-ranges parser, which should similar to of_gpiochip_add_pin_range() in gpiolib-of.c (at least gpio core need to adjust to call custom this function) -- Yixun Lan (dlan) Gentoo Linux Developer GPG Key ID AABEFD55 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7F18C02198 for ; Fri, 14 Feb 2025 13:24:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=537xLuTOM9kYdsnauEEODjil7/G0iPBJ9X82+9dI7Dw=; b=pODZFPnPM2g5xU yBP8rgKmC21w7yxM9H0GO7fDUk0Ze01s6TRnDLqThwLuxva6HrR6HvHkozktO9wsoNzlHJdLnTBtH XAxXwPpMm4xbHG/D/HYBZhdZMcRp3AHDJJU8CGrCrTjD48eji79l2oQejjelG21+EVelxP0eMFERB Fc/6b7Cwz7RpTxAODxCpN9Sxddj7Q1maJvP08QdXrbncekG/evh+GjtE34GSof/edMQ21d+Q6zjUh NGoWoSK5wCEi+KKuy6ja/OsFVIdMhOO6FxVzQOqQQJs0RjdTG23TN4425PSOTk/uVLId8GKKmgMJa AvxH8GVCX2uJJH8vmM4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tivfh-0000000EzVb-1k2w; Fri, 14 Feb 2025 13:23:57 +0000 Received: from woodpecker.gentoo.org ([140.211.166.183] helo=smtp.gentoo.org) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tivRC-0000000EwRY-3CuV for linux-riscv@lists.infradead.org; Fri, 14 Feb 2025 13:08:59 +0000 Received: from localhost (unknown [180.172.76.141]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dlan) by smtp.gentoo.org (Postfix) with ESMTPSA id E83C23433F1; Fri, 14 Feb 2025 13:08:56 +0000 (UTC) Date: Fri, 14 Feb 2025 13:08:49 +0000 From: Yixun Lan To: Linus Walleij Subject: Re: [PATCH v4 1/4] dt-bindings: gpio: spacemit: add support for K1 SoC Message-ID: <20250214130849-GYA21864@gentoo> References: <20250123113042-GYA38135@gentoo> <20250127181726.GA538260-robh@kernel.org> <20250128031712-GYB47737@gentoo> <20250206133156-GYA5687@gentoo> <20250214115410-GYA21743@gentoo> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20250214115410-GYA21743@gentoo> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250214_050858_827606_5B080EBD X-CRM114-Status: GOOD ( 49.01 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Conor Dooley , Meng Zhang , linux-gpio@vger.kernel.org, Bartosz Golaszewski , linux-kernel@vger.kernel.org, Conor Dooley , Yangyu Chen , devicetree@vger.kernel.org, Palmer Dabbelt , Jesse Taube , Jisheng Zhang , Paul Walmsley , Olof Johansson , Inochi Amaoto , Krzysztof Kozlowski , linux-riscv@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org SGkgTGludXM6CgpPbiAxMTo1NCBGcmkgMTQgRmViICAgICAsIFlpeHVuIExhbiB3cm90ZToKPiBI aSBMaW51czoKPiAKPiBPbiAxNDowNyBUaHUgMTMgRmViICAgICAsIExpbnVzIFdhbGxlaWogd3Jv dGU6Cj4gPiBPbiBUaHUsIEZlYiA2LCAyMDI1IGF0IDI6MzLigK9QTSBZaXh1biBMYW4gPGRsYW5A Z2VudG9vLm9yZz4gd3JvdGU6Cj4gPiAKPiA+ID4gPiA+IGZvby1ncGlvcyA8JmdwaW8gMiA3IEdQ SU9fQUNUSVZFX0xPVz47Cj4gPiA+Cj4gPiA+IGlmIHdlIG1vZGVsIHRoZSBkdHMgYXMgYWJvdmUs IHRoZW4gIiZncGlvIiB3aWxsIHJlZ2lzdGVyIGl0c2VsZiBhcyBvbmUgc29sZSAic3RydWN0IGdw aW9fY2hpcCIsCj4gPiA+ICB3aGljaCBtZWFuIG9uZSBncGlvIGNoaXAgY29tYmluZSB0aHJlZSBi YW5rcy4uCj4gPiAKPiA+IE5vdCByZWFsbHk6IHRoZSBmYWN0IHRoYXQgdGhlcmUgaXMganVzdCBv bmUgZ3BpbyBub2RlIGluIHRoZSBkZXZpY2UKPiA+IHRyZWUgZG9lcyBub3QKPiA+IG1lYW4gdGhh dCBpdCBuZWVkcyB0byBjb3JyZXNwb25kIHRvIG9uZSBzaW5nbGUgZ3Bpb19jaGlwIGluc3RhbmNl IGluc2lkZSB0aGUKPiA+IExpbnV4IGtlcm5lbC4KPiA+IAo+ID4gSXQncyBqdXN0IHdoYXQgdGhl IGN1cnJlbnQgZXhpc3RpbmcgYmluZGluZ3MgYW5kIHRoZSBjb2RlIGluIHRoZSBHUElPIHN1YnN5 c3RlbQo+ID4gYXNzdW1lcy4gSXQgZG9lcyBub3QgaGF2ZSB0byBhc3N1bWUgdGhhdDogd2UgY2Fu IGNoYW5nZSBpdC4KPiA+IAo+ID4gSSdtIHNvcnJ5IGlmIHRoaXMgaXMgbm90IGVudGlyZWx5IGlu dHVpdGl2ZSA6KAo+ID4gCj4gPiBPbmUgbm9kZSBjYW4gdmVyeSB3ZWxsIHNwYXduIHRocmVlIGdw aW9fY2hpcCBpbnN0YW5jZXMsIGJ1dCBpdCByZXF1aXJlcwo+ID4gc29tZSBjb3JlIGNoYW5nZXMu IEJ1dCBJIHRoaW5rIGl0J3MgdGhlIG1vc3QgZWxlZ2FudC4KPiA+IAo+ID4gPiBpZiB0YWtpbmcg Im9uZSBncGlvIGNoaXAgc3VwcG9ydCBtdWx0aSBiYW5rcyIgZGlyZWN0aW9uLCB0aGVuIGl0IHdp bGwgYmUgcmV2ZXJ0ZWQgYmFjayBhcyBwYXRjaCBWMSwKPiA+ID4gdGhlbiwgZXZlbiB0aGUgdGhy ZWUgZ3Bpby1jZWxscyBtb2RlbCBpcyB1bm5lY2Vzc2FyeSBuZWVkZWQsIGFzIHdlIGNhbiBtYXAg Z3BpbyBudW1iZXIKPiA+ID4gIHRvIHRoZSA8YmFuaywgb2Zmc2V0PiBhcnJheSBpbiB0aGUgdW5k ZXJseWluZyBncGlvIGRyaXZlcgo+ID4gPgo+ID4gPiB0aGUgdjQgcGF0Y2ggaXMgdmVyeSBzaW1p bGFyIHRvIGRyaXZlcnMvZ3Bpby9ncGlvLWR3YXBiLmMKPiA+ID4KPiA+ID4gSWYgaGFkIHRvIGNo b29zZSB0aGUgZGlyZWN0aW9uIGJldHdlZW4gdjEgYW5kIHY0LCBJIHBlcnNvbmFsbHkgd291bGQg ZmF2b3IgdGhlIGxhdHRlciwKPiA+ID4gIGFzIGZyb20gaHcgcGVyc3BlY3RpdmUsIGVhY2ggZ3Bp byBiYW5rIGlzIHF1aXRlIGluZGVwZWRlbnQgLSBoYXMgaXRzIG93biBpby9pcnEgcmVnaXN0ZXJz LAo+ID4gPiAgbWVyZWx5IGhhcyBpbnRlcmxlYXZlZCBpbyBtZW1vcnkgc3BhY2UsIG9uZSBzaGFy ZWQgSVJRIGxpbmUuLiBhbHNvIHRoZSBwYXRjaCB2NCBsZXZlcmFnZQo+ID4gPiAgbG90cyB1bmRl cmx5aW5nIGdlbmVyaWMgZ3BpbyBBUElzLCByZXN1bHQgaW4gbXVjaCBzaW1wbGlmaWVkL2NsZWFu IGNvZGUgYmFzZS4uCj4gPiAKPiA+IFNvIHdoYXQgSSB3b3VsZCBzdWdnZXN0IGlzIGEgY29tYmlu YXRpb24gb2YgdGhlIHR3by4KPiA+IAo+ID4gT25lIGdwaW8gbm9kZSBpbiB0aGUgZGV2aWNlIHRy ZWUsIGxpa2UgdGhlIERUIG1haW50YWluZXJzIHdhbnQgaXQuCj4gPiAKPiA+IFRocmVlIHN0cnVj dCBncGlvX2NoaXAgaW5zdGFuY2VzIGluc2lkZSB0aGUgZHJpdmVyLCBhbGwgdGhyZWUgc3Bhd24g ZnJvbQo+ID4gdGhhdCBzaW5nbGUgZ3BpbyBkZXZpY2UsIGFuZCBmcm9tIHRoYXQgc2luZ2xlIHBs YXRmb3JtX2RldmljZS4KPiA+IAo+ID4gV2hhdCB3ZSBhcmUgc3VnZ2VzdGluZyBpcyBhIHRocmVl LWNlbGwgcGhhbmRsZSBpbiB0aGUgZGV2aWNlIHRyZWU6Cj4gPiAKPiA+IGZvby1ncGlvcyA9IDwm Z3BpbyAwIDcgR1BJT19BQ1RJVkVfSElHSD47Cj4gPiBiYXItZ3Bpb3MgPSA8JmdwaW8gMiAzMSBH UElPX0FDVElWRV9ISUdIPjsKPiA+IAo+ID4gTm90aWNlIHRoZSBuZXcgZmlyc3QgY2VsbCB3aGlj aCBpcyAwIG9yIDIuCj4gPiAKPiA+IFRoZSBmaXJzdCBvbmUgaXMgd2hhdCB3YXMgcHJldmlvdXNs eSBjYWxsZWQgZ3BpbyA3Lgo+ID4gVGhlIHNlY29uZCBvbmUgaXMgd2hhdCB3YXMgMiozMiszMSA9 IGdwaW8gOTUuCj4gPiAKPiA+IFNvIGludGVybmFsbHkgaW4gdGhlIGRyaXZlciBpdCBpcyBlYXN5 IHRvIHVzZSB0aGUgZmlyc3QgY2VsbCAoMCBvciAyKSB0byBtYXAgdG8KPiA+IHRoZSByaWdodCBz dHJ1Y3QgZ3Bpb19jaGlwIGlmIHlvdSBoYXZlIGl0IGluIHlvdXIgZHJpdmVyIHNvbWV0aGluZyBs aWtlIHRoaXM6Cj4gPiAKPiA+IHN0cnVjdCBzcGFjZW1pdF9ncGlvIHsKPiA+ICAgICBzdHJ1Y3Qg Z3Bpb19jaGlwIGdjc1szXTsKPiA+IC4uLgo+ID4gfTsKPiA+IAo+ID4gc3RydWN0IHNwYWNlbWl0 X2dwaW8gKnNnOwo+ID4gc3RydWN0IGdwaW9fY2hpcCAqZ2M7Cj4gPiBpbnQgcmV0Owo+ID4gCj4g PiBmb3IgKGkgPSAwOyBpKys7IGkgPCAzKSB7Cj4gPiAgICAgIHJldCA9IGRldm1fZ3Bpb2NoaXBf YWRkX2RhdGEoZGV2LCAmc2ctPmdjc1tpXSwgc2cpOwo+ID4gICAgICBpZiAocmV0KQo+ID4gICAg ICAgICByZXR1cm4gcmV0Owo+ID4gICAgICBnYyA9IHNnLT5nY3NbaV07Cj4gPiAgICAgIC4uLi4g ZG8gc3R1ZmYgd2l0aCB0aGlzIGluc3RhbmNlIC4uLi4KPiA+IH0KPiA+IAo+ID4gQ2FsbGJhY2tz IGV0YyBzaG91bGQgd29yayBhcyBiZWZvcmUuCj4gPiAKPiA+IFRoZW4gdGhlc2UgcGhhbmRsZXMg bmVlZHMgdG8gYmUgcHJvcGVybHkgdHJhbnNsYXRlZCwgd2hpY2ggaXMgZG9uZSB3aXRoIHRoZQo+ ID4gc3RydWN0IGdwaW9fY2hpcCAub2ZfeGxhdGUoKSBjYWxsYmFjay4gKElmIHlvdSBsb29rIGlu c2lkZSBncGlvbGliLW9mLmMKPiA+IHlvdSB3aWxsIHNlZSB0aGF0IGNoaXAtPm9mX3hsYXRlKCkg aXMgY2FsbGVkIHRvIG1hcCB0aGUgcGhhbmRsZSBjZWxscwo+ID4gdG8gYSBjZXJ0YWluIEdQSU8g bGluZSkuCj4gPiAKPiA+IEluIG1vc3QgY2FzZXMsIGRyaXZlcnMgZG8gbm90IGFzc2lnbiB0aGUg Y2hpcC0+b2ZfeGxhdGUgY2FsbGJhY2sKPiA+IChvbmUgZXhjZXB0aW9uIGlzIGdwaW8tcHhhLmMp IGFuZCB0aGVuIGl0IGlzIGRlZmF1bHQtYXNzaWduZWQgdG8KPiA+IG9mX2dwaW9fc2ltcGxlX3hs YXRlKCkgd2hpY2ggeW91IGNhbiBmaW5kIGluIGdwaW9saWItb2YuYyBhcyB3ZWxsLgo+ID4gCj4g PiBZb3UgbmVlZCB0byBjb3B5IHRoaXMgY2FsbGJhY2sgdG8geW91ciBkcml2ZXIgYW5kIGF1Z21l bnQgaXQKPiA+IHByb3Blcmx5Lgo+ID4gCj4gPiBUaGUgeGxhdGUgY2FsbGJhY2sgaXMgdXNlZCB0 byBsb2NhdGUgdGhlIHN0cnVjdCBncGlvX2NoaXAgYW5kCj4gPiBzdHJ1Y3QgZ3Bpb19kZXZpY2Ug YXMgd2VsbCwgYnkganVzdCBjYWxsaW5nIHRoZSB4bGF0ZSBjYWxsYmFjaywgc28gaWYKPiA+IHlv dSBjb2RlIHVwIHRoZSByaWdodCB4bGF0ZSBjYWxsYmFjaywgZXZlcnl0aGluZyBzaG91bGQganVz dAo+ID4gd29yayBieSBpdHNlbGYuCj4gPiAKPiA+IHRoaXMgaXMgYSBndWVzcyBvbiB3aGF0IGl0 IHdvdWxkIGxvb2sgbGlrZSAoanVzdCBkcnkgY29kaW5nLAo+ID4gYnV0IGhvcGVmdWxseSB0aGUg aWRlYSB3b3JrcyEpOgo+ID4gCj4gPiBzdGF0aWMgaW50IHNwYWNlbWl0X2dwaW9feGxhdGUoc3Ry dWN0IGdwaW9fY2hpcCAqZ2MsCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNv bnN0IHN0cnVjdCBvZl9waGFuZGxlX2FyZ3MgKmdwaW9zcGVjLAo+ID4gICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB1MzIgKmZsYWdzKQo+ID4gewo+ID4gICAgICAgICBzdHJ1Y3Qgc3Bh Y2VtaXRfZ3BpbyAqc2cgPSBncGlvY2hpcF9nZXRfZGF0YShnYyk7Cj4gPiAgICAgICAgIGludCBp Owo+ID4gCj4gPiAgICAgICAgIGlmIChnYy0+b2ZfZ3Bpb19uX2NlbGxzICE9IDMpCj4gPiAgICAg ICAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4gPiAKPiA+ICAgICAgICAgaWYgKGdwaW9zcGVj LT5hcmdzX2NvdW50IDwgZ2MtPm9mX2dwaW9fbl9jZWxscykKPiA+ICAgICAgICAgICAgICAgICBy ZXR1cm4gLUVJTlZBTDsKPiA+IAo+ID4gICAgICAgICAvKiBXZSBzdXBwb3J0IG1heGltdW0gMyBn cGlvX2NoaXAgaW5zdGFuY2VzICovCj4gPiAgICAgICAgIGkgPSBncGlvc3BlYy0+YXJnc1swXTsK PiA+ICAgICAgICAgaWYgKGkgPj0gMykKPiA+ICAgICAgICAgICAgICAgICByZXR1cm4gLUVJTlZB TDsKPiA+IAo+ID4gICAgICAgICAvKiBPSyBpcyB0aGlzIHRoZSByaWdodCBncGlvX2NoaXAgb3V0 IG9mIHRoZSB0aHJlZSA/ICovCj4gPiAgICAgICAgIGlmIChnYyAhPSBzZy0+Z2NzW2ldKQo+ID4g ICAgICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ID4gCj4gPiAgICAgICAgIC8qIEFyZSB3 ZSBpbiByYW5nZSBmb3IgdGhpcyBHUElPIGNoaXAgKi8KPiA+ICAgICAgICAgaWYgKGdwaW9zcGVj LT5hcmdzWzFdID49IGdjLT5uZ3BpbykKPiA+ICAgICAgICAgICAgICAgICByZXR1cm4gLUVJTlZB TDsKPiA+IAo+ID4gICAgICAgICBpZiAoZmxhZ3MpCj4gPiAgICAgICAgICAgICAgICAgKmZsYWdz ID0gZ3Bpb3NwZWMtPmFyZ3NbMl07Cj4gPiAKPiA+ICAgICAgICAgLyogUmV0dXJuIHRoZSBodyBp bmRleCAqLwo+ID4gICAgICAgICByZXR1cm4gZ3Bpb3NwZWMtPmFyZ3NbMV07Cj4gPiB9Cj4gPiAK PiB0aGFua3MgZm9yIHRoaXMgdmVyeSBkZXRhaWwgcHJvdG90eXBlISBpdCB3b3JrcyBtb3N0bHks IHdpdGggb25lIHByb2JsZW06Cj4gCj4gaG93IHRvIG1hcCBncGlvIGNvcnJlY3RseSB0byB0aGUg cGluIGZyb20gcGluY3RybCBzdWJzeXN0ZW0/Cj4gCj4gZm9yIGV4YW1wbGUsIEkgc3BlY2lmeSBn cGlvLXJhbmdlcyBpbiBkdHMsIHRoZW4gCj4gICAgICAgICAgICAgICAgIGdwaW8wOiBncGlvQGQ0 MDE5MDAwIHsKPiAgICAgICAgICAgICAgICAgICAgICAgICBjb21wYXRpYmxlID0gInNwYWNlbWl0 LGsxLWdwaW8iOwo+ICAgICAgICAgICAgICAgICAgICAgICAgIHJlZyA9IDwweDAgMHhkNDAxOTAw MCAweDAgMHgxMDA+Owo+IAkJCS4uLgo+ICAgICAgICAgICAgICAgICAgICAgICAgIGdwaW8tcmFu Z2VzID0gPCZwaW5jdHJsIDAgMCA5Nj47Cj4gICAgICAgICAgICAgICAgIH07Cj4gCj4gCQlmb28t Z3Bpb3MgPSA8JmdwaW8wIDIgMjggR1BJT19BQ1RJVkVfTE9XPjsKPiAKPiBJdCBzaG91bGQgZ2V0 IEdQSU9fOTIgKCA5MiA9IDIgKiAzMiArIDI4KSwgYnV0IHR1cm5zIG91dCBHUElPXzI4Cj4gCj4g UHJvYmFibHkgdGhlcmUgaXMgc29tZXRoaW5nIEkgbWlzc2VkLi4uCnRvIG1ha2UgdGhlIGdwaW8g cGFydCB3b3JrLCB3ZSBuZWVkIGFkZGl0aW9uYWwgY3VzdG9tIGdwaW8tcmFuZ2VzIHBhcnNlciwK d2hpY2ggc2hvdWxkIHNpbWlsYXIgdG8gb2ZfZ3Bpb2NoaXBfYWRkX3Bpbl9yYW5nZSgpIGluIGdw aW9saWItb2YuYwooYXQgbGVhc3QgZ3BpbyBjb3JlIG5lZWQgdG8gYWRqdXN0IHRvIGNhbGwgY3Vz dG9tIHRoaXMgZnVuY3Rpb24pCgotLSAKWWl4dW4gTGFuIChkbGFuKQpHZW50b28gTGludXggRGV2 ZWxvcGVyCkdQRyBLZXkgSUQgQUFCRUZENTUKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtcmlzY3YK