Re: [PATCH v7 00/15] XSC PMD for Yunsilicon NICs

[Stephen Hemminger <stephen@networkplumber.org>]

On Tue, 28 Jan 2025 22:47:22 +0800
"Renyong Wan" <wanry@yunsilicon.com> wrote:

> This xsc PMD (**librte_net_xsc**) provides poll mode driver for 
> Yunsilicon metaScale serials NICs.
> 
> Features:
> ---------
> - MTU update
> - TSO
> - RSS hash
> - RSS key update
> - RSS reta update
> - L3 checksum offload
> - L4 checksum offload
> - Inner L3 checksum
> - Inner L4 checksum
> - Basic stats
> - Stats per queue
> 
> Support NICs:
> -------------
> - metaScale-200S   Single QSFP56 Port 200GE SmartNIC
> - metaScale-200    Quad QSFP28 Ports 100GE SmartNIC
> - metaScale-50     Dual QSFP28 Port 25GE SmartNIC
> - metaScale-100Q   Quad QSFP28 Port 25GE SmartNIC
> 
> ---
> 
> v7:
> * Remove the packed attributes of sub structures and unions.
> * Remove the cast of xdev->dev_priv.
> * Remove the cast of malloc return value.
> * Define the size of xdev->name to PCI_PRI_STR_SIZE.
> * Change the name of Wanrenyong to Renyong Wan
> 
> v6:
> * Remove unnecessary paren.
> * Add the feature of stats per queue in xsc.ini.
> * Use memcpy instead of rte_memcpy in non critical path.
> * Rebase from the main branch and merge release notes.
> * Replace __rte_packed with __rte_packed_begin and __rte_packed_end.
> 
> v5:
> * fix compilation errors.
> * fix coding style issue with misspelling.
> * remove some unnecessary parameter checks.
> * remove unnecessary call of rte_wmb.
> * Rearrange elements in structure to avoid holes.
> 
> v4:
> * Based on the review comments from previous versions, reconstruct the xsc PMD to eliminate
>   the dependency on rdma core library and proprietary kernel driver, while adding support for
>   the vfio kernel driver.
> 
> v3:
> * fix compilation errors
> 
> v2:
> * fix checkpatch warnings and errors
> 
> ---
> Renyong Wan (15):
>   net/xsc: add xsc PMD framework
>   net/xsc: add xsc device initialization
>   net/xsc: add xsc mailbox
>   net/xsc: add xsc dev ops to support VFIO driver
>   net/xsc: add PCT interfaces
>   net/xsc: initialize xsc representors
>   net/xsc: add ethdev configure and RSS ops
>   net/xsc: add Rx and Tx queue setup
>   net/xsc: add ethdev start
>   net/xsc: add ethdev stop and close
>   net/xsc: add ethdev Rx burst
>   net/xsc: add ethdev Tx burst
>   net/xsc: add basic stats ops
>   net/xsc: add ethdev infos get
>   net/xsc: add ethdev link and MTU ops
> 
>  .mailmap                               |   5 +
>  MAINTAINERS                            |  10 +
>  doc/guides/nics/features/xsc.ini       |  19 +
>  doc/guides/nics/index.rst              |   1 +
>  doc/guides/nics/xsc.rst                |  31 +
>  doc/guides/rel_notes/release_25_03.rst |   4 +
>  drivers/net/meson.build                |   1 +
>  drivers/net/xsc/meson.build            |  17 +
>  drivers/net/xsc/xsc_cmd.h              | 387 +++++++++++
>  drivers/net/xsc/xsc_defs.h             | 100 +++
>  drivers/net/xsc/xsc_dev.c              | 397 +++++++++++
>  drivers/net/xsc/xsc_dev.h              | 184 +++++
>  drivers/net/xsc/xsc_ethdev.c           | 917 +++++++++++++++++++++++++
>  drivers/net/xsc/xsc_ethdev.h           |  63 ++
>  drivers/net/xsc/xsc_log.h              |  24 +
>  drivers/net/xsc/xsc_np.c               | 492 +++++++++++++
>  drivers/net/xsc/xsc_np.h               | 154 +++++
>  drivers/net/xsc/xsc_rx.c               | 512 ++++++++++++++
>  drivers/net/xsc/xsc_rx.h               |  65 ++
>  drivers/net/xsc/xsc_rxtx.h             | 191 +++++
>  drivers/net/xsc/xsc_tx.c               | 354 ++++++++++
>  drivers/net/xsc/xsc_tx.h               |  62 ++
>  drivers/net/xsc/xsc_vfio.c             | 746 ++++++++++++++++++++
>  drivers/net/xsc/xsc_vfio_mbox.c        | 691 +++++++++++++++++++
>  drivers/net/xsc/xsc_vfio_mbox.h        | 142 ++++
>  25 files changed, 5569 insertions(+)
>  create mode 100644 doc/guides/nics/features/xsc.ini
>  create mode 100644 doc/guides/nics/xsc.rst
>  create mode 100644 drivers/net/xsc/meson.build
>  create mode 100644 drivers/net/xsc/xsc_cmd.h
>  create mode 100644 drivers/net/xsc/xsc_defs.h
>  create mode 100644 drivers/net/xsc/xsc_dev.c
>  create mode 100644 drivers/net/xsc/xsc_dev.h
>  create mode 100644 drivers/net/xsc/xsc_ethdev.c
>  create mode 100644 drivers/net/xsc/xsc_ethdev.h
>  create mode 100644 drivers/net/xsc/xsc_log.h
>  create mode 100644 drivers/net/xsc/xsc_np.c
>  create mode 100644 drivers/net/xsc/xsc_np.h
>  create mode 100644 drivers/net/xsc/xsc_rx.c
>  create mode 100644 drivers/net/xsc/xsc_rx.h
>  create mode 100644 drivers/net/xsc/xsc_rxtx.h
>  create mode 100644 drivers/net/xsc/xsc_tx.c
>  create mode 100644 drivers/net/xsc/xsc_tx.h
>  create mode 100644 drivers/net/xsc/xsc_vfio.c
>  create mode 100644 drivers/net/xsc/xsc_vfio_mbox.c
>  create mode 100644 drivers/net/xsc/xsc_vfio_mbox.h
> 

Now that XSC is merged to main, there are a number of possible problems reported
by PVS studio.

The Vxxx value is the PVS studio error code.

xsc_dev.c (292)
V576	Incorrect format. Consider checking the fifth actual argument of the 'rte_log' function. The UNSIGNED integer type argument is expected.
xsc_dev.c (292)
V576	Incorrect format. Consider checking the sixth actual argument of the 'rte_log' function. The UNSIGNED integer type argument is expected.
xsc_ethdev.c (724)
V547	Expression 'config->tso' is always true.
xsc_ethdev.c (728)
V547	Expression is always false.
xsc_ethdev.c (729)
V547	Expression 'priv->is_representor' is always true.
xsc_ethdev.c (316)
V1001	The 'ret' variable is assigned but is not used by the end of the function.
xsc_ethdev.c (141)
V522	There might be dereferencing of a potential null pointer 'rxq'.
xsc_ethdev.c (165)
V522	There might be dereferencing of a potential null pointer 'txq'.
xsc_ethdev.c (650)
V526	The 'memcmp' function returns 0 if corresponding buffers are equal. Consider examining the condition for mistakes.
xsc_ethdev.c (825)
V1027	Pointer to an object of the 'rte_device' class is cast to unrelated 'rte_pci_device' class.
xsc_np.c (175)
V595	The 'in' pointer was utilized before it was verified against nullptr. Check lines: 175, 176.
xsc_np.c (140)
V560	A part of conditional expression is always false: (rss_conf->rss_hf & (0UL << 50)).
xsc_np.c (175)
V575	The potential null pointer is passed into 'memset' function. Inspect the first argument. Check lines: 175, 174.
xsc_np.c (142)
V1048	The 'outer' variable was assigned the same value.
xsc_np.c (192)
V1027	Pointer to an object of the 'xsc_np_mbox_in' class is cast to unrelated 'xsc_np_mbox_out' class.
xsc_rx.c (296)
V595	The 'in' pointer was utilized before it was verified against nullptr. Check lines: 296, 297.
xsc_rx.c (45)
V560	A part of conditional expression is always false: ret == - 1.
xsc_rx.c (45)
V560	A part of conditional expression is always false: ret == 0x2.
xsc_rx.c (296)
V575	The potential null pointer is passed into 'memset' function. Inspect the first argument. Check lines: 296, 295.
xsc_rx.c (284)
V522	There might be dereferencing of a potential null pointer 'rxq_data'.
xsc_rx.c (391)
V522	There might be dereferencing of a potential null pointer 'rxq_data'.
xsc_rx.c (430)
V522	Dereferencing of the null pointer might take place. The potential null pointer is passed into 'xsc_rxq_elts_alloc' function. Inspect the first argument. Check lines: 'xsc_rx.c:430', 'xsc_ethdev.c:274'.
xsc_rx.c (361)
V576	Incorrect format. Consider checking the fifth actual argument of the 'rte_log' function. The UNSIGNED integer type argument is expected.
xsc_rx.c (361)
V576	Incorrect format. Consider checking the ninth actual argument of the 'rte_log' function. The SIGNED integer type argument is expected.
xsc_rx.c (410)
V576	Incorrect format. Consider checking the ninth actual argument of the 'rte_log' function. The SIGNED integer type argument is expected.
xsc_rx.c (447)
V656	Variables '(mbuf)->data_len', '(mbuf)->pkt_len' are initialized through the call to the same function. It's probably an error or un-optimized code. Check lines: 445, 447.
xsc_rx.c (335)
V1027	Pointer to an object of the 'xsc_cmd_create_multiqp_mbox_in' class is cast to unrelated 'xsc_cmd_create_multiqp_mbox_out' class.
xsc_tx.c (18)
V522	Dereferencing of the null pointer might take place. The potential null pointer is passed into 'xsc_txq_elts_alloc' function. Inspect the first argument. Check lines: 'xsc_tx.c:18', 'xsc_ethdev.c:232'.
xsc_tx.c (55)
V576	Incorrect format. Consider checking the eighth actual argument of the 'rte_log' function. The SIGNED integer type argument is expected.
xsc_tx.c (86)
V576	Incorrect format. Consider checking the eighth actual argument of the 'rte_log' function. The SIGNED integer type argument is expected.
xsc_tx.c (218)
V1048	The 'cs->has_pph' variable was assigned the same value.
xsc_vfio.c (434)
V595	The 'in' pointer was utilized before it was verified against nullptr. Check lines: 434, 435.
xsc_vfio.c (434)
V575	The potential null pointer is passed into 'memset' function. Inspect the first argument. Check lines: 434, 433.
xsc_vfio.c (340)
V576	Incorrect format. Consider checking the fifth actual argument of the 'rte_log' function. The SIGNED integer type argument is expected.
xsc_vfio.c (486)
V576	Incorrect format. Consider checking the seventh actual argument of the 'rte_log' function. The SIGNED integer type argument is expected.
xsc_vfio.c (88)
V1027	Pointer to an object of the 'xsc_cmd_query_hca_cap_mbox_in' class is cast to unrelated 'xsc_cmd_query_hca_cap_mbox_out' class.
xsc_vfio.c (207)
V1027	Pointer to an object of the 'xsc_cmd_destroy_qp_mbox_in' class is cast to unrelated 'xsc_cmd_destroy_qp_mbox_out' class.
xsc_vfio.c (248)
V1027	Pointer to an object of the 'xsc_cmd_destroy_cq_mbox_in' class is cast to unrelated 'xsc_cmd_destroy_cq_mbox_out' class.
xsc_vfio.c (330)
V1027	Pointer to an object of the 'xsc_cmd_modify_qp_mbox_in' class is cast to unrelated 'xsc_cmd_modify_qp_mbox_out' class.
xsc_vfio.c (380)
V1027	Pointer to an object of the 'xsc_cmd_modify_raw_qp_mbox_in' class is cast to unrelated 'xsc_cmd_modify_raw_qp_mbox_out' class.
xsc_vfio.c (463)
V1027	Pointer to an object of the 'xsc_cmd_create_cq_mbox_in' class is cast to unrelated 'xsc_cmd_create_cq_mbox_out' class.
xsc_vfio.c (560)
V1027	Pointer to an object of the 'xsc_cmd_create_cq_mbox_in' class is cast to unrelated 'xsc_cmd_create_cq_mbox_out' class.
xsc_vfio.c (666)
V1027	Pointer to an object of the 'xsc_cmd_create_qp_mbox_in' class is cast to unrelated 'xsc_cmd_create_qp_mbox_out' class.
xsc_vfio_mbox.c (517)
V576	Incorrect format. Consider checking the seventh actual argument of the 'rte_log' function. The UNSIGNED integer type argument is expected.
xsc_vfio_mbox.c (575)
V1048	The 'size' variable was assigned the same value.