All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	Apeksha Gupta <apeksha.gupta@nxp.com>,
	Sachin Saxena <sachin.saxena@nxp.com>
Subject: [PATCH v2 5/6] net/enetfec: remove unneeded deferred start check
Date: Fri, 14 Feb 2025 09:38:58 -0800	[thread overview]
Message-ID: <20250214174224.79142-6-stephen@networkplumber.org> (raw)
In-Reply-To: <20250214174224.79142-1-stephen@networkplumber.org>

Already checked in ethdev now.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/enetfec/enet_ethdev.c | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)

diff --git a/drivers/net/enetfec/enet_ethdev.c b/drivers/net/enetfec/enet_ethdev.c
index 0d27b63953..7c2926409e 100644
--- a/drivers/net/enetfec/enet_ethdev.c
+++ b/drivers/net/enetfec/enet_ethdev.c
@@ -366,7 +366,7 @@ enetfec_tx_queue_setup(struct rte_eth_dev *dev,
 			uint16_t queue_idx,
 			uint16_t nb_desc,
 			unsigned int socket_id __rte_unused,
-			const struct rte_eth_txconf *tx_conf)
+			const struct rte_eth_txconf *tx_conf __rte_unused)
 {
 	struct enetfec_private *fep = dev->data->dev_private;
 	unsigned int i;
@@ -377,12 +377,6 @@ enetfec_tx_queue_setup(struct rte_eth_dev *dev,
 		sizeof(struct bufdesc);
 	unsigned int dsize_log2 = rte_fls_u64(dsize) - 1;
 
-	/* Tx deferred start is not supported */
-	if (tx_conf->tx_deferred_start) {
-		ENETFEC_PMD_ERR("Tx deferred start not supported");
-		return -EINVAL;
-	}
-
 	/* allocate transmit queue */
 	txq = rte_zmalloc(NULL, sizeof(*txq), RTE_CACHE_LINE_SIZE);
 	if (txq == NULL) {
@@ -442,7 +436,7 @@ enetfec_rx_queue_setup(struct rte_eth_dev *dev,
 			uint16_t queue_idx,
 			uint16_t nb_rx_desc,
 			unsigned int socket_id __rte_unused,
-			const struct rte_eth_rxconf *rx_conf,
+			const struct rte_eth_rxconf *rx_conf __rte_unused,
 			struct rte_mempool *mb_pool)
 {
 	struct enetfec_private *fep = dev->data->dev_private;
@@ -455,12 +449,6 @@ enetfec_rx_queue_setup(struct rte_eth_dev *dev,
 			sizeof(struct bufdesc);
 	unsigned int dsize_log2 = rte_fls_u64(dsize) - 1;
 
-	/* Rx deferred start is not supported */
-	if (rx_conf->rx_deferred_start) {
-		ENETFEC_PMD_ERR("Rx deferred start not supported");
-		return -EINVAL;
-	}
-
 	if (queue_idx >= ENETFEC_MAX_Q) {
 		ENETFEC_PMD_ERR("Invalid queue id %" PRIu16 ", max %d",
 			queue_idx, ENETFEC_MAX_Q);
-- 
2.47.2


  parent reply	other threads:[~2025-02-14 17:43 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-13 21:48 [PATCH 0/5] centralize deferred start checks Stephen Hemminger
2024-12-13 21:48 ` [PATCH 1/5] ethdev: check that device supports deferred start Stephen Hemminger
2024-12-13 21:48 ` [PATCH 2/5] net/dpaa: remove unnecessary deferred start check Stephen Hemminger
2024-12-13 21:48 ` [PATCH 3/5] net/dpaa2: remove unneeded " Stephen Hemminger
2024-12-13 21:48 ` [PATCH 4/5] net/enetfec: " Stephen Hemminger
2024-12-13 21:48 ` [PATCH 5/5] net/virtio: " Stephen Hemminger
2024-12-14 18:07 ` [PATCH v2 0/5] add check for deferred start to ethdev Stephen Hemminger
2024-12-14 18:07   ` [PATCH v2 1/5] ethdev: check that device supports deferred start Stephen Hemminger
2024-12-15  8:56     ` Andrew Rybchenko
2024-12-16 18:58       ` Stephen Hemminger
2024-12-17  6:07         ` Andrew Rybchenko
2024-12-14 18:07   ` [PATCH v2 2/5] net/dpaa: remove unnecessary deferred start check Stephen Hemminger
2024-12-14 18:07   ` [PATCH v2 3/5] net/dpaa2: remove unneeded " Stephen Hemminger
2024-12-14 18:07   ` [PATCH v2 4/5] net/enetfec: " Stephen Hemminger
2024-12-14 18:07   ` [PATCH v2 5/5] net/virtio: " Stephen Hemminger
2024-12-16 19:11 ` [PATCH v3 0/6] queue start/stop and deferred checks Stephen Hemminger
2024-12-16 19:11   ` [PATCH v3 1/6] ethdev: check that device supports deferred start Stephen Hemminger
2024-12-16 19:11   ` [PATCH v3 2/6] doc: fix feature flags for queue start/stop Stephen Hemminger
2024-12-16 19:11   ` [PATCH v3 3/6] net/dpaa: remove unnecessary deferred start check Stephen Hemminger
2024-12-16 19:11   ` [PATCH v3 4/6] net/dpaa2: remove unneeded " Stephen Hemminger
2024-12-16 19:11   ` [PATCH v3 5/6] net/enetfec: " Stephen Hemminger
2024-12-16 19:11   ` [PATCH v3 6/6] net/virtio: " Stephen Hemminger
2025-01-28 21:03   ` [PATCH v3 0/6] queue start/stop and deferred checks Stephen Hemminger
2025-02-14 17:38 ` [PATCH v2 0/6] fix the handling of deferred start in ethdev Stephen Hemminger
2025-02-14 17:38   ` [PATCH v2 1/6] ethdev: check that device supports deferred start Stephen Hemminger
2025-02-17 17:12     ` Bruce Richardson
2025-02-14 17:38   ` [PATCH v2 2/6] doc: fix feature flags for queue start/stop Stephen Hemminger
2025-02-14 17:38   ` [PATCH v2 3/6] net/dpaa: remove unnecessary deferred start check Stephen Hemminger
2025-02-14 17:38   ` [PATCH v2 4/6] net/dpaa2: remove unneeded " Stephen Hemminger
2025-02-14 17:38   ` Stephen Hemminger [this message]
2025-02-14 17:38   ` [PATCH v2 6/6] net/virtio: " Stephen Hemminger
2025-02-17 17:13   ` [PATCH v2 0/6] fix the handling of deferred start in ethdev Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250214174224.79142-6-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=apeksha.gupta@nxp.com \
    --cc=dev@dpdk.org \
    --cc=sachin.saxena@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.