From: Peter Zijlstra <peterz@infradead.org>
To: Dave Hansen <dave.hansen@intel.com>
Cc: Rik van Riel <riel@surriel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de,
dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com,
nadav.amit@gmail.com, thomas.lendacky@amd.com,
kernel-team@meta.com, linux-mm@kvack.org,
akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com,
mhklinux@outlook.com, andrew.cooper3@citrix.com,
Manali Shukla <Manali.Shukla@amd.com>
Subject: Re: [PATCH v11 06/12] x86/mm: use INVLPGB for kernel TLB flushes
Date: Fri, 14 Feb 2025 20:40:13 +0100 [thread overview]
Message-ID: <20250214194013.GA2198@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <ab55a809-e0d2-4364-84ce-917a40ee299a@intel.com>
On Fri, Feb 14, 2025 at 10:35:40AM -0800, Dave Hansen wrote:
> On 2/13/25 08:13, Rik van Riel wrote:
> > - if (info->end == TLB_FLUSH_ALL)
> > + if (broadcast_kernel_range_flush(info))
> > + ; /* Fall through. */
> > + else if (info->end == TLB_FLUSH_ALL)
> > on_each_cpu(do_flush_tlb_all, NULL, 1);
> > else
> > on_each_cpu(do_kernel_range_flush, info, 1);
>
> We've got to find a better name for broadcast_kernel_range_flush().
> Because IPIs are broadcast too. The naming makes it confusing. Why would
> be broadcast, and then start trying IPIs that are also broadcast?
IIRC the more general name is indeed broadcast tlbi; as in other
architectures use this naming to mean this very thing too.
But yes, I see the confusion, but I don't think changing the naming
really helps a lot here :-/
next prev parent reply other threads:[~2025-02-14 19:40 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 16:13 [PATCH v11 00/12] AMD broadcast TLB invalidation Rik van Riel
2025-02-13 16:13 ` [PATCH v11 01/12] x86/mm: make MMU_GATHER_RCU_TABLE_FREE unconditional Rik van Riel
2025-02-21 15:30 ` [tip: x86/mm] x86/mm: Make " tip-bot2 for Rik van Riel
2025-02-13 16:13 ` [PATCH v11 02/12] x86/mm: remove pv_ops.mmu.tlb_remove_table call Rik van Riel
2025-02-21 15:30 ` [tip: x86/mm] x86/mm: Remove " tip-bot2 for Rik van Riel
2025-02-13 16:13 ` [PATCH v11 03/12] x86/mm: consolidate full flush threshold decision Rik van Riel
2025-02-14 18:07 ` Dave Hansen
2025-02-19 11:21 ` Borislav Petkov
2025-02-13 16:13 ` [PATCH v11 04/12] x86/mm: get INVLPGB count max from CPUID Rik van Riel
2025-02-14 18:16 ` Dave Hansen
2025-02-19 11:56 ` Borislav Petkov
2025-02-19 17:52 ` Rik van Riel
2025-02-19 18:23 ` Borislav Petkov
2025-02-19 19:26 ` Dave Hansen
2025-02-13 16:13 ` [PATCH v11 05/12] x86/mm: add INVLPGB support code Rik van Riel
2025-02-14 18:22 ` Dave Hansen
2025-02-18 17:23 ` Rik van Riel
2025-02-19 12:04 ` Borislav Petkov
2025-02-19 17:42 ` Rik van Riel
2025-02-19 19:01 ` Dave Hansen
2025-02-19 19:15 ` Borislav Petkov
2025-02-20 2:49 ` Rik van Riel
2025-02-20 10:23 ` Borislav Petkov
2025-02-13 16:13 ` [PATCH v11 06/12] x86/mm: use INVLPGB for kernel TLB flushes Rik van Riel
2025-02-14 18:35 ` Dave Hansen
2025-02-14 19:40 ` Peter Zijlstra [this message]
2025-02-14 19:55 ` Dave Hansen
2025-02-15 1:25 ` Rik van Riel
2025-02-15 2:08 ` Yosry Ahmed
2025-02-18 18:00 ` Rik van Riel
2025-02-18 22:27 ` Dave Hansen
2025-02-19 1:46 ` Yosry Ahmed
2025-02-13 16:13 ` [PATCH v11 07/12] x86/mm: use INVLPGB in flush_tlb_all Rik van Riel
2025-02-14 18:57 ` Dave Hansen
2025-02-13 16:13 ` [PATCH v11 08/12] x86/mm: use broadcast TLB flushing for page reclaim TLB flushing Rik van Riel
2025-02-14 18:51 ` Dave Hansen
2025-02-18 19:31 ` Rik van Riel
2025-02-18 19:46 ` Dave Hansen
2025-02-18 20:06 ` Rik van Riel
2025-02-13 16:14 ` [PATCH v11 09/12] x86/mm: enable broadcast TLB invalidation for multi-threaded processes Rik van Riel
2025-02-14 19:53 ` Dave Hansen
2025-02-17 13:22 ` Brendan Jackman
2025-02-20 15:25 ` Rik van Riel
2025-02-13 16:14 ` [PATCH v11 10/12] x86/mm: do targeted broadcast flushing from tlbbatch code Rik van Riel
2025-02-13 16:14 ` [PATCH v11 11/12] x86/mm: enable AMD translation cache extensions Rik van Riel
2025-02-13 16:14 ` [PATCH v11 12/12] x86/mm: only invalidate final translations with INVLPGB Rik van Riel
2025-02-13 18:31 ` [PATCH v11 00/12] AMD broadcast TLB invalidation Brendan Jackman
2025-02-13 18:38 ` Brendan Jackman
2025-02-13 20:02 ` Rik van Riel
2025-02-14 9:36 ` Peter Zijlstra
2025-02-14 9:54 ` Brendan Jackman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250214194013.GA2198@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Manali.Shukla@amd.com \
--cc=akpm@linux-foundation.org \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=jackmanb@google.com \
--cc=jannh@google.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhklinux@outlook.com \
--cc=nadav.amit@gmail.com \
--cc=riel@surriel.com \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.