From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
petrm@nvidia.com, stfomichev@gmail.com
Subject: Re: [PATCH net-next v2 3/3] selftests: drv-net: add a simple TSO test
Date: Sat, 15 Feb 2025 08:31:21 -0800 [thread overview]
Message-ID: <20250215083121.5bb31524@kernel.org> (raw)
In-Reply-To: <67b0a976ba5fd_36e344294b1@willemb.c.googlers.com.notmuch>
On Sat, 15 Feb 2025 09:49:26 -0500 Willem de Bruijn wrote:
> > + cases = []
> > + for outer_ipv4 in [True, False]:
> > + for info in test_info:
> > + # Skip if test which only works for a specific IP version
> > + if outer_ipv4 == info[1]:
>
> Only if need to respin:
>
> using ternary True, False, None for skip_ipv6, skip_ipv4, skip_neither
> is a bit non-obvious. Use strings?
Now that you say it..
I think using ipver with values "4" "6" could clean up a few things.
I'll poke a little bit on Monday, and probably respin.
next prev parent reply other threads:[~2025-02-15 16:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 23:46 [PATCH net-next v2 0/3] selftests: drv-net: add a simple TSO test Jakub Kicinski
2025-02-14 23:46 ` [PATCH net-next v2 1/3] selftests: drv-net: resolve remote interface name Jakub Kicinski
2025-02-15 14:50 ` Willem de Bruijn
2025-02-17 11:42 ` Petr Machata
2025-02-14 23:46 ` [PATCH net-next v2 2/3] selftests: drv-net: get detailed interface info Jakub Kicinski
2025-02-15 14:50 ` Willem de Bruijn
2025-02-14 23:46 ` [PATCH net-next v2 3/3] selftests: drv-net: add a simple TSO test Jakub Kicinski
2025-02-15 14:49 ` Willem de Bruijn
2025-02-15 16:31 ` Jakub Kicinski [this message]
2025-02-15 14:50 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250215083121.5bb31524@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=stfomichev@gmail.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.