From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AF451624D3; Sat, 15 Feb 2025 19:04:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739646272; cv=none; b=cbxYigX5iULanDMi+VNTLAJg4CJh9lP/xZHkRL0Gt/VJP/EWjvb9neHBvL8N+pjgjjYlSVv8Y3Z1J7X5nBry6i7PEkRvq2PQqCScvPNWKo578SJWuU53HcaDAp9U1HFqzQSl0P8nG+4F60joaB3k4rxoDUwcvUkq0RWl+MiU1Uk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739646272; c=relaxed/simple; bh=Df2b8aVgJjFNJGQ3bD+jOZ3m5M4kbFV5KsneEFnbz1Y=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=G+gBBUtfdQ8MrKOfJZ+eIzWUhUgdlEc1M8VZevXxJytlxkUYDM16zknFq0FoD0S1ZTH9BqXitA3haaL8D+0/V3GtvQzgY2Bzkybwa7mr6dTuxjiaPKyyrVfF5+fHANtXmKk8vBo4ZbNIFF7IRhYe5tr0G5vF3Ul3sq5RPcQdONI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HOSb0Y5r; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HOSb0Y5r" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D038CC4CEDF; Sat, 15 Feb 2025 19:04:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739646271; bh=Df2b8aVgJjFNJGQ3bD+jOZ3m5M4kbFV5KsneEFnbz1Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HOSb0Y5rS2c+iF55klymj6B0z0P3nkofcNiCgsMP5plndlLE+6Ux2rzZK9kiCXW0A 8Xv9r5UvZhELq5KpOx3B3v+yWB5mCSwHcqK5aJtn5i9hYLs9s/hOsJ+NSMtxlU6Qzl SAmAb3QN87QQ4fNEWxSaL0jt3Bc2P5Unl9V11YdJZrVbuWkOxjDpNQv8aOVjjCDGEk BRrau+nibXXPqTvtcM4xYrX6rwfHPAQUZu1Sr7G6uCXWbwx3ZmngcvJqZYiyb0h0rq WO1T/S5i1kzxfiA2YYuU0zPyax6bsKZ3H6dUECjmFG8VpVNYCdjH2uRurDUOBQw58t V3Llh8KYjzaug== Date: Sat, 15 Feb 2025 11:04:28 -0800 From: Jakub Kicinski To: Song Yoong Siang Cc: "David S . Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Willem de Bruijn , Florian Bezdeka , Donald Hunter , Jonathan Corbet , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , Andrew Lunn , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Joe Damato , Stanislav Fomichev , Xuan Zhuo , Mina Almasry , Daniel Jurgens , Andrii Nakryiko , Eduard Zingerman , Mykola Lysenko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , Shuah Khan , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Tony Nguyen , Przemek Kitszel , Faizal Rahim , Choong Yong Liang , Bouska Zdenek , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, intel-wired-lan@lists.osuosl.org, xdp-hints@xdp-project.net Subject: Re: [PATCH bpf-next v10 1/5] xsk: Add launch time hardware offload support to XDP Tx metadata Message-ID: <20250215110428.68f25c5e@kernel.org> In-Reply-To: <20250215110159.0c1888ae@kernel.org> References: <20250207021943.814768-1-yoong.siang.song@intel.com> <20250207021943.814768-2-yoong.siang.song@intel.com> <20250215110159.0c1888ae@kernel.org> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 15 Feb 2025 11:01:59 -0800 Jakub Kicinski wrote: > On Fri, 7 Feb 2025 10:19:39 +0800 Song Yoong Siang wrote: > > Extend the XDP Tx metadata framework so that user can requests launch time > > hardware offload, where the Ethernet device will schedule the packet for > > transmission at a pre-determined time called launch time. The value of > > launch time is communicated from user space to Ethernet driver via > > launch_time field of struct xsk_tx_metadata. > > Acked-by: Jakub Kicinski Sorry, I take that back, you haven't regenerated the code after renaming the flag: diff --git a/include/uapi/linux/netdev.h b/include/uapi/linux/netdev.h index fc0aa971d276..b97ff8bbb0c6 100644 --- a/include/uapi/linux/netdev.h +++ b/include/uapi/linux/netdev.h @@ -59,13 +59,13 @@ enum netdev_xdp_rx_metadata { * by the driver. * @NETDEV_XSK_FLAGS_TX_CHECKSUM: L3 checksum HW offload is supported by the * driver. - * @NETDEV_XSK_FLAGS_LAUNCH_TIME: Launch Time HW offload is supported by the - * driver. + * @NETDEV_XSK_FLAGS_TX_LAUNCH_TIME_FIFO: Launch time HW offload is supported + * by the driver. */ enum netdev_xsk_flags { NETDEV_XSK_FLAGS_TX_TIMESTAMP = 1, NETDEV_XSK_FLAGS_TX_CHECKSUM = 2, - NETDEV_XSK_FLAGS_LAUNCH_TIME = 4, + NETDEV_XSK_FLAGS_TX_LAUNCH_TIME_FIFO = 4, }; enum netdev_queue_type { diff --git a/tools/include/uapi/linux/netdev.h b/tools/include/uapi/linux/netdev.h index fc0aa971d276..b97ff8bbb0c6 100644 --- a/tools/include/uapi/linux/netdev.h +++ b/tools/include/uapi/linux/netdev.h @@ -59,13 +59,13 @@ enum netdev_xdp_rx_metadata { * by the driver. * @NETDEV_XSK_FLAGS_TX_CHECKSUM: L3 checksum HW offload is supported by the * driver. - * @NETDEV_XSK_FLAGS_LAUNCH_TIME: Launch Time HW offload is supported by the - * driver. + * @NETDEV_XSK_FLAGS_TX_LAUNCH_TIME_FIFO: Launch time HW offload is supported + * by the driver. */ enum netdev_xsk_flags { NETDEV_XSK_FLAGS_TX_TIMESTAMP = 1, NETDEV_XSK_FLAGS_TX_CHECKSUM = 2, - NETDEV_XSK_FLAGS_LAUNCH_TIME = 4, + NETDEV_XSK_FLAGS_TX_LAUNCH_TIME_FIFO = 4, }; enum netdev_queue_type { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA211C021A4 for ; Sat, 15 Feb 2025 19:04:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 7AA504125F; Sat, 15 Feb 2025 19:04:36 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id iuXLcthA-akE; Sat, 15 Feb 2025 19:04:35 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 8170441260 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1739646275; bh=eDvpuk0CR6sJWCa60+MpwNNb0XigVBbopBtfb5BpIIE=; h=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=R1x1yeXstuwXPXOEDl46+Gw4SOCqjzRwJL67PU+VVl3C/da9qRXoTAI037GZzdO3T uXId62Haxn5wFvmqhe2xWDetkpLoOhF4EbFAnBP7+Mnp+JGxpw1toUefQPgQZ00eNY XU69TbvC69T6p5Rh0RfMXGAG09uz4/D1x1knNbVr1Urv+rggt5Wn0h5N0bi/M22r1K WrXBIbfKf2jaU/xxcZHDZQEb5tTVXntUBXWr4hAMdcpGbK3yUlYwmmGW7pp0H7hBqy ugzuroPNC48ds28rC2paKPBj+8xv4Xk0DO2HbhFH6H3Or/EVwa1WCP57v2x+vhc3X5 dLiPMRMt8rPmg== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 8170441260; Sat, 15 Feb 2025 19:04:35 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists1.osuosl.org (Postfix) with ESMTP id 43ACC72 for ; Sat, 15 Feb 2025 19:04:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 3146F41260 for ; Sat, 15 Feb 2025 19:04:34 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id ySyFlRXcfabM for ; Sat, 15 Feb 2025 19:04:33 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp4.osuosl.org 3E2154125F DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 3E2154125F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp4.osuosl.org (Postfix) with ESMTPS id 3E2154125F for ; Sat, 15 Feb 2025 19:04:33 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7CE5C5C485C; Sat, 15 Feb 2025 19:03:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D038CC4CEDF; Sat, 15 Feb 2025 19:04:29 +0000 (UTC) Date: Sat, 15 Feb 2025 11:04:28 -0800 From: Jakub Kicinski To: Song Yoong Siang Cc: "David S . Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Willem de Bruijn , Florian Bezdeka , Donald Hunter , Jonathan Corbet , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , Andrew Lunn , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Joe Damato , Stanislav Fomichev , Xuan Zhuo , Mina Almasry , Daniel Jurgens , Andrii Nakryiko , Eduard Zingerman , Mykola Lysenko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Hao Luo , Jiri Olsa , Shuah Khan , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Tony Nguyen , Przemek Kitszel , Faizal Rahim , Choong Yong Liang , Bouska Zdenek , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, intel-wired-lan@lists.osuosl.org, xdp-hints@xdp-project.net Message-ID: <20250215110428.68f25c5e@kernel.org> In-Reply-To: <20250215110159.0c1888ae@kernel.org> References: <20250207021943.814768-1-yoong.siang.song@intel.com> <20250207021943.814768-2-yoong.siang.song@intel.com> <20250215110159.0c1888ae@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739646271; bh=Df2b8aVgJjFNJGQ3bD+jOZ3m5M4kbFV5KsneEFnbz1Y=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HOSb0Y5rS2c+iF55klymj6B0z0P3nkofcNiCgsMP5plndlLE+6Ux2rzZK9kiCXW0A 8Xv9r5UvZhELq5KpOx3B3v+yWB5mCSwHcqK5aJtn5i9hYLs9s/hOsJ+NSMtxlU6Qzl SAmAb3QN87QQ4fNEWxSaL0jt3Bc2P5Unl9V11YdJZrVbuWkOxjDpNQv8aOVjjCDGEk BRrau+nibXXPqTvtcM4xYrX6rwfHPAQUZu1Sr7G6uCXWbwx3ZmngcvJqZYiyb0h0rq WO1T/S5i1kzxfiA2YYuU0zPyax6bsKZ3H6dUECjmFG8VpVNYCdjH2uRurDUOBQw58t V3Llh8KYjzaug== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=HOSb0Y5r Subject: Re: [Intel-wired-lan] [PATCH bpf-next v10 1/5] xsk: Add launch time hardware offload support to XDP Tx metadata X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Sat, 15 Feb 2025 11:01:59 -0800 Jakub Kicinski wrote: > On Fri, 7 Feb 2025 10:19:39 +0800 Song Yoong Siang wrote: > > Extend the XDP Tx metadata framework so that user can requests launch time > > hardware offload, where the Ethernet device will schedule the packet for > > transmission at a pre-determined time called launch time. The value of > > launch time is communicated from user space to Ethernet driver via > > launch_time field of struct xsk_tx_metadata. > > Acked-by: Jakub Kicinski Sorry, I take that back, you haven't regenerated the code after renaming the flag: diff --git a/include/uapi/linux/netdev.h b/include/uapi/linux/netdev.h index fc0aa971d276..b97ff8bbb0c6 100644 --- a/include/uapi/linux/netdev.h +++ b/include/uapi/linux/netdev.h @@ -59,13 +59,13 @@ enum netdev_xdp_rx_metadata { * by the driver. * @NETDEV_XSK_FLAGS_TX_CHECKSUM: L3 checksum HW offload is supported by the * driver. - * @NETDEV_XSK_FLAGS_LAUNCH_TIME: Launch Time HW offload is supported by the - * driver. + * @NETDEV_XSK_FLAGS_TX_LAUNCH_TIME_FIFO: Launch time HW offload is supported + * by the driver. */ enum netdev_xsk_flags { NETDEV_XSK_FLAGS_TX_TIMESTAMP = 1, NETDEV_XSK_FLAGS_TX_CHECKSUM = 2, - NETDEV_XSK_FLAGS_LAUNCH_TIME = 4, + NETDEV_XSK_FLAGS_TX_LAUNCH_TIME_FIFO = 4, }; enum netdev_queue_type { diff --git a/tools/include/uapi/linux/netdev.h b/tools/include/uapi/linux/netdev.h index fc0aa971d276..b97ff8bbb0c6 100644 --- a/tools/include/uapi/linux/netdev.h +++ b/tools/include/uapi/linux/netdev.h @@ -59,13 +59,13 @@ enum netdev_xdp_rx_metadata { * by the driver. * @NETDEV_XSK_FLAGS_TX_CHECKSUM: L3 checksum HW offload is supported by the * driver. - * @NETDEV_XSK_FLAGS_LAUNCH_TIME: Launch Time HW offload is supported by the - * driver. + * @NETDEV_XSK_FLAGS_TX_LAUNCH_TIME_FIFO: Launch time HW offload is supported + * by the driver. */ enum netdev_xsk_flags { NETDEV_XSK_FLAGS_TX_TIMESTAMP = 1, NETDEV_XSK_FLAGS_TX_CHECKSUM = 2, - NETDEV_XSK_FLAGS_LAUNCH_TIME = 4, + NETDEV_XSK_FLAGS_TX_LAUNCH_TIME_FIFO = 4, }; enum netdev_queue_type {