Re: [v2 PATCH 11/11] fsverity: improve performance by using multibuffer hashing

[kernel test robot <lkp@intel.com>]

Hi Herbert,

kernel test robot noticed the following build warnings:

[auto build test WARNING on herbert-cryptodev-2.6/master]
[also build test WARNING on next-20250214]
[cannot apply to herbert-crypto-2.6/master brauner-vfs/vfs.all linus/master v6.14-rc2]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Herbert-Xu/crypto-ahash-Only-save-callback-and-data-in-ahash_save_req/20250216-150941
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
patch link:    https://lore.kernel.org/r/dd11ea3e7231fb46f68d902ba38a5b688e378bfe.1739674648.1.git.herbert%40gondor.apana.org.au
patch subject: [v2 PATCH 11/11] fsverity: improve performance by using multibuffer hashing
config: hexagon-allyesconfig (https://download.01.org/0day-ci/archive/20250217/202502170225.YjYWM8fo-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250217/202502170225.YjYWM8fo-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502170225.YjYWM8fo-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/verity/verify.c:295:1: warning: stack frame size (1312) exceeds limit (1024) in 'fsverity_verify_pending_blocks' [-Wframe-larger-than]
     295 | fsverity_verify_pending_blocks(struct fsverity_verification_context *ctx)
         | ^
   1 warning generated.


vim +/fsverity_verify_pending_blocks +295 fs/verity/verify.c

   293	
   294	static bool
 > 295	fsverity_verify_pending_blocks(struct fsverity_verification_context *ctx)
   296	{
   297		struct inode *inode = ctx->inode;
   298		struct fsverity_info *vi = ctx->vi;
   299		const struct merkle_tree_params *params = &vi->tree_params;
   300		SYNC_HASH_REQUESTS_ON_STACK(reqs, FS_VERITY_MAX_PENDING_DATA_BLOCKS, params->hash_alg->tfm);
   301		struct ahash_request *req;
   302		int i;
   303		int err;
   304	
   305		if (ctx->num_pending == 0)
   306			return true;
   307	
   308		req = sync_hash_requests(reqs, 0);
   309		for (i = 0; i < ctx->num_pending; i++) {
   310			struct ahash_request *reqi = sync_hash_requests(reqs, i);
   311	
   312			ahash_request_set_callback(reqi, CRYPTO_TFM_REQ_MAY_SLEEP,
   313						   NULL, NULL);
   314			ahash_request_set_virt(reqi, ctx->pending_blocks[i].data,
   315					       ctx->pending_blocks[i].real_hash,
   316					       params->block_size);
   317			if (i)
   318				ahash_request_chain(reqi, req);
   319			if (!params->hashstate)
   320				continue;
   321	
   322			err = crypto_ahash_import(reqi, params->hashstate);
   323			if (err) {
   324				fsverity_err(inode, "Error %d importing hash state", err);
   325				return false;
   326			}
   327		}
   328	
   329		if (params->hashstate)
   330			err = crypto_ahash_finup(req);
   331		else
   332			err = crypto_ahash_digest(req);
   333		if (err) {
   334			fsverity_err(inode, "Error %d computing block hashes", err);
   335			return false;
   336		}
   337	
   338		for (i = 0; i < ctx->num_pending; i++) {
   339			if (!verify_data_block(inode, vi, &ctx->pending_blocks[i],
   340					       ctx->max_ra_pages))
   341				return false;
   342		}
   343	
   344		fsverity_clear_pending_blocks(ctx);
   345		return true;
   346	}
   347	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki