Re: [PATCH] testpmd: support meter_mark init_color in indirect list configuration

[Stephen Hemminger <stephen@networkplumber.org>]

On Sun, 16 Feb 2025 16:04:20 +0200
Gregory Etelson <getelson@nvidia.com> wrote:

> Flow actions parameters in indirect actions list are created as
> read-only and shared between all flows that reference that indirect
> list.
> 
> If a flow rule needs to apply rule specific actions list parameters it
> does it with the indirect actions list conf parameter.
> 
> The patch allows flow rule to set meter_mark init_color value when
> meter_mark action was created in indirect actions list.
> 
> Example:
> 
> # create indirect actions list with meter_mark flow action:
> testpmd> flow indirect_action 0 create action_id 10 ingress \  
>   list actions meter_mark mtr_profile 20 \
>   mtr_state 1 mtr_color_mode 1 / end
> 
> # create a flow specific meter_mark init_color configuration:
> testpmd> flow indirect_action 0 create action_id 11 flow_conf \  
>    actions meter_mark_conf mtr_update_init_color red / end
> 
> # queue a flow rule with indirect actions list
> # and flow specific configuration:
> testpmd> flow queue 0 create 0 template_table 1 pattern_template 0 \  
>    actions_template 0 postpone no pattern eth / ipv4 / udp / end \
>    actions indirect_list handle 10 conf 11 / \
>    jump group 10 / end
> 
> cc: stable@dpdk.org
> 
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>

Patches that are cc to stable need a Fixes tag so that stable
maintainers know what to fix.

But this does not look like stable material since it adds new functionality.

Also, current upstream kernel checkpatch doesn't like # as comment

 $ ./devtools/checkpatches.sh 

### [PATCH] testpmd: support meter_mark init_color in indirect list configuration

WARNING:COMMIT_COMMENT_SYMBOL: Commit log lines starting with '#' are dropped by git as comments
#19: 
# create indirect actions list with meter_mark flow action:

WARNING:COMMIT_COMMENT_SYMBOL: Commit log lines starting with '#' are dropped by git as comments
#24: 
# create a flow specific meter_mark init_color configuration:

WARNING:COMMIT_COMMENT_SYMBOL: Commit log lines starting with '#' are dropped by git as comments
#28: 
# queue a flow rule with indirect actions list

WARNING:COMMIT_COMMENT_SYMBOL: Commit log lines starting with '#' are dropped by git as comments
#29: 
# and flow specific configuration:

WARNING:MISSING_FIXES_TAG: The commit message has 'stable@', perhaps it also needs a 'Fixes:' tag?

total: 0 errors, 5 warnings, 111 lines checked