From: Sergio Lopez <slp@redhat.com>
To: virtio-comment@lists.linux.dev
Cc: Sergio Lopez <slp@redhat.com>
Subject: [PATCH 2/3] transport-pci: VIRTIO_F_SHM_PAGE_SIZE support
Date: Mon, 17 Feb 2025 12:52:26 +0100 [thread overview]
Message-ID: <20250217115227.4961-3-slp@redhat.com> (raw)
In-Reply-To: <20250217115227.4961-1-slp@redhat.com>
Introduce VIRTIO_F_SHM_PAGE_SIZE support by borrowing 8 bits from the 16
bit padding in virtio_pci_cap to hold a page_shift field which can be
used to derive the page size supported by the device.
Signed-off-by: Sergio Lopez <slp@redhat.com>
---
transport-pci.tex | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/transport-pci.tex b/transport-pci.tex
index a5c6719..1b91d8a 100644
--- a/transport-pci.tex
+++ b/transport-pci.tex
@@ -147,7 +147,8 @@ \subsection{Virtio Structure PCI Capabilities}\label{sec:Virtio Transport Option
u8 cfg_type; /* Identifies the structure. */
u8 bar; /* Where to find it. */
u8 id; /* Multiple capabilities of the same type */
- u8 padding[2]; /* Pad to full dword. */
+ u8 page_shift; /* Page shift for this shared memory region. */
+ u8 padding[1]; /* Pad to full dword. */
le32 offset; /* Offset within bar. */
le32 length; /* Length of the structure, in bytes. */
};
@@ -222,6 +223,13 @@ \subsection{Virtio Structure PCI Capabilities}\label{sec:Virtio Transport Option
of a certain type. If the device type does not specify the meaning of
this field, its contents are undefined.
+\item[\field{page_shift}]
+ If VIRTIO_F_SHM_PAGE_SIZE has been negotiated and \field{cfg_type} is set
+ to VIRTIO_PCI_CAP_SHARED_MEMORY_CFG, the device MUST provide the page
+ shift derived from the supported page size for this shared memory region.
+ The page shift is derived from the page size by using this formula:
+ $page size = 1 << (page shift + 12)$.
+ See also \ref {sec:Basic Facilities of a Virtio Device / Shared Memory Regions / Page alignment restrictions}.
\item[\field{offset}]
indicates where the structure begins relative to the base address associated
--
2.48.1
next prev parent reply other threads:[~2025-02-17 11:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 11:52 [PATCH 0/3] shared-mem: introduce page alignment restrictions Sergio Lopez
2025-02-17 11:52 ` [PATCH 1/3] " Sergio Lopez
2025-02-23 5:21 ` Parav Pandit
2025-02-26 17:49 ` Sergio Lopez Pascual
2025-03-05 11:18 ` Parav Pandit
2025-03-05 19:08 ` Sergio Lopez Pascual
2025-03-06 3:09 ` Parav Pandit
2025-03-04 10:40 ` Michael S. Tsirkin
2025-03-04 10:52 ` Michael S. Tsirkin
2025-03-04 10:58 ` Parav Pandit
2025-03-04 12:50 ` Michael S. Tsirkin
2025-02-17 11:52 ` Sergio Lopez [this message]
2025-02-17 11:52 ` [PATCH 3/3] transport-mmio: VIRTIO_F_SHM_PAGE_SIZE Sergio Lopez
2025-02-20 2:15 ` [PATCH 0/3] shared-mem: introduce page alignment restrictions Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250217115227.4961-3-slp@redhat.com \
--to=slp@redhat.com \
--cc=virtio-comment@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.