From: Jakub Kicinski <kuba@kernel.org>
To: Pablo Martin Medrano <pablmart@redhat.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH net] selftests/net: big_tcp: make ipv6 testing optional
Date: Mon, 17 Feb 2025 15:04:27 -0800 [thread overview]
Message-ID: <20250217150427.5ab88c70@kernel.org> (raw)
In-Reply-To: <20250217174908.1157168-1-pablmart@redhat.com>
On Mon, 17 Feb 2025 18:49:08 +0100 Pablo Martin Medrano wrote:
> Allow to run this test where IPV6 has not been configured.
nit: You're missing a Signed-off-by tag.
I think this test was added prior to driver selftests.
A better move would be to migrate it to the Python wrappers,
see tools/testing/selftests/drivers/net/*.py
That way it's easier to run it against real HW automatically,
an in SW CI it will be run against netdevsim.
--
pw-bot: cr
prev parent reply other threads:[~2025-02-17 23:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 17:49 [PATCH net] selftests/net: big_tcp: make ipv6 testing optional Pablo Martin Medrano
2025-02-17 23:04 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250217150427.5ab88c70@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablmart@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.