All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Moryakov <ant.v.moryakov@gmail.com>
To: netdev@vger.kernel.org
Cc: Anton Moryakov <ant.v.moryakov@gmail.com>
Subject: [PATCH iproute2-next] ip: remove duplicate condition in ila_csum_name2mode in
Date: Mon, 17 Feb 2025 19:21:52 +0300	[thread overview]
Message-ID: <20250217162153.838113-3-ant.v.moryakov@gmail.com> (raw)
In-Reply-To: <20250217162153.838113-1-ant.v.moryakov@gmail.com>

Static analyzer reported:
expression is identical to previous conditio

Corrections explained:
The condition checking for "neutral-map-auto" was duplicated in the
ila_csum_name2mode function. This commit removes the redundant check
to improve code readability and maintainability.

Triggers found by static analyzer Svace.

Signed-off-by: Anton Moryakov <ant.v.moryakov@gmail.com>

---
 ip/ila_common.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/ip/ila_common.h b/ip/ila_common.h
index f99c2672..cd3524d5 100644
--- a/ip/ila_common.h
+++ b/ip/ila_common.h
@@ -31,8 +31,6 @@ static inline int ila_csum_name2mode(char *name)
 		return ILA_CSUM_NEUTRAL_MAP_AUTO;
 	else if (strcmp(name, "no-action") == 0)
 		return ILA_CSUM_NO_ACTION;
-	else if (strcmp(name, "neutral-map-auto") == 0)
-		return ILA_CSUM_NEUTRAL_MAP_AUTO;
 	else
 		return -1;
 }
-- 
2.30.2


  parent reply	other threads:[~2025-02-17 16:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-17 16:21 [PATCH iproute2-next] ip: check return value of iproute_flush_cache() in irpoute.c Anton Moryakov
2025-02-17 16:21 ` [PATCH iproute2-next] ip: handle NULL return from localtime in strxf_time in Anton Moryakov
2025-02-17 16:21 ` Anton Moryakov [this message]
2025-02-17 16:21 ` [PATCH iproute2-next] lib: remove redundant checks in get_u64 and get_s64 Anton Moryakov
2025-02-19 15:54 ` [PATCH iproute2-next] ip: check return value of iproute_flush_cache() in irpoute.c David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250217162153.838113-3-ant.v.moryakov@gmail.com \
    --to=ant.v.moryakov@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.