From: Jakub Kicinski <kuba@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
David Ahern <dsahern@kernel.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Eric Dumazet <eric.dumazet@gmail.com>,
kuniyu@amazon.co.jp, ushankar@purestorage.com, kuniyu@amazon.com
Subject: Re: [PATCH net v4 1/2] net: Add non-RCU dev_getbyhwaddr() helper
Date: Mon, 17 Feb 2025 16:32:56 -0800 [thread overview]
Message-ID: <20250217163256.491b7990@kernel.org> (raw)
In-Reply-To: <20250213-arm_fix_selftest-v4-1-26714529a6cf@debian.org>
On Thu, 13 Feb 2025 04:42:37 -0800 Breno Leitao wrote:
> +static bool dev_comp_addr(struct net_device *dev, unsigned short type,
sorry for the nit, but: dev_comp_addr() -> dev_addr_cmp() ?
cmp is the typical abbreviation for compare in C
> + * dev_getbyhwaddr - find a device by its hardware address
another tiny nit here: I think ideally there should be a () after the
function name
--
pw-bot: cr
next prev parent reply other threads:[~2025-02-18 0:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 12:42 [PATCH net v4 0/2] net: core: improvements to device lookup by hardware address Breno Leitao
2025-02-13 12:42 ` [PATCH net v4 1/2] net: Add non-RCU dev_getbyhwaddr() helper Breno Leitao
2025-02-14 5:49 ` Kuniyuki Iwashima
2025-02-18 0:32 ` Jakub Kicinski [this message]
2025-02-13 12:42 ` [PATCH net v4 2/2] arp: switch to dev_getbyhwaddr() in arp_req_set_public() Breno Leitao
2025-02-18 0:33 ` Jakub Kicinski
2025-02-18 9:36 ` Breno Leitao
2025-02-18 14:29 ` Jakub Kicinski
2025-02-18 16:27 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250217163256.491b7990@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@kernel.org \
--cc=kuniyu@amazon.co.jp \
--cc=kuniyu@amazon.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ushankar@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.