Re: [PATCH] x86/i8253: Disable PIT timer 0 when not in use

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Feb 17, 2025 at 08:24:34PM +0000, jaywang-amazon wrote:
> From: David Woodhouse <dwmw@amazon.co.uk>
> 
> [upstream commit 70e6b7d9ae3c63df90a7bba7700e8d5c300c360]
> 
> Leaving the PIT interrupt running can cause noticeable steal time for
> virtual guests. The VMM generally has a timer which toggles the IRQ input
> to the PIC and I/O APIC, which takes CPU time away from the guest. Even
> on real hardware, running the counter may use power needlessly (albeit
> not much).
> 
> Make sure it's turned off if it isn't going to be used.
> 
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Tested-by: Michael Kelley <mhkelley@outlook.com>
> Link: https://lore.kernel.org/all/20240802135555.564941-1-dwmw2@infradead.org
> 
> (cherry picked from commit 70e6b7d9ae3c63df90a7bba7700e8d5c300c3c60)
> 
> Cc: stable@vger.kernel.org # v5.15
> 
> Signed-off-by: jaywang-amazon <wanjay@amazon.com>

Why all the blank space here?

And why not cc: all of the people who did this patch on it?

Also your name needs to be fixed up.

Please work with your coworkers on getting this all right so we don't
have to do this type of basic reviewing for you.  All of your recent
backprots suffer from this and can not be taken, sorry.

greg k-h