From: Mario Limonciello <superm1@kernel.org>
To: "Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Mario Limonciello <mario.limonciello@amd.com>,
Perry Yuan <perry.yuan@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org (maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)),
"H . Peter Anvin" <hpa@zytor.com>,
Jonathan Corbet <corbet@lwn.net>, Huang Rui <ray.huang@amd.com>,
"Gautham R . Shenoy" <gautham.shenoy@amd.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
platform-driver-x86@vger.kernel.org (open list:AMD HETERO CORE
HARDWARE FEEDBACK DRIVER),
linux-kernel@vger.kernel.org (open list:X86 ARCHITECTURE (32-BIT
AND 64-BIT)), linux-doc@vger.kernel.org (open list:DOCUMENTATION),
linux-pm@vger.kernel.org (open list:AMD PSTATE DRIVER)
Subject: [PATCH v8 12/13] platform/x86/amd: hfi: Add debugfs support
Date: Tue, 18 Feb 2025 13:08:21 -0600 [thread overview]
Message-ID: <20250218190822.1039982-13-superm1@kernel.org> (raw)
In-Reply-To: <20250218190822.1039982-1-superm1@kernel.org>
From: Mario Limonciello <mario.limonciello@amd.com>
Add a dump of the class and capabilities table to debugfs to assist
with debugging scheduler issues.
Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
---
v8:
* s,for_each_present_cpu,for_each_possible_cpu,
v3:
* Move idx to earlier line
---
drivers/platform/x86/amd/hfi/hfi.c | 35 ++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
diff --git a/drivers/platform/x86/amd/hfi/hfi.c b/drivers/platform/x86/amd/hfi/hfi.c
index 14378a0e09e21..79d065d7b6441 100644
--- a/drivers/platform/x86/amd/hfi/hfi.c
+++ b/drivers/platform/x86/amd/hfi/hfi.c
@@ -13,6 +13,7 @@
#include <linux/acpi.h>
#include <linux/cpu.h>
#include <linux/cpumask.h>
+#include <linux/debugfs.h>
#include <linux/gfp.h>
#include <linux/init.h>
#include <linux/io.h>
@@ -74,6 +75,8 @@ struct amd_hfi_data {
void __iomem *pcc_comm_addr;
struct acpi_subtable_header *pcct_entry;
struct amd_shmem_info *shmem;
+
+ struct dentry *dbgfs_dir;
};
/**
@@ -235,6 +238,13 @@ static int amd_hfi_alloc_class_data(struct platform_device *pdev)
return 0;
}
+static void amd_hfi_remove(struct platform_device *pdev)
+{
+ struct amd_hfi_data *dev = platform_get_drvdata(pdev);
+
+ debugfs_remove_recursive(dev->dbgfs_dir);
+}
+
static int amd_set_hfi_ipcc_score(struct amd_hfi_cpuinfo *hfi_cpuinfo, int cpu)
{
for (int i = 0; i < hfi_cpuinfo->nr_class; i++)
@@ -389,6 +399,26 @@ static int amd_hfi_metadata_parser(struct platform_device *pdev,
return ret;
}
+static int class_capabilities_show(struct seq_file *s, void *unused)
+{
+ int cpu, idx;
+
+ seq_puts(s, "CPU #\tWLC\tPerf\tEff\n");
+ for_each_possible_cpu(cpu) {
+ struct amd_hfi_cpuinfo *hfi_cpuinfo = per_cpu_ptr(&amd_hfi_cpuinfo, cpu);
+
+ seq_printf(s, "%d", cpu);
+ for (idx = 0; idx < hfi_cpuinfo->nr_class; idx++) {
+ seq_printf(s, "\t%d\t%d\t%d\n", idx,
+ hfi_cpuinfo->amd_hfi_classes[idx].perf,
+ hfi_cpuinfo->amd_hfi_classes[idx].eff);
+ }
+ }
+
+ return 0;
+}
+DEFINE_SHOW_ATTRIBUTE(class_capabilities);
+
static int amd_hfi_pm_resume(struct device *dev)
{
int ret, cpu;
@@ -468,6 +498,10 @@ static int amd_hfi_probe(struct platform_device *pdev)
schedule_work(&sched_amd_hfi_itmt_work);
+ amd_hfi_data->dbgfs_dir = debugfs_create_dir("amd_hfi", arch_debugfs_dir);
+ debugfs_create_file("class_capabilities", 0644, amd_hfi_data->dbgfs_dir, pdev,
+ &class_capabilities_fops);
+
return 0;
}
@@ -479,6 +513,7 @@ static struct platform_driver amd_hfi_driver = {
.acpi_match_table = ACPI_PTR(amd_hfi_platform_match),
},
.probe = amd_hfi_probe,
+ .remove = amd_hfi_remove,
};
static int __init amd_hfi_init(void)
--
2.43.0
next prev parent reply other threads:[~2025-02-18 19:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 19:08 [PATCH v8 00/13] Add support for AMD hardware feedback interface Mario Limonciello
2025-02-18 19:08 ` [PATCH v8 01/13] Documentation: x86: Add AMD Hardware Feedback Interface documentation Mario Limonciello
2025-03-19 14:01 ` Ilpo Järvinen
2025-03-20 16:41 ` Mario Limonciello
2025-03-21 13:58 ` Ilpo Järvinen
2025-03-21 14:41 ` Mario Limonciello
2025-02-18 19:08 ` [PATCH v8 02/13] MAINTAINERS: Add maintainer entry for AMD Hardware Feedback Driver Mario Limonciello
2025-02-18 19:08 ` [PATCH v8 03/13] x86/msr-index: define AMD heterogeneous CPU related MSR Mario Limonciello
2025-02-18 19:08 ` [PATCH v8 04/13] platform/x86: hfi: Introduce AMD Hardware Feedback Interface Driver Mario Limonciello
2025-03-19 14:03 ` Ilpo Järvinen
2025-03-20 16:46 ` Mario Limonciello
2025-03-21 14:01 ` Ilpo Järvinen
2025-02-18 19:08 ` [PATCH v8 05/13] platform/x86: hfi: parse CPU core ranking data from shared memory Mario Limonciello
2025-03-19 14:04 ` Ilpo Järvinen
2025-02-18 19:08 ` [PATCH v8 06/13] platform/x86: hfi: init per-cpu scores for each class Mario Limonciello
2025-02-18 19:08 ` [PATCH v8 07/13] platform/x86: hfi: add online and offline callback support Mario Limonciello
2025-03-19 14:04 ` Ilpo Järvinen
2025-02-18 19:08 ` [PATCH v8 08/13] platform/x86: hfi: add power management callback Mario Limonciello
2025-02-18 19:08 ` [PATCH v8 09/13] x86/process: Clear hardware feedback history for AMD processors Mario Limonciello
2025-02-18 19:08 ` [PATCH v8 10/13] cpufreq/amd-pstate: Disable preferred cores on designs with workload classification Mario Limonciello
2025-02-18 19:08 ` [PATCH v8 11/13] platform/x86/amd: hfi: Set ITMT priority from ranking data Mario Limonciello
2025-02-18 19:08 ` Mario Limonciello [this message]
2025-03-19 14:05 ` [PATCH v8 12/13] platform/x86/amd: hfi: Add debugfs support Ilpo Järvinen
2025-02-18 19:08 ` [PATCH v8 13/13] x86/itmt: Add debugfs file to show core priorities Mario Limonciello
2025-03-20 22:42 ` [PATCH v8 00/13] Add support for AMD hardware feedback interface Christian Loehle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250218190822.1039982-13-superm1@kernel.org \
--to=superm1@kernel.org \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=gautham.shenoy@amd.com \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=perry.yuan@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.