All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Maxime Chevallier <maxime.chevallier@bootlin.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	thomas.petazzoni@bootlin.com, "Andrew Lunn" <andrew@lunn.ch>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Eric Dumazet" <edumazet@google.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Russell King" <linux@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	"Christophe Leroy" <christophe.leroy@csgroup.eu>,
	"Herve Codina" <herve.codina@bootlin.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Vladimir Oltean" <vladimir.oltean@nxp.com>,
	"Köry Maincent" <kory.maincent@bootlin.com>,
	"Marek Behún" <kabel@kernel.org>,
	"Oleksij Rempel" <o.rempel@pengutronix.de>,
	"Nicolò Veronese" <nicveronese@gmail.com>,
	"Simon Horman" <horms@kernel.org>,
	mwojtas@chromium.org, "Antoine Tenart" <atenart@kernel.org>,
	devicetree@vger.kernel.org, "Conor Dooley" <conor+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Romain Gantois" <romain.gantois@bootlin.com>,
	"Daniel Golle" <daniel@makrotopia.org>,
	"Dimitri Fedrau" <dimitri.fedrau@liebherr.com>,
	"Sean Anderson" <seanga2@gmail.com>
Subject: Re: [PATCH net-next v4 15/15] dt-bindings: net: Introduce the phy-port description
Date: Wed, 19 Feb 2025 16:35:30 -0600	[thread overview]
Message-ID: <20250219223530.GA3083990-robh@kernel.org> (raw)
In-Reply-To: <20250213101606.1154014-16-maxime.chevallier@bootlin.com>

On Thu, Feb 13, 2025 at 11:16:03AM +0100, Maxime Chevallier wrote:
> The ability to describe the physical ports of Ethernet devices is useful
> to describe multi-port devices, as well as to remove any ambiguity with
> regard to the nature of the port.
> 
> Moreover, describing ports allows for a better description of features
> that are tied to connectors, such as PoE through the PSE-PD devices.
> 
> Introduce a binding to allow describing the ports, for now with 2
> attributes :
> 
>  - The number of lanes, which is a quite generic property that allows
>    differentating between multiple similar technologies such as BaseT1
>    and "regular" BaseT (which usually means BaseT4).
> 
>  - The media that can be used on that port, such as BaseT for Twisted
>    Copper, BaseC for coax copper, BaseS/L for Fiber, BaseK for backplane
>    ethernet, etc. This allows defining the nature of the port, and
>    therefore avoids the need for vendor-specific properties such as
>    "micrel,fiber-mode" or "ti,fiber-mode".
> 
> The port description lives in its own file, as it is intended in the
> future to allow describing the ports for phy-less devices.
> 
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> ---
> V4: no changes
> 
>  .../devicetree/bindings/net/ethernet-phy.yaml | 18 +++++++
>  .../bindings/net/ethernet-port.yaml           | 47 +++++++++++++++++++
>  MAINTAINERS                                   |  1 +
>  3 files changed, 66 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/ethernet-port.yaml

Seems my comments on v2 were ignored. Those issues remain.


  reply	other threads:[~2025-02-19 22:37 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-13 10:15 [PATCH net-next v4 00/15] Introduce an ethernet port representation Maxime Chevallier
2025-02-13 10:15 ` [PATCH net-next v4 01/15] net: ethtool: Introduce ETHTOOL_LINK_MEDIUM_* values Maxime Chevallier
2025-02-13 10:15 ` [PATCH net-next v4 02/15] net: ethtool: Export the link_mode_params definitions Maxime Chevallier
2025-02-13 10:15 ` [PATCH net-next v4 03/15] net: phy: Introduce PHY ports representation Maxime Chevallier
2025-02-13 10:15 ` [PATCH net-next v4 04/15] net: phy: dp83822: Add support for phy_port representation Maxime Chevallier
2025-02-15 11:31   ` AW: " Fedrau Dimitri (LED)
2025-02-17  9:26     ` Maxime Chevallier
2025-02-13 10:15 ` [PATCH net-next v4 05/15] net: phy: Create a phy_port for PHY-driven SFPs Maxime Chevallier
2025-02-15 18:57   ` Russell King (Oracle)
2025-02-17  8:29     ` Maxime Chevallier
2025-02-17 13:43       ` Andrew Lunn
2025-02-17 14:22         ` Maxime Chevallier
2025-02-17 15:29           ` Andrew Lunn
2025-02-17 14:21       ` Russell King (Oracle)
2025-02-17 14:49         ` Maxime Chevallier
2025-02-13 10:15 ` [PATCH net-next v4 06/15] net: phy: Introduce generic SFP handling for PHY drivers Maxime Chevallier
2025-02-13 10:15 ` [PATCH net-next v4 07/15] net: phy: marvell-88x2222: Support SFP through phy_port interface Maxime Chevallier
2025-02-13 10:15 ` [PATCH net-next v4 08/15] net: phy: marvell: " Maxime Chevallier
2025-02-13 10:15 ` [PATCH net-next v4 09/15] net: phy: marvell10g: Support SFP through phy_port Maxime Chevallier
2025-02-13 10:15 ` [PATCH net-next v4 10/15] net: phy: at803x: Support SFP through phy_port interface Maxime Chevallier
2025-02-13 10:15 ` [PATCH net-next v4 11/15] net: phy: qca807x: " Maxime Chevallier
2025-02-13 10:16 ` [PATCH net-next v4 12/15] net: phy: Only rely on phy_port for PHY-driven SFP Maxime Chevallier
2025-02-13 10:16 ` [PATCH net-next v4 13/15] net: phy: dp83822: Add SFP support through the phy_port interface Maxime Chevallier
2025-02-13 10:16 ` [PATCH net-next v4 14/15] Documentation: networking: Document the phy_port infrastructure Maxime Chevallier
2025-02-13 10:16 ` [PATCH net-next v4 15/15] dt-bindings: net: Introduce the phy-port description Maxime Chevallier
2025-02-19 22:35   ` Rob Herring [this message]
2025-02-20  8:35     ` Maxime Chevallier
2025-02-15  0:53 ` [PATCH net-next v4 00/15] Introduce an ethernet port representation Jakub Kicinski
2025-02-17  9:20   ` Maxime Chevallier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250219223530.GA3083990-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=atenart@kernel.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=conor+dt@kernel.org \
    --cc=daniel@makrotopia.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dimitri.fedrau@liebherr.com \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=herve.codina@bootlin.com \
    --cc=hkallweit1@gmail.com \
    --cc=horms@kernel.org \
    --cc=kabel@kernel.org \
    --cc=kory.maincent@bootlin.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maxime.chevallier@bootlin.com \
    --cc=mwojtas@chromium.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicveronese@gmail.com \
    --cc=o.rempel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=romain.gantois@bootlin.com \
    --cc=seanga2@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.