From: Maxime Ripard <mripard@kernel.org>
To: oushixiong1025@163.com
Cc: Liviu Dudau <liviu.dudau@arm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Shixiong Ou <oushixiong@kylinos.cn>
Subject: Re: [PATCH] drm/arm/komeda: Add a condition check before removing sysfs attribute
Date: Thu, 20 Feb 2025 10:12:01 +0100 [thread overview]
Message-ID: <20250220-tiny-pragmatic-pug-5addfc@houat> (raw)
In-Reply-To: <20250220085358.232883-1-oushixiong1025@163.com>
[-- Attachment #1: Type: text/plain, Size: 513 bytes --]
On Thu, Feb 20, 2025 at 04:53:58PM +0800, oushixiong1025@163.com wrote:
> From: Shixiong Ou <oushixiong@kylinos.cn>
>
> [WHY] If the call to sysfs_create_group() fails, there is
> no need to call function sysfs_remove_group().
>
> [HOW] Add a condition check before removing sysfs attribute.
>
> Signed-off-by: Shixiong Ou <oushixiong@kylinos.cn>
What are you trying to fix exactly? AFAIK, there's no code path that
calls komeda_dev_destroy() after komeda_dev_create() has failed.
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]
next prev parent reply other threads:[~2025-02-20 9:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 8:53 [PATCH] drm/arm/komeda: Add a condition check before removing sysfs attribute oushixiong1025
2025-02-20 9:12 ` Maxime Ripard [this message]
2025-02-20 9:20 ` Shixiong Ou
2025-02-20 9:43 ` Maxime Ripard
2025-02-25 10:28 ` Liviu Dudau
2025-02-26 2:52 ` Shixiong Ou
2025-02-27 10:59 ` Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220-tiny-pragmatic-pug-5addfc@houat \
--to=mripard@kernel.org \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=oushixiong1025@163.com \
--cc=oushixiong@kylinos.cn \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.