From: Simon Horman <horms@kernel.org>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] skbuff: kill skb_flow_get_ports()
Date: Thu, 20 Feb 2025 10:54:19 +0000 [thread overview]
Message-ID: <20250220105419.GT1615191@kernel.org> (raw)
In-Reply-To: <20250218143717.3580605-1-nicolas.dichtel@6wind.com>
On Tue, Feb 18, 2025 at 03:37:17PM +0100, Nicolas Dichtel wrote:
> This function is not used anymore.
>
> Fixes: a815bde56b15 ("net, bonding: Refactor bond_xmit_hash for use with xdp_buff")
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Reviewed-by: Simon Horman <horms@kernel.org>
I guess the churn isn't worth it, but it seems to me that
__skb_flow_get_ports could be renamed skb_flow_get_ports.
...
next prev parent reply other threads:[~2025-02-20 10:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 14:37 [PATCH net-next] skbuff: kill skb_flow_get_ports() Nicolas Dichtel
2025-02-20 10:54 ` Simon Horman [this message]
2025-02-20 13:02 ` Nicolas Dichtel
2025-02-20 13:15 ` Maciej Fijalkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220105419.GT1615191@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.