Re: [PATCH v4 00/10] enable "app" to be compiled with MSVC

[Stephen Hemminger <stephen@networkplumber.org>]

On Thu, 20 Feb 2025 13:30:54 -0800
Andre Muezerie <andremue@linux.microsoft.com> wrote:

> v4:
> - add explanation about the expression used in __rte_constant during v3.
> 
> v3:
> - use clever expression with _Generic for __rte_constant and use it
>   where __builtin_constant_p was being used.
> - use %u in csumonly.c and just cast variables to unsigned int.
> 
> v2:
> - use lcore_count as atomic always, not only when RTE_USE_C11_MEM_MODEL
>   is set.
> - use PRIu64 in csumonly.c instead of casting variables to int.
> 
> This series fixes many issues that prevent the "app" directory
> from being compiled with MSVC.
> 
> Andre Muezerie (10):
>   eal: add workaround for __builtin_constant_p
>   test_alarm: avoid warning about different qualifiers
>   test-pmd: fix printf format string mismatch
>   test-pmd: do explicit 64-bit shift to avoid implicit conversion
>   test-pmd: avoid undefined behavior
>   test-pmd: avoid non-constant initializer
>   test-pmd: don't return value from void function
>   test-pmd: declare lcore_count atomic
>   test: add workaround for __builtin_constant_p in test_memcpy_perf
>   app: enable app directory to be compiled with MSVC
> 
>  app/meson.build                     |  4 ---
>  app/test-pmd/cmdline.c              | 16 +++++----
>  app/test-pmd/cmdline_flow.c         | 22 ++++++------
>  app/test-pmd/csumonly.c             | 23 ++++++------
>  app/test-pmd/meson.build            |  1 -
>  app/test-pmd/testpmd.c              |  2 +-
>  app/test-pmd/testpmd.h              |  2 ++
>  app/test-pmd/util.c                 |  2 +-
>  app/test/test_alarm.c               | 12 +++----
>  app/test/test_memcpy_perf.c         | 54 ++++++++++++++---------------
>  app/test/test_ring_perf.c           |  6 +---
>  lib/eal/include/generic/rte_pause.h |  2 +-
>  lib/eal/include/rte_common.h        | 34 +++++++++++++++++-
>  13 files changed, 105 insertions(+), 75 deletions(-)
> 
> --
> 2.48.1.vfs.0.0
> 

Series-Acked-by: Stephen Hemminger <stephen@networkplumber.org>