From: Jakub Kicinski <kuba@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<andrew+netdev@lunn.ch>, <horms@kernel.org>,
<shenjian15@huawei.com>, <wangpeiyang1@huawei.com>,
<liuyonglong@huawei.com>, <chenhao418@huawei.com>,
<sudongming1@huawei.com>, <xujunsheng@huawei.com>,
<shiyongbang@huawei.com>, <libaihan@huawei.com>,
<jonathan.cameron@huawei.com>,
<shameerali.kolothum.thodi@huawei.com>, <salil.mehta@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 net-next 1/6] net: hibmcge: Add dump statistics supported in this module
Date: Thu, 20 Feb 2025 15:17:10 -0800 [thread overview]
Message-ID: <20250220151710.78f4893f@kernel.org> (raw)
In-Reply-To: <20250218085829.3172126-2-shaojijie@huawei.com>
On Tue, 18 Feb 2025 16:58:24 +0800 Jijie Shao wrote:
> Subject: [PATCH v2 net-next 1/6] net: hibmcge: Add dump statistics supported in this module
In addition to addressing my comment about fix_features please
also remove the "in this module" from all patch titles.
Other than that code LGTM.
next prev parent reply other threads:[~2025-02-20 23:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 8:58 [PATCH v2 net-next 0/6] Support some enhances features for the HIBMCGE driver Jijie Shao
2025-02-18 8:58 ` [PATCH v2 net-next 1/6] net: hibmcge: Add dump statistics supported in this module Jijie Shao
2025-02-20 23:17 ` Jakub Kicinski [this message]
2025-02-21 11:34 ` Jijie Shao
2025-02-18 8:58 ` [PATCH v2 net-next 2/6] net: hibmcge: Add rx checksum offload " Jijie Shao
2025-02-20 23:11 ` Jakub Kicinski
2025-02-21 11:34 ` Jijie Shao
2025-02-18 8:58 ` [PATCH v2 net-next 3/6] net: hibmcge: Add abnormal irq handling feature " Jijie Shao
2025-02-18 8:58 ` [PATCH v2 net-next 4/6] net: hibmcge: Add mac link exception " Jijie Shao
2025-02-18 8:58 ` [PATCH v2 net-next 5/6] net: hibmcge: Add BMC diagnose " Jijie Shao
2025-02-18 8:58 ` [PATCH v2 net-next 6/6] net: hibmcge: Add ioctl supported " Jijie Shao
2025-02-18 15:44 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220151710.78f4893f@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=libaihan@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=shiyongbang@huawei.com \
--cc=sudongming1@huawei.com \
--cc=wangpeiyang1@huawei.com \
--cc=xujunsheng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.