From: Petr Vorel <pvorel@suse.cz>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: linux-integrity@vger.kernel.org, roberto.sassu@huawei.com,
Stefan Berger <stefanb@linux.ibm.com>
Subject: Re: [PATCH 1/2] ima: limit the number of open-writers integrity violations
Date: Thu, 20 Feb 2025 19:26:28 +0100 [thread overview]
Message-ID: <20250220182628.GB2709977@pevik> (raw)
In-Reply-To: <20250219162131.416719-2-zohar@linux.ibm.com>
Hi Mimi,
> Each time a file in policy, that is already opened for write, is opened
> for read an open-writers integrity violation audit message is emitted
> and a violation record is added to the IMA measurement list, even if an
> open-writers violation has already been recorded.
> Limit the number of open-writers integrity violations for an existing
> file open for write to one. After the existing file open for write
> closes (__fput), subsequent open-writers integrity violations may occur.
LGTM.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
I also did a regression testing on LTP IMA tests on x86_64, aarch64, ppc64le.
(not testing the feature itself, just really a very basic regression testing,
therefore I do not dare to add my TBT).
Kind regards,
Petr
next prev parent reply other threads:[~2025-02-20 18:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 16:21 [PATCH 0/2] ima: limit both open-writers and ToMToU violations Mimi Zohar
2025-02-19 16:21 ` [PATCH 1/2] ima: limit the number of open-writers integrity violations Mimi Zohar
2025-02-20 15:24 ` Stefan Berger
2025-02-20 18:26 ` Petr Vorel [this message]
2025-02-21 8:18 ` Petr Vorel
2025-02-21 16:56 ` Roberto Sassu
2025-02-19 16:21 ` [PATCH 2/2] ima: limit the number of ToMToU " Mimi Zohar
2025-02-20 15:24 ` Stefan Berger
2025-02-20 18:27 ` Petr Vorel
2025-02-21 8:18 ` Petr Vorel
2025-02-21 17:36 ` Roberto Sassu
2025-02-26 19:19 ` Mimi Zohar
2025-02-27 8:34 ` Roberto Sassu
2025-02-21 16:49 ` [PATCH 0/2] ima: limit both open-writers and ToMToU violations Roberto Sassu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220182628.GB2709977@pevik \
--to=pvorel@suse.cz \
--cc=linux-integrity@vger.kernel.org \
--cc=roberto.sassu@huawei.com \
--cc=stefanb@linux.ibm.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.