From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: linux-kernel@vger.kernel.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
dri-devel@lists.freedesktop.org,
Danilo Krummrich <dakr@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH 2/6] drivers: base: devres: Fix find_group() documentation
Date: Thu, 20 Feb 2025 13:24:37 +0100 [thread overview]
Message-ID: <2025022033-struck-employee-1960@gregkh> (raw)
In-Reply-To: <20250212200542.515493-3-lucas.demarchi@intel.com>
On Wed, Feb 12, 2025 at 12:05:38PM -0800, Lucas De Marchi wrote:
> It returns the last open group, not the last group.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
> drivers/base/devres.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/base/devres.c b/drivers/base/devres.c
> index b955a2f9520bf..d8a733ea5e1ac 100644
> --- a/drivers/base/devres.c
> +++ b/drivers/base/devres.c
> @@ -576,7 +576,10 @@ void *devres_open_group(struct device *dev, void *id, gfp_t gfp)
> }
> EXPORT_SYMBOL_GPL(devres_open_group);
>
> -/* Find devres group with ID @id. If @id is NULL, look for the latest. */
> +/*
> + * Find devres group with ID @id. If @id is NULL, look for the latest open
> + * group.
> + */
> static struct devres_group *find_group(struct device *dev, void *id)
> {
> struct devres_node *node;
> --
> 2.48.1
>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2025-02-20 12:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 20:05 [PATCH 0/6] Make devres cleanup and component compatible Lucas De Marchi
2025-02-12 20:05 ` [PATCH 1/6] drivers: base: devres: Allow to release group on device release Lucas De Marchi
2025-02-20 12:24 ` Greg Kroah-Hartman
2025-02-20 23:48 ` Lucas De Marchi
2025-02-21 5:57 ` Greg Kroah-Hartman
2025-02-12 20:05 ` [PATCH 2/6] drivers: base: devres: Fix find_group() documentation Lucas De Marchi
2025-02-20 12:24 ` Greg Kroah-Hartman [this message]
2025-02-12 20:05 ` [PATCH 3/6] drivers: base: component: Add debug message for unbind Lucas De Marchi
2025-02-20 12:24 ` Greg Kroah-Hartman
2025-02-12 20:05 ` [PATCH 4/6] drm/xe: Stop setting drvdata to NULL Lucas De Marchi
2025-02-12 20:05 ` [PATCH 5/6] drm/xe: Switch from xe to devm actions Lucas De Marchi
2025-02-12 20:05 ` [PATCH 6/6] drm/xe: Drop remove callback support Lucas De Marchi
2025-02-21 18:10 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025022033-struck-employee-1960@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=rafael@kernel.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.