From: Aurelien Aptel <aaptel@nvidia.com>
To: linux-nvme@lists.infradead.org, netdev@vger.kernel.org,
sagi@grimberg.me, hch@lst.de, kbusch@kernel.org, axboe@fb.com,
chaitanyak@nvidia.com, davem@davemloft.net, kuba@kernel.org
Cc: Boris Pismenny <borisp@nvidia.com>,
aaptel@nvidia.com, aurelien.aptel@gmail.com, smalin@nvidia.com,
malin1024@gmail.com, ogerlitz@nvidia.com, yorayz@nvidia.com,
galshalom@nvidia.com, mgurtovoy@nvidia.com
Subject: [PATCH v26 14/20] net/mlx5e: TCP flow steering for nvme-tcp acceleration
Date: Fri, 21 Feb 2025 09:52:19 +0000 [thread overview]
Message-ID: <20250221095225.2159-15-aaptel@nvidia.com> (raw)
In-Reply-To: <20250221095225.2159-1-aaptel@nvidia.com>
From: Boris Pismenny <borisp@nvidia.com>
Both nvme-tcp and tls acceleration require tcp flow steering.
Add reference counter to share TCP flow steering structure.
Signed-off-by: Boris Pismenny <borisp@nvidia.com>
Signed-off-by: Ben Ben-Ishay <benishay@nvidia.com>
Signed-off-by: Or Gerlitz <ogerlitz@nvidia.com>
Signed-off-by: Yoray Zack <yorayz@nvidia.com>
Signed-off-by: Aurelien Aptel <aaptel@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
---
.../ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c
index 4f83e3172767..f5c67f9cb2f9 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c
@@ -14,6 +14,7 @@ enum accel_fs_tcp_type {
struct mlx5e_accel_fs_tcp {
struct mlx5e_flow_table tables[ACCEL_FS_TCP_NUM_TYPES];
struct mlx5_flow_handle *default_rules[ACCEL_FS_TCP_NUM_TYPES];
+ refcount_t user_count;
};
static enum mlx5_traffic_types fs_accel2tt(enum accel_fs_tcp_type i)
@@ -361,6 +362,9 @@ void mlx5e_accel_fs_tcp_destroy(struct mlx5e_flow_steering *fs)
if (!accel_tcp)
return;
+ if (!refcount_dec_and_test(&accel_tcp->user_count))
+ return;
+
accel_fs_tcp_disable(fs);
for (i = 0; i < ACCEL_FS_TCP_NUM_TYPES; i++)
@@ -372,12 +376,17 @@ void mlx5e_accel_fs_tcp_destroy(struct mlx5e_flow_steering *fs)
int mlx5e_accel_fs_tcp_create(struct mlx5e_flow_steering *fs)
{
- struct mlx5e_accel_fs_tcp *accel_tcp;
+ struct mlx5e_accel_fs_tcp *accel_tcp = mlx5e_fs_get_accel_tcp(fs);
int i, err;
if (!MLX5_CAP_FLOWTABLE_NIC_RX(mlx5e_fs_get_mdev(fs), ft_field_support.outer_ip_version))
return -EOPNOTSUPP;
+ if (accel_tcp) {
+ refcount_inc(&accel_tcp->user_count);
+ return 0;
+ }
+
accel_tcp = kzalloc(sizeof(*accel_tcp), GFP_KERNEL);
if (!accel_tcp)
return -ENOMEM;
@@ -393,6 +402,7 @@ int mlx5e_accel_fs_tcp_create(struct mlx5e_flow_steering *fs)
if (err)
goto err_destroy_tables;
+ refcount_set(&accel_tcp->user_count, 1);
return 0;
err_destroy_tables:
--
2.34.1
next prev parent reply other threads:[~2025-02-21 10:08 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 9:52 [PATCH v26 00/20] nvme-tcp receive offloads Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 01/20] net: Introduce direct data placement tcp offload Aurelien Aptel
2025-02-25 10:23 ` Paolo Abeni
2025-02-25 13:34 ` Aurelien Aptel
2025-02-25 17:15 ` Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 02/20] netlink: add new family to manage ULP_DDP enablement and stats Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 03/20] iov_iter: skip copy if src == dst for direct data placement Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 04/20] net/tls,core: export get_netdev_for_sock Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 05/20] nvme-tcp: Add DDP offload control path Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 06/20] nvme-tcp: Add DDP data-path Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 07/20] nvme-tcp: RX DDGST offload Aurelien Aptel
2025-02-25 10:42 ` Paolo Abeni
2025-02-25 13:34 ` Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 08/20] nvme-tcp: Deal with netdevice DOWN events Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 09/20] Documentation: add ULP DDP offload documentation Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 10/20] net/mlx5e: Rename from tls to transport static params Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 11/20] net/mlx5e: Refactor ico sq polling to get budget Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 12/20] net/mlx5: Add NVMEoTCP caps, HW bits, 128B CQE and enumerations Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 13/20] net/mlx5e: NVMEoTCP, offload initialization Aurelien Aptel
2025-02-21 9:52 ` Aurelien Aptel [this message]
2025-02-21 9:52 ` [PATCH v26 15/20] net/mlx5e: NVMEoTCP, use KLM UMRs for buffer registration Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 16/20] net/mlx5e: NVMEoTCP, queue init/teardown Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 17/20] net/mlx5e: NVMEoTCP, ddp setup and resync Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 18/20] net/mlx5e: NVMEoTCP, async ddp invalidation Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 19/20] net/mlx5e: NVMEoTCP, data-path for DDP+DDGST offload Aurelien Aptel
2025-02-21 9:52 ` [PATCH v26 20/20] net/mlx5e: NVMEoTCP, statistics Aurelien Aptel
2025-02-25 10:12 ` [PATCH v26 00/20] nvme-tcp receive offloads Paolo Abeni
2025-02-25 13:38 ` Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250221095225.2159-15-aaptel@nvidia.com \
--to=aaptel@nvidia.com \
--cc=aurelien.aptel@gmail.com \
--cc=axboe@fb.com \
--cc=borisp@nvidia.com \
--cc=chaitanyak@nvidia.com \
--cc=davem@davemloft.net \
--cc=galshalom@nvidia.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=malin1024@gmail.com \
--cc=mgurtovoy@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@nvidia.com \
--cc=sagi@grimberg.me \
--cc=smalin@nvidia.com \
--cc=yorayz@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.