From: Jakub Kicinski <kuba@kernel.org>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: ti: am65-cpsw: select PAGE_POOL
Date: Fri, 21 Feb 2025 16:16:13 -0800 [thread overview]
Message-ID: <20250221161613.67fe279f@kernel.org> (raw)
In-Reply-To: <20250220-net-am654-nuss-kconfig-v1-1-acc813b769de@pengutronix.de>
On Thu, 20 Feb 2025 09:43:06 +0100 Sascha Hauer wrote:
> am65-cpsw uses page_pool_dev_alloc_pages(), thus needs PAGE_POOL
> selected to avoid linker errors.
If it can actually result in linker errors today could you add a Fixes
tag pointing to the commit that added the dependency?
If it can't (perhaps one of the many already selected symbols already
implies PAGE_POOL?) could you explain in the commit msg?
--
pw-bot: cr
next prev parent reply other threads:[~2025-02-22 0:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 8:43 [PATCH] net: ethernet: ti: am65-cpsw: select PAGE_POOL Sascha Hauer
2025-02-22 0:16 ` Jakub Kicinski [this message]
2025-02-24 5:28 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250221161613.67fe279f@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.