From: Nathan Chancellor <nathan@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Nicolas Schier <nicolas@fjasle.eu>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH] kbuild: hdrcheck: fix cross build with clang
Date: Fri, 21 Feb 2025 13:26:03 -0800 [thread overview]
Message-ID: <20250221212603.GA3561672@ax162> (raw)
In-Reply-To: <20250221212017.809382-1-arnd@kernel.org>
On Fri, Feb 21, 2025 at 10:20:07PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The headercheck tries to call clang with a mix of compiler arguments
> that don't include the target architecture. When building e.g. x86
> headers on arm64, this produces a warning like
>
> clang: warning: unknown platform, assuming -mfloat-abi=soft
>
> Add in the CLANG_FLAGS, which contain the target, in order to make it
> build properly.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This looks like a similar problem as the one fixed by
commit 1b71c2fb04e7 ("kbuild: userprogs: fix bitsize and target
detection on clang"), should it be addressed in the same manner
(especially since I think the Fixes commit would be the same)? Given
that the filter expression is the same, maybe it would be possible to
unify them but that could happen as a follow up.
> ---
> usr/include/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/usr/include/Makefile b/usr/include/Makefile
> index 58a9cbe4eba4..99f9e904adcd 100644
> --- a/usr/include/Makefile
> +++ b/usr/include/Makefile
> @@ -10,7 +10,7 @@ UAPI_CFLAGS := -std=c90 -Wall -Werror=implicit-function-declaration
>
> # In theory, we do not care -m32 or -m64 for header compile tests.
> # It is here just because CONFIG_CC_CAN_LINK is tested with -m32 or -m64.
> -UAPI_CFLAGS += $(filter -m32 -m64 --target=%, $(KBUILD_CFLAGS))
> +UAPI_CFLAGS += $(filter -m32 -m64 --target=%, $(KBUILD_CFLAGS) $(CLANG_FLAGS))
>
> # USERCFLAGS might contain sysroot location for CC.
> UAPI_CFLAGS += $(USERCFLAGS)
> --
> 2.39.5
>
next prev parent reply other threads:[~2025-02-21 21:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 21:20 [PATCH] kbuild: hdrcheck: fix cross build with clang Arnd Bergmann
2025-02-21 21:26 ` Nathan Chancellor [this message]
2025-02-21 21:39 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250221212603.GA3561672@ax162 \
--to=nathan@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=geert+renesas@glider.be \
--cc=justinstitt@google.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=morbo@google.com \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nicolas@fjasle.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.