From: Rob Herring <robh@kernel.org>
To: Xu Yang <xu.yang_2@nxp.com>
Cc: Frank Li <Frank.li@nxp.com>,
gregkh@linuxfoundation.org, krzk+dt@kernel.org,
conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, peter.chen@kernel.org,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, jun.li@nxp.com
Subject: Re: [PATCH 2/6] dt-bindings: usb: usbmisc-imx: add compatible for i.MX95 platform
Date: Fri, 21 Feb 2025 15:49:02 -0600 [thread overview]
Message-ID: <20250221214902.GA128391-robh@kernel.org> (raw)
In-Reply-To: <20250220103209.zm4bvkkjtgewd53y@hippo>
On Thu, Feb 20, 2025 at 06:32:09PM +0800, Xu Yang wrote:
> On Wed, Feb 19, 2025 at 01:01:30PM -0500, Frank Li wrote:
> > On Wed, Feb 19, 2025 at 05:31:00PM +0800, Xu Yang wrote:
> > > The i.MX95 USB2.0 controller is basically compatible with i.MX7D,
> > > except it needs use hsio block control for wakeup setting. This will
> > > add compatible for i.MX95 platform and restriciton on reg property.
> >
> > Nit: Simple said
> > Add compatible ...
> >
> > Better mention "fsl,imx95-usbmisc" at subject.
> > add compatible string "fsl,imx95-usbmisc" for ...
The patch does a bit more than just add a compatible. 'Add i.MX95
support' is really enough. The diff is clear it is adding a compatible.
Rob
next prev parent reply other threads:[~2025-02-21 21:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 9:30 [PATCH 0/6] add USB2.0 support for i.MX95-19x19 EVK board Xu Yang
2025-02-19 9:30 ` [PATCH 1/6] dt-bindings: usb: chipidea: add compatible for i.MX95 platform Xu Yang
2025-02-19 17:58 ` Frank Li
2025-02-20 10:22 ` Xu Yang
2025-02-19 9:31 ` [PATCH 2/6] dt-bindings: usb: usbmisc-imx: " Xu Yang
2025-02-19 18:01 ` Frank Li
2025-02-20 10:32 ` Xu Yang
2025-02-21 21:49 ` Rob Herring [this message]
2025-02-19 9:31 ` [PATCH 3/6] usb: chipidea: imx: add wakeup interrupt handling Xu Yang
2025-02-19 20:26 ` Frank Li
2025-02-21 3:23 ` Xu Yang
2025-02-21 15:23 ` Frank Li
2025-02-24 11:07 ` Xu Yang
2025-02-24 15:58 ` Frank Li
2025-02-25 2:12 ` Xu Yang
2025-02-19 9:31 ` [PATCH 4/6] usb: chipidea: imx: add HSIO Block Control wakup setting Xu Yang
2025-02-19 20:35 ` Frank Li
2025-02-19 9:31 ` [PATCH 5/6] arm64: dts: imx95: add USB2.0 nodes Xu Yang
2025-02-19 20:37 ` Frank Li
2025-02-19 9:31 ` [PATCH 6/6] arm64: dts: imx95-19x19-evk: enable USB2.0 node Xu Yang
2025-02-19 20:39 ` Frank Li
2025-02-20 10:38 ` Xu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250221214902.GA128391-robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.