From: Al Viro <viro@zeniv.linux.org.uk>
To: Miklos Szeredi <mszeredi@redhat.com>
Cc: linux-fsdevel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>,
Bernd Schubert <bernd.schubert@fastmail.fm>,
Laura Promberger <laura.promberger@cern.ch>,
Sam Lewis <samclewis@google.com>
Subject: Re: [PATCH] fuse: don't truncate cached, mutated symlink
Date: Sun, 23 Feb 2025 00:28:21 +0000 [thread overview]
Message-ID: <20250223002821.GR1977892@ZenIV> (raw)
In-Reply-To: <20250220100258.793363-1-mszeredi@redhat.com>
On Thu, Feb 20, 2025 at 11:02:58AM +0100, Miklos Szeredi wrote:
> The solution is to just remove this truncation. This can cause a
> regression in a filesystem that relies on supplying a symlink larger than
> the file size, but this is unlikely. If that happens we'd need to make
> this behavior conditional.
Note, BTW, that page *contents* must not change at all, so truncation is
only safe if we have ->i_size guaranteed to be stable.
Core pathwalk really counts upon the string remaining immutable, and that
does include the string returned by ->get_link().
next prev parent reply other threads:[~2025-02-23 0:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-20 10:02 [PATCH] fuse: don't truncate cached, mutated symlink Miklos Szeredi
2025-02-20 10:26 ` Bernd Schubert
2025-02-20 14:48 ` Christian Brauner
2025-02-21 10:38 ` Luis Henriques
2025-02-23 0:28 ` Al Viro [this message]
2025-02-23 19:12 ` Miklos Szeredi
2025-02-23 19:41 ` Al Viro
2025-02-25 13:01 ` Laura Promberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250223002821.GR1977892@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=bernd.schubert@fastmail.fm \
--cc=brauner@kernel.org \
--cc=laura.promberger@cern.ch \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=samclewis@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.