From: Ido Schimmel <idosch@nvidia.com>
To: <netdev@vger.kernel.org>
Cc: <stephen@networkplumber.org>, <dsahern@gmail.com>,
<gnault@redhat.com>, <petrm@nvidia.com>,
Ido Schimmel <idosch@nvidia.com>
Subject: [PATCH iproute2-next 3/5] iprule: Allow specifying ports in hexadecimal notation
Date: Mon, 24 Feb 2025 08:52:38 +0200 [thread overview]
Message-ID: <20250224065241.236141-4-idosch@nvidia.com> (raw)
In-Reply-To: <20250224065241.236141-1-idosch@nvidia.com>
This will be useful when enabling port masks in the next patch.
Before:
# ip rule add sport 0x1 table 100
Invalid "sport"
After:
# ip rule add sport 0x1 table 100
$ ip rule show sport 0x1
32765: from all sport 1 lookup 100
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
ip/iprule.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/ip/iprule.c b/ip/iprule.c
index 61e092bc5693..64d389bebb76 100644
--- a/ip/iprule.c
+++ b/ip/iprule.c
@@ -608,16 +608,16 @@ static void iprule_port_parse(char *arg, struct fib_rule_port_range *r)
if (sep) {
*sep = '\0';
- if (get_u16(&r->start, arg, 10))
+ if (get_u16(&r->start, arg, 0))
invarg("invalid port range start", arg);
- if (get_u16(&r->end, sep + 1, 10))
+ if (get_u16(&r->end, sep + 1, 0))
invarg("invalid port range end", sep + 1);
return;
}
- if (get_u16(&r->start, arg, 10))
+ if (get_u16(&r->start, arg, 0))
invarg("invalid port", arg);
r->end = r->start;
--
2.48.1
next prev parent reply other threads:[~2025-02-24 6:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-24 6:52 [PATCH iproute2-next 0/5] iprule: Add mask support for L4 ports and DSCP Ido Schimmel
2025-02-24 6:52 ` [PATCH iproute2-next 1/5] Sync uAPI headers Ido Schimmel
2025-02-24 6:52 ` [PATCH iproute2-next 2/5] iprule: Move port parsing to a function Ido Schimmel
2025-02-24 14:47 ` Petr Machata
2025-02-24 6:52 ` Ido Schimmel [this message]
2025-02-24 14:47 ` [PATCH iproute2-next 3/5] iprule: Allow specifying ports in hexadecimal notation Petr Machata
2025-02-24 6:52 ` [PATCH iproute2-next 4/5] iprule: Add port mask support Ido Schimmel
2025-02-24 14:03 ` Petr Machata
2025-02-24 16:17 ` Ido Schimmel
2025-02-24 6:52 ` [PATCH iproute2-next 5/5] iprule: Add DSCP " Ido Schimmel
2025-02-24 14:35 ` Petr Machata
2025-02-24 16:27 ` Ido Schimmel
2025-02-25 8:58 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250224065241.236141-4-idosch@nvidia.com \
--to=idosch@nvidia.com \
--cc=dsahern@gmail.com \
--cc=gnault@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.