From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 109CDC021A4 for ; Mon, 24 Feb 2025 11:35:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sQt55PP/3p22bMJqt1UFuf3lBx3jwhr/yZzOCosXVwY=; b=ilOeQCf4Kju0e1+4ccW98muWju D0Y8SIUIN8EPtbOgK66pGo6RERQTEdajf9p4ctVNolUu5xyTYx5UbZpXluTl1uQkleOj1nxRkl0Fy IhwJtCc6W6v5kZh2O6mxBYjHypA6HlfstcNQ1WHO6sy9TIoznHpbS3H5OdgP1oFw0WITTYNOzmaAs LSzmA/uAohEz+RboVKNJR9UsaS1beXUSFFu9bNo+epHNIG2S0POibwlPuu4U3TaO5+TIiUMjPicd2 JA1pq9r3C8J6JuhxR+6BUZUGdm/ABDO76KnErLE9obAn0wPUqHQue8hsWvHVizgaP4M4F9LfMCShi gBpErYWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tmWkE-0000000DQxB-1U69; Mon, 24 Feb 2025 11:35:30 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tmWWW-0000000DKox-1PbR for linux-nvme@lists.infradead.org; Mon, 24 Feb 2025 11:21:21 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D58395C6BED; Mon, 24 Feb 2025 11:20:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B885C4CEE6; Mon, 24 Feb 2025 11:21:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740396079; bh=tU9PL4B2+Kt5WzENqM6ZfE/zAnAPrKbYsHwiA8PEfjk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=o+LRhU4j3Pt5Ok2OyMRGF89PG/FFj2ctmIUuoK7UcfpNUiOUg+3EDlBSazYuR+//B D8/lPpUo2ZnSjoxDPrZkp56x3+CwicGwbs8D07pdU6uzxjTefhdNfHTa/sfeDMvKl0 xa+v3WEi6wwE7zIfGN5a5DH6djY6+JyyHt3MrkdL2eI1Qq+Ul2SRdkD1tL17gL1N+S D7gWMlSPFRogwJgooQU9GJEi0AUdQcAAhqiJmy2lWhR4lUUpdnYF7PBN1l6wysRWL0 N+68Ygy/XZ54R7W4BfWIafAynItPtAK1CyMbwq4PED+2GVKKD/dFATs1i7nb3/TsbS zpG+S+0TS4dYQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ruozhu Li , Sagi Grimberg , Keith Busch , Sasha Levin , kch@nvidia.com, linux-nvme@lists.infradead.org Subject: [PATCH AUTOSEL 5.4 2/4] nvmet-rdma: recheck queue state is LIVE in state lock in recv done Date: Mon, 24 Feb 2025 06:21:10 -0500 Message-Id: <20250224112115.2215137-2-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250224112115.2215137-1-sashal@kernel.org> References: <20250224112115.2215137-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.290 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250224_032120_464523_A9959E04 X-CRM114-Status: GOOD ( 11.89 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org From: Ruozhu Li [ Upstream commit 3988ac1c67e6e84d2feb987d7b36d5791174b3da ] The queue state checking in nvmet_rdma_recv_done is not in queue state lock.Queue state can transfer to LIVE in cm establish handler between state checking and state lock here, cause a silent drop of nvme connect cmd. Recheck queue state whether in LIVE state in state lock to prevent this issue. Signed-off-by: Ruozhu Li Reviewed-by: Sagi Grimberg Signed-off-by: Keith Busch Signed-off-by: Sasha Levin --- drivers/nvme/target/rdma.c | 33 +++++++++++++++++++++++---------- 1 file changed, 23 insertions(+), 10 deletions(-) diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c index ae41b6001c7e2..b6d84b6493e14 100644 --- a/drivers/nvme/target/rdma.c +++ b/drivers/nvme/target/rdma.c @@ -777,6 +777,27 @@ static void nvmet_rdma_handle_command(struct nvmet_rdma_queue *queue, nvmet_req_complete(&cmd->req, status); } +static bool nvmet_rdma_recv_not_live(struct nvmet_rdma_queue *queue, + struct nvmet_rdma_rsp *rsp) +{ + unsigned long flags; + bool ret = true; + + spin_lock_irqsave(&queue->state_lock, flags); + /* + * recheck queue state is not live to prevent a race condition + * with RDMA_CM_EVENT_ESTABLISHED handler. + */ + if (queue->state == NVMET_RDMA_Q_LIVE) + ret = false; + else if (queue->state == NVMET_RDMA_Q_CONNECTING) + list_add_tail(&rsp->wait_list, &queue->rsp_wait_list); + else + nvmet_rdma_put_rsp(rsp); + spin_unlock_irqrestore(&queue->state_lock, flags); + return ret; +} + static void nvmet_rdma_recv_done(struct ib_cq *cq, struct ib_wc *wc) { struct nvmet_rdma_cmd *cmd = @@ -818,17 +839,9 @@ static void nvmet_rdma_recv_done(struct ib_cq *cq, struct ib_wc *wc) rsp->req.port = queue->port; rsp->n_rdma = 0; - if (unlikely(queue->state != NVMET_RDMA_Q_LIVE)) { - unsigned long flags; - - spin_lock_irqsave(&queue->state_lock, flags); - if (queue->state == NVMET_RDMA_Q_CONNECTING) - list_add_tail(&rsp->wait_list, &queue->rsp_wait_list); - else - nvmet_rdma_put_rsp(rsp); - spin_unlock_irqrestore(&queue->state_lock, flags); + if (unlikely(queue->state != NVMET_RDMA_Q_LIVE) && + nvmet_rdma_recv_not_live(queue, rsp)) return; - } nvmet_rdma_handle_command(queue, rsp); } -- 2.39.5