From: Jakub Kicinski <kuba@kernel.org>
To: Jiayuan Chen <jiayuan.chen@linux.dev>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org, ricardo@marliere.net,
viro@zeniv.linux.org.uk, dmantipov@yandex.ru,
aleksander.lobakin@intel.com, linux-ppp@vger.kernel.org,
linux-kernel@vger.kernel.org, mrpre@163.com,
syzbot+853242d9c9917165d791@syzkaller.appspotmail.com
Subject: Re: [PATCH net-next v2 1/1] ppp: Fix KMSAN warning by initializing 2-byte header
Date: Mon, 24 Feb 2025 16:07:06 -0800 [thread overview]
Message-ID: <20250224160706.1ebde164@kernel.org> (raw)
In-Reply-To: <fm6hvchejtwpqp55te7rbiwt6y2pmjywikfdpnfv5ao5otxzm3@yxfem4zhdqkp>
On Tue, 25 Feb 2025 07:20:08 +0800 Jiayuan Chen wrote:
> I apologize for the mistake, I've investigated the original maintainer's
> user-space PPP implementation and libpcap's behavior, and found that
> initializing the first byte to 0 or 1 is necessary, it indicates
> direction, which is used in libpcap to distinguish between inbound and
> outbound traffic.
> For more details, please refer to the cover letter of my v3 patch.
>
> https://lore.kernel.org/linux-ppp/20250222092556.274267-1-jiayuan.chen@linux.dev/T/#t
You can still use the htons() there, it's cleaner.
prev parent reply other threads:[~2025-02-25 0:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 6:12 [PATCH net-next v2 0/1] ppp: Fix KMSAN uninit-value warning with bpf Jiayuan Chen
2025-02-21 6:12 ` [PATCH net-next v2 1/1] ppp: Fix KMSAN warning by initializing 2-byte header Jiayuan Chen
2025-02-24 22:26 ` Jakub Kicinski
2025-02-24 23:20 ` Jiayuan Chen
2025-02-25 0:07 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250224160706.1ebde164@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=dmantipov@yandex.ru \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiayuan.chen@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=mrpre@163.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ricardo@marliere.net \
--cc=syzbot+853242d9c9917165d791@syzkaller.appspotmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.