From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwvid.c:174 brcmf_fwvid_attach() warn: inconsistent returns 'global &fwvid_list_lock'.
Date: Mon, 24 Feb 2025 18:37:39 +0800 [thread overview]
Message-ID: <202502241801.kEXc4P9w-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Hector Martin <marcan@marcan.st>
CC: Kalle Valo <kvalo@kernel.org>
CC: Arend van Spriel <arend.vanspriel@broadcom.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: d082ecbc71e9e0bf49883ee4afd435a77a5101b6
commit: 85da8f71aaa7b83ea7ef0e89182e0cd47e16d465 wifi: brcmfmac: Demote vendor-specific attach/detach messages to info
date: 1 year, 1 month ago
:::::: branch date: 14 hours ago
:::::: commit date: 1 year, 1 month ago
config: powerpc-randconfig-r071-20250224 (https://download.01.org/0day-ci/archive/20250224/202502241801.kEXc4P9w-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 14.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202502241801.kEXc4P9w-lkp@intel.com/
smatch warnings:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwvid.c:174 brcmf_fwvid_attach() warn: inconsistent returns 'global &fwvid_list_lock'.
vim +174 drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwvid.c
d6a5c562214f26e Arend van Spriel 2022-11-29 151
85da8f71aaa7b83 Hector Martin 2024-01-06 152 int brcmf_fwvid_attach(struct brcmf_pub *drvr)
d6a5c562214f26e Arend van Spriel 2022-11-29 153 {
d6a5c562214f26e Arend van Spriel 2022-11-29 154 enum brcmf_fwvendor fwvid = drvr->bus_if->fwvid;
d6a5c562214f26e Arend van Spriel 2022-11-29 155 int ret;
d6a5c562214f26e Arend van Spriel 2022-11-29 156
d6a5c562214f26e Arend van Spriel 2022-11-29 157 if (fwvid >= ARRAY_SIZE(fwvid_list))
d6a5c562214f26e Arend van Spriel 2022-11-29 158 return -ERANGE;
d6a5c562214f26e Arend van Spriel 2022-11-29 159
d6a5c562214f26e Arend van Spriel 2022-11-29 160 brcmf_dbg(TRACE, "mod=%s: enter: dev %s\n", fwvid_list[fwvid].name,
d6a5c562214f26e Arend van Spriel 2022-11-29 161 dev_name(drvr->bus_if->dev));
d6a5c562214f26e Arend van Spriel 2022-11-29 162
d6a5c562214f26e Arend van Spriel 2022-11-29 163 mutex_lock(&fwvid_list_lock);
d6a5c562214f26e Arend van Spriel 2022-11-29 164
d6a5c562214f26e Arend van Spriel 2022-11-29 165 ret = brcmf_fwvid_request_module(fwvid);
d6a5c562214f26e Arend van Spriel 2022-11-29 166 if (ret)
d6a5c562214f26e Arend van Spriel 2022-11-29 167 return ret;
d6a5c562214f26e Arend van Spriel 2022-11-29 168
d6a5c562214f26e Arend van Spriel 2022-11-29 169 drvr->vops = fwvid_list[fwvid].vops;
d6a5c562214f26e Arend van Spriel 2022-11-29 170 list_add(&drvr->bus_if->list, &fwvid_list[fwvid].drvr_list);
d6a5c562214f26e Arend van Spriel 2022-11-29 171
d6a5c562214f26e Arend van Spriel 2022-11-29 172 mutex_unlock(&fwvid_list_lock);
d6a5c562214f26e Arend van Spriel 2022-11-29 173
d6a5c562214f26e Arend van Spriel 2022-11-29 @174 return ret;
d6a5c562214f26e Arend van Spriel 2022-11-29 175 }
d6a5c562214f26e Arend van Spriel 2022-11-29 176
:::::: The code at line 174 was first introduced by commit
:::::: d6a5c562214f26e442c8ec3ff1e28e16675d1bcf wifi: brcmfmac: add support for vendor-specific firmware api
:::::: TO: Arend van Spriel <arend.vanspriel@broadcom.com>
:::::: CC: Kalle Valo <kvalo@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2025-02-24 10:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202502241801.kEXc4P9w-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.