Re: [PATCH] samples/damon: a typo in the kconfig - sameple

[SeongJae Park <sj@kernel.org>]

Hi bus710,


Thank you again for your nice patch, but I think you're not very used to the
normal process of Linux kernel development.  Let me give you some comments
about that.

Firstly, if you post a new version of a patch, please add the version number on
the subject[1].

On Mon, 24 Feb 2025 12:06:55 -0800 bus710 <bus710@gmail.com> wrote:

> Hi SeongJae Park, 
> 
> I found a trivial typo in the Kconfig file of the damon sample module
> while I was trying to do some experiments with sample codes.
> The word "sameple" should be "sample", I believe. 
> Please find the diff below.
> 
> Since the title should follow the format of the project, I sent a new
> email to the mailing list. Sorry for the inconvenience.
> 
> Thanks for the interesting project! DAMON will be very useful for many
> projects.
> 
> Thanks,

You are using explanation body as a mixture of the two different parts.  Please
refer to the documentation[2] about "explanation body" and "commentary" parts
of patches for more details about what to put on where.

> 
> Ps: I found I didn't change the subject! Sorry this is my very first
> communication with the project.
> 
> Ps2: I see. It should go over my signature. Good to know for
> future.

If you want to reply to some of my comments, please reply as a normal email
with inline commenting style, not as a new version of a patch having Ps
sections.

> 
> Signed-off-by: bus710 <bus710@gmail.com>

Finally, please collect 'Reviewed-by:' like tags you received from the previous
version of the patch if possible.

Because I already gave you my Reviewed-by: tag, I don't think you need to
continue revising this patch.

I'd also highly recommend you the entire documentation of patches submission.

[1] https://docs.kernel.org/process/submitting-patches.html#subject-line
[2] https://docs.kernel.org/process/submitting-patches.html#explanation-body
[3] https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes


Thanks,
SJ

[...]