All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Yufeng Wang <wangyufeng@kylinos.cn>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the vhost tree
Date: Tue, 25 Feb 2025 07:12:02 -0500	[thread overview]
Message-ID: <20250225071114-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20250225094550.07b771f9@canb.auug.org.au>

On Tue, Feb 25, 2025 at 09:45:50AM +1100, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   b995427e8a85 ("tools: virtio/linux/module.h add MODULE_DESCRIPTION() define.")
> 
> Fixes tag
> 
>   Fixes: <ab0727f3ddb8>("virtio: add missing MODULE_DESCRIPTION() macros")
> 
> has these problem(s):
> 
>   - No SHA1 recognised
> 
> In commit
> 
>   9709a9145ffe ("tools/virtio: Add DMA_MAPPING_ERROR and sg_dma_len api define for virtio test")
> 
> Fixes tag
> 
>   Fixes: <c7e1b422afac>("virtio_ring: perform premapped operations based on per-buffer")
> 
> has these problem(s):
> 
>   - No SHA1 recognised
> 
> Fixes tags should be
> 
> Fixes: SHA1 ("subject")
> 
> Also, please keep all the commit message tags together at the end of
> the commit message.


Yep. Thanks, fixed up. Yufeng Wang, pls take a look at my fixup -
both to check them and to make sure to follow this example
in the future.

> -- 
> Cheers,
> Stephen Rothwell



  reply	other threads:[~2025-02-25 12:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-24 22:45 linux-next: Fixes tag needs some work in the vhost tree Stephen Rothwell
2025-02-25 12:12 ` Michael S. Tsirkin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-08-07 22:22 Stephen Rothwell
2022-08-10 22:28 Stephen Rothwell
2021-10-24 21:23 Stephen Rothwell
2021-09-14 21:24 Stephen Rothwell
2021-09-13 23:23 Stephen Rothwell
2021-08-10 22:22 Stephen Rothwell
2021-04-22 22:43 Stephen Rothwell
2020-10-01 22:32 Stephen Rothwell
2020-10-01 23:03 ` si-wei liu
2020-05-02  0:30 Stephen Rothwell
2020-05-05 15:16 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250225071114-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=wangyufeng@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.