From: Stephen Hemminger <stephen@networkplumber.org>
To: Chaoyong He <chaoyong.he@corigine.com>
Cc: dev@dpdk.org, oss-drivers@corigine.com,
Long Wu <long.wu@corigine.com>,
peng.zhang@corigine.com, stable@dpdk.org
Subject: Re: [PATCH] net/nfp: fix get represetor wrong port stats
Date: Tue, 25 Feb 2025 08:17:37 -0800 [thread overview]
Message-ID: <20250225081737.09e63d56@hermes.local> (raw)
In-Reply-To: <20250225013454.442170-1-chaoyong.he@corigine.com>
On Tue, 25 Feb 2025 09:34:54 +0800
Chaoyong He <chaoyong.he@corigine.com> wrote:
> From: Long Wu <long.wu@corigine.com>
>
> The 'ipackets'/'opackets' are used to record the number
> of packets on represetor port received/sent. But the
> code does not consider concurrent calculation of
> 'ipackets'/'opackets'. If multiple queues are calculated
> 'ipackets'/'opackets' simultaneously, it will result in
> incorrect results.
>
> The previous logic has recorded the number of packets on
> each queue, therefore driver only needs to add the data of
> all queues to obtain the data of the representor port.
>
> Based on this, modify code to fix the issue.
>
> Fixes: 636e133ec891 ("net/nfp: update Tx and Rx for multiple PF")
> Fixes: 82a2c286f35a ("net/nfp: support xstats for flower firmware")
> Cc: peng.zhang@corigine.com
> Cc: chaoyong.he@corigine.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Long Wu <long.wu@corigine.com>
Applied to next-net and fixed spelling in commit message.
prev parent reply other threads:[~2025-02-25 16:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 1:34 [PATCH] net/nfp: fix get represetor wrong port stats Chaoyong He
2025-02-25 16:17 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250225081737.09e63d56@hermes.local \
--to=stephen@networkplumber.org \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=long.wu@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.