All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org, joshwash@google.com
Cc: Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 6.6.y] gve: set xdp redirect target only when it is available
Date: Tue, 25 Feb 2025 11:13:51 -0500	[thread overview]
Message-ID: <20250225103916-7c666ca3f8493440@stable.kernel.org> (raw)
In-Reply-To: <20250224195238.961070-1-joshwash@google.com>

[ Sasha's backport helper bot ]

Hi,

Summary of potential issues:
⚠️ Found matching upstream commit but patch is missing proper reference to it

Found matching upstream commit: 415cadd505464d9a11ff5e0f6e0329c127849da5

Note: The patch differs from the upstream commit:
---
1:  415cadd505464 ! 1:  f1af823cbe6e3 gve: set xdp redirect target only when it is available
    @@ Commit message
         Signed-off-by: Joshua Washington <joshwash@google.com>
         Link: https://patch.msgid.link/20250214224417.1237818-1-joshwash@google.com
         Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    +    (cherry picked from commit 415cadd505464d9a11ff5e0f6e0329c127849da5)
    +    Signed-off-by: Joshua Washington <joshwash@google.com>
     
      ## drivers/net/ethernet/google/gve/gve.h ##
     @@ drivers/net/ethernet/google/gve/gve.h: static inline u32 gve_xdp_tx_start_queue_id(struct gve_priv *priv)
    @@ drivers/net/ethernet/google/gve/gve.h: static inline u32 gve_xdp_tx_start_queue_
     +	}
     +}
     +
    - /* gqi napi handler defined in gve_main.c */
    - int gve_napi_poll(struct napi_struct *napi, int budget);
    - 
    + /* buffers */
    + int gve_alloc_page(struct gve_priv *priv, struct device *dev,
    + 		   struct page **page, dma_addr_t *dma,
     
      ## drivers/net/ethernet/google/gve/gve_main.c ##
     @@ drivers/net/ethernet/google/gve/gve_main.c: static void gve_turndown(struct gve_priv *priv)
    @@ drivers/net/ethernet/google/gve/gve_main.c: static void gve_turndown(struct gve_
      	gve_clear_report_stats(priv);
      
     @@ drivers/net/ethernet/google/gve/gve_main.c: static void gve_turnup(struct gve_priv *priv)
    - 		napi_schedule(&block->napi);
    + 		}
      	}
      
     +	if (priv->num_xdp_queues && gve_supports_xdp_xmit(priv))
---

Results of testing on various branches:

| Branch                    | Patch Apply | Build Test |
|---------------------------|-------------|------------|
| stable/linux-6.6.y        |  Success    |  Success   |

      reply	other threads:[~2025-02-25 16:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-24 10:29 FAILED: patch "[PATCH] gve: set xdp redirect target only when it is available" failed to apply to 6.6-stable tree gregkh
2025-02-24 19:52 ` [PATCH 6.6.y] gve: set xdp redirect target only when it is available Joshua Washington
2025-02-25 16:13   ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250225103916-7c666ca3f8493440@stable.kernel.org \
    --to=sashal@kernel.org \
    --cc=joshwash@google.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.