From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4C78166F07 for ; Tue, 25 Feb 2025 15:54:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740498880; cv=none; b=RvoqZKmWyAnM9VHZjs2bS/kg+nsLLXBt+jQ7IoLC4ulZ7wvoU9ZxlGxwln2BLGCZ1F2+Dd/yTF3Jbkaw1u8pcmwxU2FZl6tqX67mL+js/5RtDyVwsM0L+800sds2Dk/d2nf+XnNiuWp60BuRoF5mfdcf7qeVcFjTvTyXufBCvYA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740498880; c=relaxed/simple; bh=B6guPeoLoNZZxbWYmAHZ5bN7rRVPk1E7b3Qht1EElwE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DEaFTQ9X83GOMPyXAnsLze7DDCPsX9gx/KjzZKGw3ig5l3oORS8YqubqqQLvW20LsGrIUntsChvfHVFkUX0J97GSrxLaJHxbsKRa5ZanYM/Fjy/va5NvKHjJfPTOBkhKY+n3CAsZtoB018uw8lez1qRx/dUSHpkAOBqzYXmeNfw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=d2oHAvwv; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="d2oHAvwv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740498877; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RM+x+J7eeR+zYm9ULF/axeMhLxPe1qiv9A3ZyXjbFuI=; b=d2oHAvwvc4PE/zA18SlCCvk6xm9uHztm2JYp8U6ECyCYJupYzEAcmyPDwPsuOyBImyFene v24xHhRg2uJLl+JO7sl9J7lyZqDrMIvaG+v589dVk14jCrQyL3T71BYvQyj9GV3Xgl9No0 EctLOdZNEnNc6kGDO/1yaxo5VkpQ7is= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-ca5XKG6wOV-mA5zlHFTQZg-1; Tue, 25 Feb 2025 10:54:33 -0500 X-MC-Unique: ca5XKG6wOV-mA5zlHFTQZg-1 X-Mimecast-MFC-AGG-ID: ca5XKG6wOV-mA5zlHFTQZg_1740498872 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-38f2ef5f0dbso2143881f8f.2 for ; Tue, 25 Feb 2025 07:54:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740498872; x=1741103672; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RM+x+J7eeR+zYm9ULF/axeMhLxPe1qiv9A3ZyXjbFuI=; b=ZPe0FGvXjZEo7D4WrxfIKoYuA94Oq2pfoh/mviG3Xd1kZ5lNWPowdcvgNVj3Gf8xah aJR7lY6UQoKkAo1y59PKlIiLR+7DBQcMyrINn6qgfOcaUrueBDaswPvoUGXKerQQNpF0 RDliZBDSQS0s3Sr3nwpgmW24ON3mSwLrg0QtfOyhl7vh9jSEMNdmOx/COORdMx8xhOOH JMyxeq3bAzyuQ2EVvGRFMLXXuN0/cakVEyfx7I64JCQAZMA1oR1tU7NSJuRKxfDrFgXy yMHYK7Q2rNbkQzQY++EzICL0aKFbhDFtdz4W9ZaM4cZR1w0ErJjgCv6XZDrV2hr+uK0p R3Jg== X-Forwarded-Encrypted: i=1; AJvYcCU7jwBZW6Vl6yfryTS1tYcFXswgtStWMTz/lPLN/N+OjShFHJ8epw1dnOQe6ApUnbiufHI=@vger.kernel.org X-Gm-Message-State: AOJu0YxvPwd1uBTPRjg6lijmPm4S4WKhUaJk0oydGFkEEgRk2lEUIhVp LntzWkHJdiPqPV6AR/UFSJRFoGsDPWKR7L+5K/hHI0inTBeQk4T8MuZBV/wNypSGSz00ywPKbD1 ne5cCoid9fvlnIY1P5h42bO6L/PN3WpOlG75ZZzuj9Gdoah4bLw== X-Gm-Gg: ASbGncvwZ5ju0Wm5sY7lYsVo6q+tYzyk2wQBugeMIwweteptWTUSLdM8xrFlbocoLZw t7K/vqkbxt2jvsPxPF0GoX+8zNJbpa65Ld6FAL/8fygT6bycRGPK4IjNenDoD/WZ9Y61FkIOtBj QAO8t5C/41tWai0bCZkwobDVSgLRxWzlp1AhRDczLkfhmVSVKz/Iwg6RVbHCjSm7+FrTN4yLwDC HL+gaGrzvQ0IP/Hq2eudk3aB0LhbGiSDvfL6Hj+fKRVzBbYEMAuU7EDqG9Jv55bC9K2NfFDEeUZ X-Received: by 2002:a05:6000:4008:b0:38f:4e30:6bba with SMTP id ffacd0b85a97d-390cc609228mr3580791f8f.23.1740498872415; Tue, 25 Feb 2025 07:54:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IHN4AARjN7wYgWWN9IZdCNUwZ68WPfkZ8QQrVfbimeKsOa/InqaQkeFml1FEQVyd0AsQFCcmw== X-Received: by 2002:a05:6000:4008:b0:38f:4e30:6bba with SMTP id ffacd0b85a97d-390cc609228mr3580751f8f.23.1740498871961; Tue, 25 Feb 2025 07:54:31 -0800 (PST) Received: from redhat.com ([2.52.7.97]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43ab1532d9dsm32083345e9.6.2025.02.25.07.54.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2025 07:54:31 -0800 (PST) Date: Tue, 25 Feb 2025 10:54:27 -0500 From: "Michael S. Tsirkin" To: Joe Damato Cc: netdev@vger.kernel.org, mkarsten@uwaterloo.ca, gerhard@engleder-embedded.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, kuba@kernel.org, Alexei Starovoitov , Andrew Lunn , "open list:XDP (eXpress Data Path):Keyword:(?:b|_)xdp(?:b|_)" , Daniel Borkmann , "David S. Miller" , Eric Dumazet , Eugenio =?iso-8859-1?Q?P=E9rez?= , Jesper Dangaard Brouer , John Fastabend , open list , Paolo Abeni , "open list:VIRTIO CORE AND NET DRIVERS" Subject: Re: [PATCH net-next v4 0/4] virtio-net: Link queues to NAPIs Message-ID: <20250225105420-mutt-send-email-mst@kernel.org> References: <20250225020455.212895-1-jdamato@fastly.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250225020455.212895-1-jdamato@fastly.com> On Tue, Feb 25, 2025 at 02:04:47AM +0000, Joe Damato wrote: > Greetings: > > Welcome to v4. > > Jakub recently commented [1] that I should not hold this series on > virtio-net linking queues to NAPIs behind other important work that is > on-going and suggested I re-spin, so here we are :) > > This is a significant refactor from the rfcv3 and as such I've dropped > almost all of the tags from reviewers except for patch 4 (sorry Gerhard > and Jason; the changes are significant so I think patches 1-3 need to be > re-reviewed). > > As per the discussion on the v3 [2], now both RX and TX NAPIs use the > API to link queues to NAPIs. Since TX-only NAPIs don't have a NAPI ID, > commit 6597e8d35851 ("netdev-genl: Elide napi_id when not present") now > correctly elides the TX-only NAPIs (instead of printing zero) when the > queues and NAPIs are linked. > > See the commit message of patch 3 for an example of how to get the NAPI > to queue mapping information. > > See the commit message of patch 4 for an example of how NAPI IDs are > persistent despite queue count changes. > > Thanks, > Joe Acked-by: Michael S. Tsirkin > v4: > - Dropped Jakub's patch (previously patch 1). > - Significant refactor from v3 affecting patches 1-3. > - Patch 4 added tags from Jason and Gerhard. > > rfcv3: https://lore.kernel.org/netdev/20250121191047.269844-1-jdamato@fastly.com/ > - patch 3: > - Removed the xdp checks completely, as Gerhard Engleder pointed > out, they are likely not necessary. > > - patch 4: > - Added Xuan Zhuo's Reviewed-by. > > v2: https://lore.kernel.org/netdev/20250116055302.14308-1-jdamato@fastly.com/ > - patch 1: > - New in the v2 from Jakub. > > - patch 2: > - Previously patch 1, unchanged from v1. > - Added Gerhard Engleder's Reviewed-by. > - Added Lei Yang's Tested-by. > > - patch 3: > - Introduced virtnet_napi_disable to eliminate duplicated code > in virtnet_xdp_set, virtnet_rx_pause, virtnet_disable_queue_pair, > refill_work as suggested by Jason Wang. > - As a result of the above refactor, dropped Reviewed-by and > Tested-by from patch 3. > > - patch 4: > - New in v2. Adds persistent NAPI configuration. See commit message > for more details. > > v1: https://lore.kernel.org/netdev/20250110202605.429475-1-jdamato@fastly.com/ > > [1]: https://lore.kernel.org/netdev/20250221142650.3c74dcac@kernel.org/ > [2]: https://lore.kernel.org/netdev/20250127142400.24eca319@kernel.org/ > > Joe Damato (4): > virtio-net: Refactor napi_enable paths > virtio-net: Refactor napi_disable paths > virtio-net: Map NAPIs to queues > virtio_net: Use persistent NAPI config > > drivers/net/virtio_net.c | 100 ++++++++++++++++++++++++++++----------- > 1 file changed, 73 insertions(+), 27 deletions(-) > > > base-commit: 7183877d6853801258b7a8d3b51b415982e5097e > -- > 2.45.2