From: Christoph Hellwig <hch@lst.de>
To: Anuj Gupta <anuj20.g@samsung.com>
Cc: axboe@kernel.dk, hch@lst.de, kbusch@kernel.org,
martin.petersen@oracle.com, anuj1072538@gmail.com,
nikh1092@linux.ibm.com, linux-nvme@lists.infradead.org,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
dm-devel@lists.linux.dev
Subject: Re: [PATCH v1 2/3] nvme: Fix incorrect block integrity sysfs values for non-PI namespaces
Date: Tue, 25 Feb 2025 16:07:53 +0100 [thread overview]
Message-ID: <20250225150753.GB6099@lst.de> (raw)
In-Reply-To: <20250225044653.6867-3-anuj20.g@samsung.com>
On Tue, Feb 25, 2025 at 10:16:52AM +0530, Anuj Gupta wrote:
> memset(bi, 0, sizeof(*bi));
>
> + bi->flags = BLK_INTEGRITY_NOGENERATE | BLK_INTEGRITY_NOVERIFY;
> if (!head->ms)
> return true;
>
> @@ -1850,6 +1851,9 @@ static bool nvme_init_integrity(struct nvme_ns_head *head,
> break;
> }
>
> + if (bi->flags & BLK_INTEGRITY_DEVICE_CAPABLE)
> + bi->flags &= ~(BLK_INTEGRITY_NOGENERATE |
> + BLK_INTEGRITY_NOVERIFY);
I don't think the driver is the proper place to do this, this should
be done in blk_validate_integrity_limits. That should also take care
or the stacked devices and remove the need for the last hunk in the
previous patch.
next prev parent reply other threads:[~2025-02-25 15:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250225045511epcas5p2d89efcac39b6553317e93e8c7fea3f2b@epcas5p2.samsung.com>
2025-02-25 4:46 ` [PATCH v1 0/3] Fix integrity sysfs reporting inconsistencies across NVMe, SCSI, and DM Anuj Gupta
2025-02-25 4:46 ` [PATCH v1 1/3] block: Fix incorrect integrity sysfs reporting for DM devices Anuj Gupta
2025-02-25 15:06 ` Christoph Hellwig
2025-02-26 11:27 ` Anuj gupta
2025-02-25 4:46 ` [PATCH v1 2/3] nvme: Fix incorrect block integrity sysfs values for non-PI namespaces Anuj Gupta
2025-02-25 15:07 ` Christoph Hellwig [this message]
2025-02-25 4:46 ` [PATCH v1 3/3] scsi: Fix incorrect integrity sysfs values when HBA doesn't support DIX Anuj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250225150753.GB6099@lst.de \
--to=hch@lst.de \
--cc=anuj1072538@gmail.com \
--cc=anuj20.g@samsung.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@lists.linux.dev \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nikh1092@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.